Re: worker_spi example BGW code GUC tweak

2017-12-17 Thread Robert Haas
On Sun, Dec 17, 2017 at 8:30 PM, Chapman Flack wrote: > On 12/17/2017 07:32 PM, Robert Haas wrote: >> Making it use GUC_UNIT_S seems like a good idea to me, but removing >> the mention of seconds from the description doesn't seem like a good >> idea to me. > > I took for my

Re: worker_spi example BGW code GUC tweak

2017-12-17 Thread Chapman Flack
On 12/17/2017 07:32 PM, Robert Haas wrote: > Making it use GUC_UNIT_S seems like a good idea to me, but removing > the mention of seconds from the description doesn't seem like a good > idea to me. I took for my model a quick survey of existing GUCs that use GUC_UNIT_(MS|S|MIN) - most of which

Re: worker_spi example BGW code GUC tweak

2017-12-17 Thread Robert Haas
On Thu, Dec 14, 2017 at 5:41 PM, Chapman Flack wrote: > Would this sample code make an even better teaching example if it > used the existing GUC way to declare that worker_spi.naptime is > in units of seconds? > > Or does it not do that for some reason I've overlooked?

worker_spi example BGW code GUC tweak

2017-12-14 Thread Chapman Flack
Would this sample code make an even better teaching example if it used the existing GUC way to declare that worker_spi.naptime is in units of seconds? Or does it not do that for some reason I've overlooked? -Chap >From 50fd326e5c1ff033c701f90ce09ab9b15d600593 Mon Sep 17 00:00:00 2001 From: