Re: [HACKERS] Logical Replication WIP

2016-12-18 Thread Erik Rijkers
On 2016-12-18 11:12, Petr Jelinek wrote: (now using latest: patchset:) 0001-Add-PUBLICATION-catalogs-and-DDL-v14.patch 0002-Add-SUBSCRIPTION-catalog-and-DDL-v14.patch 0003-Define-logical-replication-protocol-and-output-plugi-v14.patch 0004-Add-logical-replication-workers-v14.patch

Re: [HACKERS] Declarative partitioning vs. sql_inheritance

2016-12-18 Thread Amit Langote
On 2016/12/17 10:40, Robert Haas wrote: > On Fri, Dec 16, 2016 at 7:39 PM, Tom Lane wrote: >> Peter Eisentraut writes: >>> On 12/16/16 11:05 AM, Robert Haas wrote: If we were going to do anything about this, my vote would be to

Re: [HACKERS] postgres_fdw bug in 9.6

2016-12-18 Thread Ashutosh Bapat
On Fri, Dec 16, 2016 at 9:43 PM, Tom Lane wrote: > Etsuro Fujita writes: >> On 2016/12/16 11:25, Etsuro Fujita wrote: >>> As I said upthread, an alternative I am thinking is (1) to create an >>> equivalent nestloop join path using inner/outer

Re: [HACKERS] postgres_fdw bug in 9.6

2016-12-18 Thread Etsuro Fujita
On 2016/12/17 1:13, Tom Lane wrote: Etsuro Fujita writes: On 2016/12/16 11:25, Etsuro Fujita wrote: As I said upthread, an alternative I am thinking is (1) to create an equivalent nestloop join path using inner/outer paths of a foreign join path, except when that

Re: [HACKERS] Creating a DSA area to provide work space for parallel execution

2016-12-18 Thread Thomas Munro
On Sat, Dec 17, 2016 at 5:41 AM, Robert Haas wrote: > On Wed, Dec 14, 2016 at 3:25 PM, Robert Haas wrote: >> Thoughts? > > Hearing no objections, I've gone ahead and committed this. If that > makes somebody really unhappy I can revert it, but I am

Re: [HACKERS] Retire src/backend/port/dynloader/linux.c ?

2016-12-18 Thread Peter Eisentraut
On 12/18/16 10:19 PM, Tom Lane wrote: > Andres Freund writes: >> Shouldn't we just remove that code? > > What for? It's maintenance-free ... hasn't been touched since 2004. > While I agree with you that it's *probably* dead code, it's hard to > see much upside from removing

Re: [HACKERS] Retire src/backend/port/dynloader/linux.c ?

2016-12-18 Thread Tom Lane
Andres Freund writes: > Shouldn't we just remove that code? What for? It's maintenance-free ... hasn't been touched since 2004. While I agree with you that it's *probably* dead code, it's hard to see much upside from removing it. If we want to get into arguing whether code

Re: [HACKERS] Measuring replay lag

2016-12-18 Thread Peter Eisentraut
On 11/22/16 4:27 AM, Thomas Munro wrote: > Thanks very much for testing! New version attached. I will add this > to the next CF. I don't see it there yet. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --

Re: [HACKERS] Declarative partitioning - another take

2016-12-18 Thread Amit Langote
On 2016/12/17 11:32, Amit Langote wrote: > On Sat, Dec 17, 2016 at 1:07 AM, Robert Haas wrote: >> On Fri, Dec 16, 2016 at 3:02 AM, Amit Langote >> wrote: >>> Aside from the above, I found few other issues and fixed them in the >>> attached

[HACKERS] Retire src/backend/port/dynloader/linux.c ?

2016-12-18 Thread Andres Freund
Hi, I don't think PG works on any linux without dlopen(). And DLD (what's used in the dlopen replacement) hasn't been maintained in a while. See https://www.gnu.org/software/dld/ Shouldn't we just remove that code? Greetings, Andres Freund -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Trouble building uuid-ossp extension in new versions of Postgres

2016-12-18 Thread Ryan Murphy
> > On Mac, the recommended thing is to forget about the ossp code and >> use "configure --with-uuid=e2fs". Sorry if that wasn't clear enough. >> >> > Ok thanks, I'll try this. > Thanks Tom, "uuid-ossp" built perfectly with "--with--uuid=e2fs". Cheers and Happy Holidays! Ryan

Re: [HACKERS] delta relations in AFTER triggers

2016-12-18 Thread Thomas Munro
On Sun, Dec 18, 2016 at 3:15 PM, Kevin Grittner wrote: > Patch v8 ... FWIW here's that plpython patch, adjusted to apply on top of your latest patch. -- Thomas Munro http://www.enterprisedb.com delta-relations-plpython.patch Description: Binary data -- Sent via

Re: [HACKERS] Hash tables in dynamic shared memory

2016-12-18 Thread Thomas Munro
On Sun, Nov 20, 2016 at 11:54 AM, John Gorman wrote: > I reviewed the dht-v2.patch and found that it is in excellent shape. Thanks for reviewing! And sorry for the late reply. > Benchmarking shows that this performs somewhat faster than > dynahash which is surprising

Re: [HACKERS] pg_background contrib module proposal

2016-12-18 Thread David Fetter
On Mon, Dec 12, 2016 at 10:17:24PM +0500, Andrew Borodin wrote: > Hi! > > Just in case you'd like to include sleepsort as a test, here it is > wrapped as a regression test(see attachment). But it has serious > downside: it runs no less than 5 seconds. Couldn't it sleep in increments smaller than

Re: [HACKERS] Parallel build with MSVC

2016-12-18 Thread Noah Misch
On Thu, Sep 08, 2016 at 08:54:08AM +0200, Christian Ullrich wrote: > * Noah Misch wrote: > > >Committed. > > Much apologizings for coming in late again, but I just realized it would be > better if the user-controlled flags came after all predefined options the > user might want to override.

Re: [HACKERS] delta relations in AFTER triggers

2016-12-18 Thread Thomas Munro
On Sun, Dec 18, 2016 at 3:15 PM, Kevin Grittner wrote: > On Sun, Dec 4, 2016 at 11:35 PM, Haribabu Kommi > wrote: > >> Moved to next CF with "waiting on author" status. > > Patch v8 attempts to address the issues explicitly raised in > Thomas Munro's

Re: [HACKERS] building HEAD on macos fails with #error no source of random numbers configured

2016-12-18 Thread Peter Eisentraut
On 12/11/16 1:52 PM, Jim Nasby wrote: > On 12/9/16 9:53 AM, Heikki Linnakangas wrote: >>> >>> I'm not sure what --no-recursion does, but I would say that we'd >>> consider that unsupported as well. >> >> Interesting. Running config.status adds those --no-create --no-recursion >> flags

Re: [HACKERS] dblink get_connect_string() passes FDW option "updatable" to the connect string, connection fails.

2016-12-18 Thread Corey Huinker
On Sun, Dec 18, 2016 at 4:57 PM, Michael Paquier wrote: > On Mon, Dec 19, 2016 at 6:48 AM, Joe Conway wrote: > > Maybe if "CREATE FOREIGN DATA WRAPPER" had a way to specify that the FDW > > supports a libpq connection it would make sense to allows

Re: [HACKERS] dblink get_connect_string() passes FDW option "updatable" to the connect string, connection fails.

2016-12-18 Thread Michael Paquier
On Mon, Dec 19, 2016 at 6:48 AM, Joe Conway wrote: > Maybe if "CREATE FOREIGN DATA WRAPPER" had a way to specify that the FDW > supports a libpq connection it would make sense to allows other FDWs > with this attribute, but since there is none the current state strikes > me as

Re: [HACKERS] dblink get_connect_string() passes FDW option "updatable" to the connect string, connection fails.

2016-12-18 Thread Joe Conway
On 11/21/2016 03:59 PM, Corey Huinker wrote: > On 11/21/2016 02:16 PM, Tom Lane wrote: >> The dblink docs recommend using dblink_fdw as the FDW for this purpose, >> which would only accept legal connstr options. However, I can see the >> point of using a postgres_fdw server instead, and

Re: [HACKERS] move collation import to backend

2016-12-18 Thread Peter Eisentraut
On 11/30/16 8:18 AM, Peter Eisentraut wrote: >> It seems not to be project style to have prototypes in the middle of the >> file... > > OK, will fix. Updated patch with that fix. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA,

Re: [HACKERS] Logical Replication WIP

2016-12-18 Thread Steve Singer
On 12/18/2016 05:28 AM, Petr Jelinek wrote: On 17/12/16 18:34, Steve Singer wrote: On 12/16/2016 07:49 AM, Petr Jelinek wrote: Yeah subscriptions are per database. I don't want to make v14 just for these 2 changes as that would make life harder for anybody code-reviewing the v13 so attached

Re: [HACKERS] Hash Indexes

2016-12-18 Thread Amit Kapila
On Fri, Dec 16, 2016 at 9:57 PM, Robert Haas wrote: > On Thu, Dec 15, 2016 at 11:33 AM, Amit Kapila wrote: >> Attached are the two patches on top of remove-hash-wrtbuf. Patch >> fix_dirty_marking_v1.patch allows to mark the buffer dirty in one of

Re: [HACKERS] Proposal for changes to recovery.conf API

2016-12-18 Thread Bruce Momjian
On Sun, Dec 18, 2016 at 02:14:06PM +0100, Magnus Hagander wrote: > >     turn > >     > into another section that we keep around (whether as part of the > release > >     notes, > >     > or as a separate "upgrade steps" section or something). > > > >     I suggest

Re: [HACKERS] Proposal for changes to recovery.conf API

2016-12-18 Thread Magnus Hagander
On Sun, Dec 18, 2016 at 2:11 PM, Bruce Momjian wrote: > On Sun, Dec 18, 2016 at 02:02:58PM +0100, Magnus Hagander wrote: > > > Again, I am fine putting this as a subsection of the release > notes, > > but > > > let's not pretend it is some extra section we

Re: [HACKERS] Proposal for changes to recovery.conf API

2016-12-18 Thread Bruce Momjian
On Sun, Dec 18, 2016 at 02:02:58PM +0100, Magnus Hagander wrote: > >     Again, I am fine putting this as a subsection of the release notes, > but > >     let's not pretend it is some extra section we can remove in five > years. > > > > > > Depends on what we decide to

Re: [HACKERS] Trouble building uuid-ossp extension in new versions of Postgres

2016-12-18 Thread Ryan Murphy
> On Mac, the recommended thing is to forget about the ossp code and > use "configure --with-uuid=e2fs". Sorry if that wasn't clear enough. > > Ok thanks, I'll try this. > Reading over your post again, it sounds like you're trying to force-build > contrib/uuid-ossp without having used any of

Re: [HACKERS] Proposal for changes to recovery.conf API

2016-12-18 Thread Magnus Hagander
On Sun, Dec 18, 2016 at 1:57 PM, Bruce Momjian wrote: > On Sun, Dec 18, 2016 at 12:41:01PM +0100, Magnus Hagander wrote: > > No, they become uninteresting to anyone who has passed Postgres 10. > I > > would argue they are still required to be around even after we stop >

Re: [HACKERS] Proposal for changes to recovery.conf API

2016-12-18 Thread Bruce Momjian
On Sun, Dec 18, 2016 at 12:41:01PM +0100, Magnus Hagander wrote: > No, they become uninteresting to anyone who has passed Postgres 10.  I > would argue they are still required to be around even after we stop > supporting Postgres 9.6 because we know everyone will not upgrade off of >

Re: [HACKERS] Quorum commit for multiple synchronous replication.

2016-12-18 Thread Michael Paquier
On Fri, Dec 16, 2016 at 10:42 PM, Fujii Masao wrote: > Attached is the modified version of the patch. Barring objections, I will > commit this version. There is a whitespace: $ git diff master --check src/backend/replication/syncrep.c:39: trailing whitespace. + * > Even

Re: [HACKERS] Proposal for changes to recovery.conf API

2016-12-18 Thread Magnus Hagander
On Sat, Dec 17, 2016 at 10:34 PM, Bruce Momjian wrote: > On Sat, Dec 17, 2016 at 02:52:41PM +0100, Magnus Hagander wrote: > > The point is that the documentation about the recovery.conf changes > in > > Postgres are only interesting to people migrating to Postgres 10, >

Re: [HACKERS] Logical Replication WIP

2016-12-18 Thread Petr Jelinek
On 17/12/16 18:34, Steve Singer wrote: > On 12/16/2016 07:49 AM, Petr Jelinek wrote: >> Hi, >> >> attached is version 13 of the patch. >> >> I merged in changes from PeterE. And did following changes: >> - fixed the ownership error messages for both provider and subscriber >> - added ability to

Re: [HACKERS] Logical Replication WIP

2016-12-18 Thread Petr Jelinek
On 17/12/16 13:37, Erik Rijkers wrote: > On 2016-12-16 13:49, Petr Jelinek wrote: >> >> version 13 of the patch. >> >> 0001-Add-PUBLICATION-catalogs-and-DDL-v13.patch.gz (~32 KB) >> 0002-Add-SUBSCRIPTION-catalog-and-DDL-v13.patch.gz (~28 KB) >> 0003-Define-logical-rep...utput-plugi-v13.patch.gz