Re: [HACKERS] pgbench more operators & functions

2017-05-29 Thread Pavel Stehule
2017-05-30 7:19 GMT+02:00 Fabien COELHO : > > [doc about CASE...] >>> >> >> I've improved it in attached v11: >> - add a link to the CASE full documentation >> - add an example expression with CASE ... >> > > Do you think I should improve the doc further? I am sorry, I

Re: [HACKERS] Adding support for Default partition in partitioning

2017-05-29 Thread Beena Emerson
On Mon, May 29, 2017 at 9:33 PM, Jeevan Ladhe wrote: > Hi, > > I have rebased the patch on latest commit with few cosmetic changes. > > The patch fix_listdatums_get_qual_for_list_v3.patch [1] needs to be applied > before applying this patch. > > [1]

Re: [HACKERS] pgbench more operators & functions

2017-05-29 Thread Fabien COELHO
[doc about CASE...] I've improved it in attached v11: - add a link to the CASE full documentation - add an example expression with CASE ... Do you think I should improve the doc further? -- Fabien. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] POC: Sharing record typmods between backends

2017-05-29 Thread Thomas Munro
On Fri, Apr 7, 2017 at 5:21 PM, Thomas Munro wrote: > * It would be nice for the SharedRecordTypeRegistry to be able to > survive longer than a single parallel query, perhaps in a per-session > DSM segment. Perhaps eventually we will want to consider a >

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-05-29 Thread Mithun Cy
Thanks Robert, On Wed, May 24, 2017 at 5:41 PM, Robert Haas wrote: > + * > + * Once the "autoprewarm" bgworker has completed its prewarm task, it will > + * start a new task to periodically dump the BlockInfoRecords related to > blocks > + * which are currently in shared

Re: [HACKERS] "create publication..all tables" ignore 'partition not supported' error

2017-05-29 Thread Amit Langote
On 2017/05/22 20:02, Kuntal Ghosh wrote: > Yeah, it's a bug. While showing the table definition, we use the > following query for showing the related publications: > "SELECT pub.pubname\n" > " FROM pg_catalog.pg_publication pub\n" > "

Re: [HACKERS] [COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

2017-05-29 Thread Amit Langote
On 2017/05/30 11:41, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> Noah Misch writes: >>> On Mon, May 29, 2017 at 03:20:41AM +, Tom Lane wrote: Annotate the fact that somebody added location fields to PartitionBoundSpec and PartitionRangeDatum

Re: [HACKERS] pg_resetwal is broken if run from v10 against older version of PG data directory

2017-05-29 Thread Craig Ringer
On 30 May 2017 at 00:00, Tom Lane wrote: > I think it's just horribly dangerous to run any version of > pg_resetxlog/pg_resetwal You can pretty much stop there ;) -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] pg_resetwal is broken if run from v10 against older version of PG data directory

2017-05-29 Thread Amit Kapila
On Mon, May 29, 2017 at 9:30 PM, Tom Lane wrote: > Amit Kapila writes: >> I think this happens due to commit >> f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e which renames pg_xlog to >> pg_wal. It does take care of making some of the modules like >>

Re: [HACKERS] Server ignores contents of SASLInitialResponse

2017-05-29 Thread Noah Misch
On Thu, May 25, 2017 at 10:52:23AM -0400, Michael Paquier wrote: > On Thu, May 25, 2017 at 9:32 AM, Michael Paquier > wrote: > > On Thu, May 25, 2017 at 8:51 AM, Heikki Linnakangas wrote: > >> On 05/24/2017 11:33 PM, Michael Paquier wrote: > >>> I have

Re: [HACKERS] Replication status in logical replication

2017-05-29 Thread Noah Misch
On Fri, May 19, 2017 at 11:33:48AM +0900, Masahiko Sawada wrote: > On Wed, Apr 12, 2017 at 5:31 AM, Simon Riggs wrote: > > On 22 March 2017 at 02:50, Masahiko Sawada wrote: > > > >> When using logical replication, I ran into a situation where the >

Re: [HACKERS] [COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

2017-05-29 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Noah Misch writes: > > On Mon, May 29, 2017 at 03:20:41AM +, Tom Lane wrote: > >> Annotate the fact that somebody added location fields to PartitionBoundSpec > >> and PartitionRangeDatum but forgot to handle them in > >>

Re: [HACKERS] [COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

2017-05-29 Thread Tom Lane
Noah Misch writes: > On Mon, May 29, 2017 at 03:20:41AM +, Tom Lane wrote: >> Annotate the fact that somebody added location fields to PartitionBoundSpec >> and PartitionRangeDatum but forgot to handle them in >> outfuncs.c/readfuncs.c. This is fairly harmless for

Re: [HACKERS] PATCH: recursive json_populate_record()

2017-05-29 Thread Tom Lane
Noah Misch writes: > On Mon, May 22, 2017 at 10:19:37PM +0300, Nikita Glukhov wrote: >> Attached two small fixes for the previous committed patch: > [Action required within three days. This is a generic notification.] > The above-described topic is currently a PostgreSQL 10

[HACKERS] Re: Create subscription with `create_slot=false` and incorrect slot name

2017-05-29 Thread Noah Misch
On Fri, May 26, 2017 at 05:05:37PM -0400, Peter Eisentraut wrote: > On 5/25/17 19:16, Petr Jelinek wrote: > >> The reported error is just one of many errors that can happen when DROP > >> SUBSCRIPTION tries to drop the slot (doens't exist, still active, no > >> permission, etc.). We don't want to

Re: [HACKERS] PATCH: recursive json_populate_record()

2017-05-29 Thread Noah Misch
On Mon, May 22, 2017 at 10:19:37PM +0300, Nikita Glukhov wrote: > Attached two small fixes for the previous committed patch: > > 1. I've noticed a difference in behavior between json_populate_record() > and jsonb_populate_record() if we are trying to populate record from a > non-JSON-object:

Re: [HACKERS] ALTER PUBLICATION documentation

2017-05-29 Thread Noah Misch
On Wed, May 24, 2017 at 07:24:08PM -0400, Peter Eisentraut wrote: > On 5/22/17 17:50, Jeff Janes wrote: > > "The first variant of this command listed in the synopsis can change all > > of the publication properties specified in CREATE PUBLICATION > >

[HACKERS] Re: pg_dump ignoring information_schema tables which used in Create Publication.

2017-05-29 Thread Noah Misch
On Fri, May 26, 2017 at 10:46:12PM -0300, Euler Taveira wrote: > 2017-05-26 17:52 GMT-03:00 Peter Eisentraut > : > > You cannot publish a system catalog. But a user-created table in > > information_schema is not a system catalog. > > Replication of

Re: [HACKERS] Why does logical replication launcher set application_name?

2017-05-29 Thread Noah Misch
On Tue, May 23, 2017 at 07:50:34PM +0200, Petr Jelinek wrote: > On 20/04/17 21:33, Peter Eisentraut wrote: > > On 4/18/17 13:18, Tom Lane wrote: > >> I think you're thinking about it wrong. To my mind the issue is that > >> there should be some generic way to determine that a bgworker process >

Re: [HACKERS] walsender & parallelism

2017-05-29 Thread Noah Misch
On Tue, May 23, 2017 at 01:45:59PM -0400, Andres Freund wrote: > On May 23, 2017 1:42:41 PM EDT, Petr Jelinek > wrote: > >Hi, > > > >so this didn't really move anywhere AFAICS, do we think the approach > >I've chosen is good or do we want to do something else here?

Re: [HACKERS] Race conditions with WAL sender PID lookups

2017-05-29 Thread Noah Misch
On Sat, May 20, 2017 at 09:40:57PM +0900, Michael Paquier wrote: > On Fri, May 19, 2017 at 3:01 PM, Masahiko Sawada > wrote: > > Also, as Horiguchi-san pointed out earlier, walreceiver seems need the > > similar fix. > > Actually, now that I look at it, ready_to_display

[HACKERS] Re: transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)

2017-05-29 Thread Noah Misch
This PostgreSQL 10 open item is past due for your status update. Kindly send a status update within 24 hours, and include a date for your subsequent status update. Refer to the policy on open item ownership: https://www.postgresql.org/message-id/20170404140717.GA2675809%40tornado.leadboat.com

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

2017-05-29 Thread Noah Misch
On Thu, May 18, 2017 at 10:27:51PM -0400, Peter Eisentraut wrote: > On 5/18/17 11:11, Noah Misch wrote: > > IMMEDIATE ATTENTION REQUIRED. This PostgreSQL 10 open item is past due for > > your status update. Please reacquaint yourself with the policy on open item > > ownership[1] and then reply

Re: [HACKERS] Alter subscription..SET - NOTICE message is coming for table which is already removed

2017-05-29 Thread Masahiko Sawada
On Thu, May 25, 2017 at 8:15 PM, tushar wrote: > On 05/25/2017 04:40 PM, Masahiko Sawada wrote: >> >> I think you did ALTER SUBSCRIPTION while table sync for 100 tables is >> running, right? > > Yes, i didn't wait too much while executing the commands. > I think

[HACKERS] Fix GetOldestXmin comment

2017-05-29 Thread Masahiko Sawada
Hi, While reading source code, I realized that comment of GetOldestXmin mentions; * if rel = NULL and there are no transactions running in the current * database, GetOldestXmin() returns latestCompletedXid. However, in that case if I understand correctly GetOldestXmin() actually returns

Re: [HACKERS] Receive buffer size for the statistics socket

2017-05-29 Thread Tom Lane
I wrote: >> I propose that it'd be a good idea to try to set the stats socket's >> receive buffer size to be a minimum of, say, 100K on all platforms. >> Code for this would be analogous to what we already have in pqcomm.c >> (circa line 760) for forcing up the send buffer size, but SO_RCVBUF >>

Re: [HACKERS] PATCH: recursive json_populate_record()

2017-05-29 Thread Tom Lane
Nikita Glukhov writes: > Attached two small fixes for the previous committed patch: > 1. I've noticed a difference in behavior between json_populate_record() > and jsonb_populate_record() if we are trying to populate record from a > non-JSON-object: json function throws

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

2017-05-29 Thread Mark Rofail
> > rhaas=# select oid, * from pg_opfamily where opfmethod = 2742; > oid | opfmethod |opfname | opfnamespace | opfowner > --+---++--+-- > 2745 | 2742 | array_ops | 11 | 10 > 3659 | 2742 | tsvector_ops |

Re: [HACKERS] logical replication busy-waiting on a lock

2017-05-29 Thread Petr Jelinek
On 29/05/17 21:44, Andres Freund wrote: > > > On May 29, 2017 12:41:26 PM PDT, Petr Jelinek > wrote: >> On 29/05/17 21:28, Andres Freund wrote: >>> >>> On May 29, 2017 12:25:35 PM PDT, Petr Jelinek >> wrote: Looking at the

Re: [HACKERS] pg_resetwal is broken if run from v10 against older version of PG data directory

2017-05-29 Thread Tom Lane
Michael Paquier writes: > Agreed. Shouldn't this be back-patched? PG_CONTROL_VERSION has not > been bumped between 9.4 and 9.5. Attached is a patch for HEAD. Pushed with minor adjustments. Notably, I didn't take your addition of canonicalize_path() and referencing the

Re: [HACKERS] logical replication - still unstable after all these months

2017-05-29 Thread Mark Kirkwood
On 29/05/17 23:14, Petr Jelinek wrote: On 29/05/17 03:33, Jeff Janes wrote: What would you want to look at? Would saving the WAL from the master be helpful? Useful info is, logs from provider (mainly the logical decoding logs that mention LSNs), logs from subscriber (the lines about when

Re: [HACKERS] Bug when dumping "empty" operator classes

2017-05-29 Thread Michael Paquier
On Fri, May 26, 2017 at 8:14 AM, Daniel Gustafsson wrote: >> On 26 May 2017, at 17:08, Tom Lane wrote: >> I'll commit and back-patch this without a test case. Possibly Frost will >> be excited enough about it to add something to the pg_dump TAP tests, >> but

Re: [HACKERS] Use of non-restart-safe storage by temp_tablespaces

2017-05-29 Thread Tom Lane
Andres Freund writes: > On May 29, 2017 12:15:37 PM PDT, Alvaro Herrera > wrote: >> I think it'd be smart to support the use case directly, because there's >> interest in it being actually supported (unlike the statu quo). >> Something like

Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x

2017-05-29 Thread Tom Lane
Christoph Berg writes: > Re: To Andres Freund 2016-04-28 <20160428080824.ga22...@msg.df7cb.de> >>> I'm not clear why citus triggers this, when other extensions don't? >> Maybe it's simply because citus.so is bigger than all the other >> extension .so files: I wonder what the

Re: [HACKERS] logical replication busy-waiting on a lock

2017-05-29 Thread Andres Freund
On May 29, 2017 12:41:26 PM PDT, Petr Jelinek wrote: >On 29/05/17 21:28, Andres Freund wrote: >> >> On May 29, 2017 12:25:35 PM PDT, Petr Jelinek > wrote: >>> >>> Looking at the code more, the xid is only used as parameter for >>>

Re: [HACKERS] logical replication busy-waiting on a lock

2017-05-29 Thread Petr Jelinek
On 29/05/17 21:28, Andres Freund wrote: > > On May 29, 2017 12:25:35 PM PDT, Petr Jelinek > wrote: >> >> Looking at the code more, the xid is only used as parameter for >> SnapBuildBuildSnapshot() which never does anything with that parameter, >> I wonder if it's

Re: [HACKERS] psql: Activate pager only for height, not width

2017-05-29 Thread Christoph Berg
Re: Jeff Janes 2017-05-29

Re: [HACKERS] logical replication busy-waiting on a lock

2017-05-29 Thread Petr Jelinek
On 29/05/17 21:23, Andres Freund wrote: > > > On May 29, 2017 12:21:50 PM PDT, Petr Jelinek > wrote: >> On 29/05/17 20:59, Andres Freund wrote: >>> >>> >>> On May 29, 2017 11:58:05 AM PDT, Petr Jelinek >> wrote: On 27/05/17

Re: [HACKERS] logical replication busy-waiting on a lock

2017-05-29 Thread Andres Freund
On May 29, 2017 12:25:35 PM PDT, Petr Jelinek wrote: >On 29/05/17 21:21, Petr Jelinek wrote: >> On 29/05/17 20:59, Andres Freund wrote: >>> >>> >>> On May 29, 2017 11:58:05 AM PDT, Petr Jelinek > wrote: On 27/05/17 17:17, Andres

Re: [HACKERS] Surjective functional indexes

2017-05-29 Thread Sven R. Kunze
On 29.05.2017 21:25, Sven R. Kunze wrote: [...] non-surjective functions. non-injective of course -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] logical replication busy-waiting on a lock

2017-05-29 Thread Petr Jelinek
On 29/05/17 21:21, Petr Jelinek wrote: > On 29/05/17 20:59, Andres Freund wrote: >> >> >> On May 29, 2017 11:58:05 AM PDT, Petr Jelinek >> wrote: >>> On 27/05/17 17:17, Andres Freund wrote: On May 27, 2017 9:48:22 AM EDT, Petr Jelinek >>>

Re: [HACKERS] Use of non-restart-safe storage by temp_tablespaces

2017-05-29 Thread Andres Freund
On May 29, 2017 12:15:37 PM PDT, Alvaro Herrera wrote: >Claudio Freire wrote: >> On Mon, May 29, 2017 at 3:53 PM, Bruce Momjian >wrote: >> > Right now we don't document that temp_tablespaces can use >> > non-restart-safe storage, e.g. /tmp,

Re: [HACKERS] Surjective functional indexes

2017-05-29 Thread Sven R. Kunze
On 29.05.2017 19:21, Christoph Berg wrote: I think the term you were looking for is "projection". https://en.wikipedia.org/wiki/Projection_(set_theory) Maybe, I am seeing too much of a connection here but recently Raymond Hettinger held a very interesting talk [1] at PyCon 2017. For those

Re: [HACKERS] logical replication busy-waiting on a lock

2017-05-29 Thread Andres Freund
On May 29, 2017 12:21:50 PM PDT, Petr Jelinek wrote: >On 29/05/17 20:59, Andres Freund wrote: >> >> >> On May 29, 2017 11:58:05 AM PDT, Petr Jelinek > wrote: >>> On 27/05/17 17:17, Andres Freund wrote: On May 27, 2017

Re: [HACKERS] logical replication busy-waiting on a lock

2017-05-29 Thread Petr Jelinek
On 29/05/17 20:59, Andres Freund wrote: > > > On May 29, 2017 11:58:05 AM PDT, Petr Jelinek > wrote: >> On 27/05/17 17:17, Andres Freund wrote: >>> >>> >>> On May 27, 2017 9:48:22 AM EDT, Petr Jelinek >> wrote: Actually, I guess

Re: [HACKERS] Use of non-restart-safe storage by temp_tablespaces

2017-05-29 Thread Alvaro Herrera
Claudio Freire wrote: > On Mon, May 29, 2017 at 3:53 PM, Bruce Momjian wrote: > > Right now we don't document that temp_tablespaces can use > > non-restart-safe storage, e.g. /tmp, ramdisks. Would this be safe? > > Should we document this? > > I have set up things like that,

Re: [HACKERS] psql: Activate pager only for height, not width

2017-05-29 Thread Jeff Janes
On Sun, May 28, 2017 at 10:09 PM, Brendan Jurd wrote: > Hello hackers, > > I am often frustrated by the default behaviour of the psql pager, which > will activate a pager if the output is deemed to be "too wide" for the > terminal, regardless of the number of lines output, and

Re: [HACKERS] Use of non-restart-safe storage by temp_tablespaces

2017-05-29 Thread Claudio Freire
On Mon, May 29, 2017 at 3:53 PM, Bruce Momjian wrote: > Right now we don't document that temp_tablespaces can use > non-restart-safe storage, e.g. /tmp, ramdisks. Would this be safe? > Should we document this? I have set up things like that, but it's nontrivial. Just pointing

Re: [HACKERS] logical replication busy-waiting on a lock

2017-05-29 Thread Andres Freund
On May 29, 2017 11:58:05 AM PDT, Petr Jelinek wrote: >On 27/05/17 17:17, Andres Freund wrote: >> >> >> On May 27, 2017 9:48:22 AM EDT, Petr Jelinek > wrote: >>> Actually, I guess it's the pid 47457 (COPY process) who is actually >>>

Re: [HACKERS] logical replication busy-waiting on a lock

2017-05-29 Thread Petr Jelinek
On 27/05/17 17:17, Andres Freund wrote: > > > On May 27, 2017 9:48:22 AM EDT, Petr Jelinek > wrote: >> Actually, I guess it's the pid 47457 (COPY process) who is actually >> running the xid 73322726. In that case that's the same thing Masahiko >> Sawada reported

[HACKERS] Use of non-restart-safe storage by temp_tablespaces

2017-05-29 Thread Bruce Momjian
Right now we don't document that temp_tablespaces can use non-restart-safe storage, e.g. /tmp, ramdisks. Would this be safe? Should we document this? -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you

Re: [HACKERS] fix side-effect in get_qual_for_list()

2017-05-29 Thread Jeevan Ladhe
On Mon, May 29, 2017 at 11:55 PM, Tom Lane wrote: > Jeevan Ladhe writes: > > I have rebased the patch on recent commit. > > Pushed with some further tweaking. > Thanks Tom for taking care of this. Regards, Jeevan Ladhe

Re: [HACKERS] logical replication busy-waiting on a lock

2017-05-29 Thread Andres Freund
On 2017-05-29 11:38:20 -0700, Jeff Janes wrote: > Related, but not the same. It would be nice if they didn't block, but if > they do have to block, shouldn't it wait on a semaphore, rather than doing > a tight loop? It looks like maybe a latch didn't get reset when it should > have or something.

Re: [HACKERS] logical replication busy-waiting on a lock

2017-05-29 Thread Jeff Janes
On Sat, May 27, 2017 at 6:48 AM, Petr Jelinek wrote: > > > Actually, I guess it's the pid 47457 (COPY process) who is actually > running the xid 73322726. In that case that's the same thing Masahiko > Sawada reported [1]. Related, but not the same. It would be

Re: [HACKERS] fix side-effect in get_qual_for_list()

2017-05-29 Thread Tom Lane
Jeevan Ladhe writes: > I have rebased the patch on recent commit. Pushed with some further tweaking. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Surjective functional indexes

2017-05-29 Thread Christoph Berg
Re: Konstantin Knizhnik 2017-05-29 <592bbd90.3060...@postgrespro.ru> > On 05/27/2017 09:50 PM, Peter Eisentraut wrote: > > On 5/25/17 12:30, Konstantin Knizhnik wrote: > > > Functions like (info->>'name') are named "surjective" ni mathematics. > > A surjective function is one where each value in

Re: [HACKERS] pg_resetwal is broken if run from v10 against older version of PG data directory

2017-05-29 Thread Michael Paquier
On Mon, May 29, 2017 at 10:02 AM, Tom Lane wrote: > Michael Paquier writes: >> On Mon, May 29, 2017 at 9:00 AM, Tom Lane wrote: >>> So we need to prevent this, not try to make it work. I don't think >>> we can insist on a

Re: [HACKERS] pg_resetwal is broken if run from v10 against older version of PG data directory

2017-05-29 Thread Tom Lane
Michael Paquier writes: > On Mon, May 29, 2017 at 9:00 AM, Tom Lane wrote: >> So we need to prevent this, not try to make it work. I don't think >> we can insist on a version match in pg_control, because part of the >> point of

Re: [HACKERS] pg_resetwal is broken if run from v10 against older version of PG data directory

2017-05-29 Thread Michael Paquier
On Mon, May 29, 2017 at 9:00 AM, Tom Lane wrote: > So we need to prevent this, not try to make it work. I don't think > we can insist on a version match in pg_control, because part of the > point of pg_resetxlog/pg_resetwal is to recover if pg_control is > unreadable. But I

Re: [HACKERS] Adding support for Default partition in partitioning

2017-05-29 Thread Jeevan Ladhe
Hi, I have rebased the patch on latest commit with few cosmetic changes. The patch fix_listdatums_get_qual_for_list_v3.patch [1] needs to be applied before applying this patch. [1]

Re: [HACKERS] pg_resetwal is broken if run from v10 against older version of PG data directory

2017-05-29 Thread Tom Lane
Amit Kapila writes: > I think this happens due to commit > f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e which renames pg_xlog to > pg_wal. It does take care of making some of the modules like > pg_basebackup to understand both old and new directory structures, but > not done

Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x

2017-05-29 Thread Christoph Berg
Re: To Andres Freund 2016-04-28 <20160428080824.ga22...@msg.df7cb.de> > > I'm not clear why citus triggers this, when other extensions don't? > > Maybe it's simply because citus.so is bigger than all the other > extension .so files: > >-fpic > Generate position-independent code

Re: [HACKERS] pg_resetwal is broken if run from v10 against older version of PG data directory

2017-05-29 Thread Michael Paquier
On Mon, May 29, 2017 at 3:19 AM, Amit Kapila wrote: > I think this happens due to commit > f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e which renames pg_xlog to > pg_wal. It does take care of making some of the modules like > pg_basebackup to understand both old and new

Re: [HACKERS] pg_resetwal is broken if run from v10 against older version of PG data directory

2017-05-29 Thread Tom Lane
tushar writes: > I have installed PG v9.6 / v9.5 , if we run pg_resetwal from v10 > binaries against data directory of v9.6/9.5 ,getting this error - > centos@centos-cpula bin]$ ./pg_resetwal -D /tmp/pg9.6/bin/data/ > pg_resetwal: pg_control exists but is broken

Re: [HACKERS] Extra Vietnamese unaccent rules

2017-05-29 Thread Dang Minh Huong
> On May 29, 29 Heisei, at 10:47, Thomas Munro > wrote: > > On Sun, May 28, 2017 at 7:55 PM, Dang Minh Huong wrote: >> Thanks for reporting and lecture about unicode. >> I attached a patch as the instruction from Thomas. Could you confirm

Re: [HACKERS] Fix a typo in execExpr.c

2017-05-29 Thread Magnus Hagander
On Mon, May 29, 2017 at 4:04 PM, Masahiko Sawada wrote: > Hi, > > Attached for $subject. > > s/Expession/Expression/ > Thanks, applied! -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

[HACKERS] Fix a typo in execExpr.c

2017-05-29 Thread Masahiko Sawada
Hi, Attached for $subject. s/Expession/Expression/ Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_typo_in_execExpr_c.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Inconsistent syntax for NumericOnly grammar production

2017-05-29 Thread Vik Fearing
On 05/28/2017 11:16 PM, Tom Lane wrote: > The inconsistency here means that you can do, for example, > > regression=# set random_page_cost = +4; > SET > regression=# set random_page_cost = 4.2; > SET > > but not > > regression=# set random_page_cost = +4.2; > ERROR: syntax error at or near

[HACKERS] question about replication docs

2017-05-29 Thread Dave Cramer
The following makes an explicit reference to the simple query protocol being the only protocol allowed in walsender mode. It is my understanding this is true for logical replication as well ?? 51.3. Streaming Replication Protocol To initiate streaming replication, the frontend sends the

Re: [HACKERS] logical replication - still unstable after all these months

2017-05-29 Thread Petr Jelinek
On 29/05/17 03:33, Jeff Janes wrote: > On Sun, May 28, 2017 at 3:17 PM, Mark Kirkwood > > > wrote: > > The framework ran 600 tests last night, and I see 3 'NOK' results, > i.e 3 failed test runs (all scale 25 and 8

Re: [HACKERS] fix side-effect in get_qual_for_list()

2017-05-29 Thread Jeevan Ladhe
Hi, I have rebased the patch on recent commit. With recent commits, some of the hunks in the v2 patch related to castNode, are not needed. PFA. Regards, Jeevan Ladhe On Sat, May 27, 2017 at 1:16 AM, Jeevan Ladhe wrote: > Hi Ashutosh, > > Thanks for catching

Re: [HACKERS] pg_resetwal is broken if run from v10 against older version of PG data directory

2017-05-29 Thread Amit Kapila
On Mon, May 29, 2017 at 3:20 PM, tushar wrote: > On 05/29/2017 03:10 PM, Amit Kapila wrote: >> >> What makes you think above is a valid usage and should >> pass? > > with earlier versions ,for instance - v.96 v/s v9.5 ,pg_resetwal was giving > pg_control values .

Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, so culicidae is *still* broken)

2017-05-29 Thread Amit Kapila
On Fri, May 26, 2017 at 8:21 PM, Magnus Hagander wrote: > > On Fri, May 26, 2017 at 8:24 AM, Michael Paquier > wrote: >> >> On Fri, May 26, 2017 at 8:20 AM, Amit Kapila >> wrote: >> > I think the real question here is,

Re: [HACKERS] Allow GiST opcalsses without compress\decompres functions

2017-05-29 Thread Andrew Borodin
2017-05-29 0:00 GMT+05:00 Tom Lane : > But the opclass's consistent function might expect to be always given an > untoasted input, in which case you'd need the decompress function to fix > that up. In cube data is detoasted at least 4 times before going to

Re: [HACKERS] Default Partition for Range

2017-05-29 Thread Jeevan Ladhe
Hi Beena, I went through your patch, and here are some of my comments: - For generating a qual for default range partition, instead of scanning for all the children and collecting all the boundspecs, how about creating and negating an expression from the lists of lowerdatums and upperdatums in

Re: [HACKERS] pg_resetwal is broken if run from v10 against older version of PG data directory

2017-05-29 Thread tushar
On 05/29/2017 03:10 PM, Amit Kapila wrote: What makes you think above is a valid usage and should pass? with earlier versions ,for instance - v.96 v/s v9.5 ,pg_resetwal was giving pg_control values . Installed v9.6 and v9.5 and run pg_resetwal of v9.6 against data directory of v9.5.

Re: [HACKERS] "cannot specify finite value after UNBOUNDED" ... uh, why?

2017-05-29 Thread Amit Langote
On 2017/05/29 16:04, Tom Lane wrote: > Would someone please defend the restrictions imposed by the > "seen_unbounded" checks in transformPartitionBound > (parse_utilcmd.c:3365..3396 in current HEAD)? They sure look to me like > nothing but sloppy thinking, and/or protection of downstream sloppy >

Re: [HACKERS] pg_resetwal is broken if run from v10 against older version of PG data directory

2017-05-29 Thread Amit Kapila
On Mon, May 29, 2017 at 1:48 PM, tushar wrote: > Hi, > > I have installed PG v9.6 / v9.5 , if we run pg_resetwal from v10 binaries > against data directory of v9.6/9.5 ,getting this error - > > centos@centos-cpula bin]$ ./pg_resetwal -D /tmp/pg9.6/bin/data/ >

Re: [HACKERS] UPDATE of partition key

2017-05-29 Thread Amit Kapila
On Mon, May 29, 2017 at 11:20 AM, Amit Khandekar wrote: > On 24 May 2017 at 20:16, Amit Kapila wrote: >> On Wed, May 24, 2017 at 8:14 PM, Amit Kapila wrote: >>> Apart from above, there is one open issue [1] >>> >> >>

Re: [HACKERS] Adding support for Default partition in partitioning

2017-05-29 Thread Jeevan Ladhe
> > The existing comment is not valid > /* > * A null partition key is only acceptable if null-accepting > list > * partition exists. > */ > as we allow NULL to be stored in default. It should be updated. > Sure Beena, as stated earlier will

Re: [HACKERS] Adding support for Default partition in partitioning

2017-05-29 Thread Jeevan Ladhe
This patch needs a rebase on recent commits, and also a fix[1] that is posted for get_qual_for_list(). I am working on both of these tasks. Will update the patch once I am done with this. Regards, Jeevan Ladhe On Mon, May 29, 2017 at 12:25 PM, Beena Emerson wrote: >

[HACKERS] pg_resetwal is broken if run from v10 against older version of PG data directory

2017-05-29 Thread tushar
Hi, I have installed PG v9.6 / v9.5 , if we run pg_resetwal from v10 binaries against data directory of v9.6/9.5 ,getting this error - centos@centos-cpula bin]$ ./pg_resetwal -D /tmp/pg9.6/bin/data/ pg_resetwal: pg_control exists but is broken or unknown version; ignoring it pg_resetwal:

[HACKERS] Macros bundling RELKIND_* conditions

2017-05-29 Thread Ashutosh Bapat
Hi, We saw a handful bugs reported because RELKIND_PARTITIONED_TABLE was not added to appropriate conditions on relkind. One such report is [1]. On that thread I suggested that we encapsulate these conditions as macros. Here's excerpt of my mail. -- I noticed, that after we introduced

[HACKERS] "cannot specify finite value after UNBOUNDED" ... uh, why?

2017-05-29 Thread Tom Lane
Would someone please defend the restrictions imposed by the "seen_unbounded" checks in transformPartitionBound (parse_utilcmd.c:3365..3396 in current HEAD)? They sure look to me like nothing but sloppy thinking, and/or protection of downstream sloppy thinking. Why should the boundedness of one

Re: [HACKERS] Adding support for Default partition in partitioning

2017-05-29 Thread Beena Emerson
On Thu, May 25, 2017 at 3:03 PM, Jeevan Ladhe wrote: > > Forgot to attach the patch. > PFA. > > On Thu, May 25, 2017 at 3:02 PM, Jeevan Ladhe > wrote: >> >> Hi Rajkumar, >> >>> postgres=# CREATE TEMP TABLE temp_list_part (a int)

Re: [HACKERS] Surjective functional indexes

2017-05-29 Thread Konstantin Knizhnik
On 05/27/2017 09:50 PM, Peter Eisentraut wrote: On 5/25/17 12:30, Konstantin Knizhnik wrote: Functions like (info->>'name') are named "surjective" ni mathematics. A surjective function is one where each value in the output type can be obtained by some input value. That's not what you are