Re: [HACKERS] Hash tables in dynamic shared memory

2016-11-19 Thread John Gorman
will be faster due to not having to examine more than one hash bucket array most of the time. -- John Gorman http://www.enterprisedb.com dht-v2-resize-cleanup.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] PATCH: two slab-like memory allocators

2016-10-05 Thread John Gorman
On Tue, Oct 4, 2016 at 10:11 PM, Tomas Vondra For GenSlab the situation is less clear, as there probably are ways to make > it work, but I'd vote to keep it simple for now, and simply do elog(ERROR) > in the realloc() methods - both for Slab and GenSlab. The current use case > (reorderbuffer)

Re: [HACKERS] PATCH: two slab-like memory allocators

2016-10-04 Thread John Gorman
set->aset, size); On Sat, Oct 1, 2016 at 10:15 PM, Tomas Vondra <tomas.von...@2ndquadrant.com> wrote: > On 10/02/2016 12:23 AM, John Gorman wrote: > >> I reproduced the quadradic pfree performance problem and verified that >> these patches solved it. >> >>

Re: [HACKERS] PATCH: two slab-like memory allocators

2016-10-01 Thread John Gorman
s this is what is meant. < * (plus alignment), now wasting memory. > * (plus alignment), not wasting memory. In slab.c some lines are over 80 characters could be folded. It would be nice to give each patch version a unique file name. Nice patch, I enjoyed reading it! Best, John John Gorma

[HACKERS] Status of 64 bit atomics

2016-05-27 Thread John Gorman
Hi All Someone recently told me that the postgresql atomics library was incomplete for 64 bit operations such as pg_atomic_fetch_add_u64() and should not be used. Can someone definitively confirm whether it is okay to rely on the 64 bit atomics or whether it is better to protect 64 bit

Re: [HACKERS] Re: [COMMITTERS] pgsql: Respect TEMP_CONFIG when running contrib regression tests.

2016-02-27 Thread John Gorman
On Sat, Feb 27, 2016 at 9:25 AM, Robert Haas wrote: > On Sat, Feb 27, 2016 at 7:08 PM, Andrew Dunstan > wrote: > > > Perhaps what we need to do is modify pg_regress.c slightly to allow more > > than one --temp-config argument. But that could be done

[HACKERS] errmsg() clobbers errno

2015-05-19 Thread John Gorman
Hi All While debugging an extension I discovered that the errmsg() function zeros out errno. This is annoying because if the process of assembling a meaningful error message happens to call errmsg() before calling strerror() we lose the strerror information. This is exactly the time when we want

[HACKERS] Incompatible trig error handling

2015-04-29 Thread John Gorman
Two of the trigonometry functions have differing error condition behavior between Linux and OSX. The Linux behavior follows the standard set by the other trig functions. On Linux: SELECT asin(2); ERROR: input is out of range SELECT acos(2); ERROR: input is out of range On OSX: SELECT

[HACKERS] Compile warnings on OSX 10.10 clang 6.0

2015-04-03 Thread John Gorman
Hi All I am getting compile warnings on OSX 10.10 from clang 6.0: clang: warning: argument unused during compilation: '-pthread' The 5 warnings are where we are making a -dynamiclib and the -pthread argument is not necessary: ./src/interfaces/libpq/ ./src/interfaces/ecpg/pgtypeslib/

Re: [HACKERS] Compile warnings on OSX 10.10 clang 6.0

2015-04-03 Thread John Gorman
I have confirmed that -Wno-unused-command-line-argument suppresses the -pthread warning for clang 6.0 and does not trigger a warning in gcc 4.9. Works for me! John On Fri, Apr 3, 2015 at 5:21 PM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: Peter Eisentraut pete...@gmx.net writes: These

Re: [HACKERS] Parallel Seq Scan

2015-01-13 Thread John Gorman
On Sun, Jan 11, 2015 at 6:00 PM, Robert Haas robertmh...@gmail.com wrote: On Sun, Jan 11, 2015 at 6:01 AM, Stephen Frost sfr...@snowman.net wrote: So, for my 2c, I've long expected us to parallelize at the relation-file level for these kinds of operations. This goes back to my other

Re: [HACKERS] Parallel Seq Scan

2015-01-13 Thread John Gorman
On Tue, Jan 13, 2015 at 7:25 AM, John Gorman johngorm...@gmail.com wrote: On Sun, Jan 11, 2015 at 6:00 PM, Robert Haas robertmh...@gmail.com wrote: On Sun, Jan 11, 2015 at 6:01 AM, Stephen Frost sfr...@snowman.net wrote: So, for my 2c, I've long expected us to parallelize at the relation

[HACKERS] Fractions in GUC variables

2014-12-07 Thread John Gorman
This patch implements the first wiki/Todo Configuration Files item Consider normalizing fractions in postgresql.conf, perhaps using '%'. The Fractions in GUC variables discussion is here. http://www.postgresql.org/message-id/467132cf.9020...@enterprisedb.com This patch implements expressing GUC