Re: [HACKERS] Fix some corner cases that cube_in rejects

2016-09-27 Thread Tom Lane
Amul Sul writes: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:not tested > Note for

Re: [HACKERS] Fix some corner cases that cube_in rejects

2016-09-27 Thread Amul Sul
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Note for committer : There are unnecessary files (cube_1.out,

Re: [HACKERS] Fix some corner cases that cube_in rejects

2016-08-29 Thread Tom Lane
Greg Stark writes: > On Mon, Aug 29, 2016 at 7:19 PM, Tom Lane wrote: >> To deal with the infinity/NaN issues, I made cube_in and cube_out rely >> on float8in_internal and float8out_internal, as we recently did for the >> core geometric types. That causes the

Re: [HACKERS] Fix some corner cases that cube_in rejects

2016-08-29 Thread Greg Stark
On Mon, Aug 29, 2016 at 7:19 PM, Tom Lane wrote: > To deal with the infinity/NaN issues, I made cube_in and cube_out rely > on float8in_internal and float8out_internal, as we recently did for the > core geometric types. That causes the response to "1e-700" to be an >

[HACKERS] Fix some corner cases that cube_in rejects

2016-08-29 Thread Tom Lane
In bug #14300 it's pointed out that cube_in rejects zero-element cubes, as well as infinity and NaN coordinate values. Since it's easy to make such cube values via the cube-from-float-array constructors, this is a dump/reload hazard. The attached proposed patch attempts to fix it up. To deal