Re: [HACKERS] Missing comment for max_logical_replication_workers in postgresql.conf.sample

2017-07-30 Thread Tatsuo Ishii
> Attached patch looks good except the excessive tab stops: > + > # (change requires restart) > > I will commit/push this with removing the excessive tab stops if > there's no objection. Done. Each fix were pushed in

Re: [HACKERS] Missing comment for max_logical_replication_workers in postgresql.conf.sample

2017-07-28 Thread Tatsuo Ishii
Attached patch looks good except the excessive tab stops: + # (change requires restart) I will commit/push this with removing the excessive tab stops if there's no objection. Best regards, -- Tatsuo Ishii SRA OSS,

Re: [HACKERS] Missing comment for max_logical_replication_workers in postgresql.conf.sample

2017-07-27 Thread Yugo Nagata
On Thu, 27 Jul 2017 14:38:29 +0900 Masahiko Sawada wrote: > On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata wrote: > > Hi, > > > > I found that postgresql.conf.sample is missing a comment > > to note that changing max_logical_replication_workers

Re: [HACKERS] Missing comment for max_logical_replication_workers in postgresql.conf.sample

2017-07-26 Thread Masahiko Sawada
On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata wrote: > Hi, > > I found that postgresql.conf.sample is missing a comment > to note that changing max_logical_replication_workers requires > restart of the server. > > Other such parameters has the comments, so I think the new >

[HACKERS] Missing comment for max_logical_replication_workers in postgresql.conf.sample

2017-07-26 Thread Yugo Nagata
Hi, I found that postgresql.conf.sample is missing a comment to note that changing max_logical_replication_workers requires restart of the server. Other such parameters has the comments, so I think the new parameter also needs this. Attached is a simple patch to fix this. Regards, -- Yugo