Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-09-18 Thread Jan Michálek
Thanks 2017-09-18 15:33 GMT+02:00 Daniel Gustafsson : > > On 18 Sep 2017, at 15:31, Jan Michálek wrote: > > > > I have`t any new version recently, because i was waiting for new > version. But I will have some time on this in next months. How many time I

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-09-18 Thread Daniel Gustafsson
> On 18 Sep 2017, at 15:31, Jan Michálek wrote: > > I have`t any new version recently, because i was waiting for new version. But > I will have some time on this in next months. How many time I have to next > freeze? The next commitfest runs from 2017-11-01 to

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-09-18 Thread Jan Michálek
I have`t any new version recently, because i was waiting for new version. But I will have some time on this in next months. How many time I have to next freeze? Thanks Je; 2017-09-13 1:14 GMT+02:00 Daniel Gustafsson : > > On 08 May 2017, at 12:02, Fabien COELHO

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-09-12 Thread Daniel Gustafsson
> On 08 May 2017, at 12:02, Fabien COELHO > wrote: > > Hello Jan, > > Please give a number to submitted patches. I think that this was v3. > > The patch does NOT fix various issues I pointed out in my previous review: > > - tabs introduced in

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-05-08 Thread Fabien COELHO
Hello Jan, Please give a number to submitted patches. I think that this was v3. The patch does NOT fix various issues I pointed out in my previous review: - tabs introduced in "doc/src/sgml/ref/psql-ref.sgml" - too long help line in "src/bin/psql/help.c" - spurious space after a comma in

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-05-08 Thread Fabien COELHO
Hello Jan, Please give a number to submitted patches. I think that this was v3. The patch does NOT fix various issues I pointed out in my previous review: - tabs introduced in "doc/src/sgml/ref/psql-ref.sgml" - too long help

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-23 Thread Jan Michálek
2017-04-19 10:05 GMT+02:00 Jan Michálek : > 2017-04-19 9:18 GMT+02:00 Fabien COELHO : > >> >> I still do not understand "why" this variant vs CommonMark or whatever other version. >>> >>> Because of simply implementation and readability

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-19 Thread Jan Michálek
2017-04-19 9:18 GMT+02:00 Fabien COELHO : > > I still do not understand "why" this variant vs CommonMark or whatever >>> other version. >>> >> >> Because of simply implementation and readability (looks similar to aligned >> format) and it is comfortable to edit generated

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-19 Thread Fabien COELHO
I still do not understand "why" this variant vs CommonMark or whatever other version. Because of simply implementation and readability (looks similar to aligned format) and it is comfortable to edit generated table (changing values, aligning columns etc.). Hmmm. Why not. Sorry, maybe I`m

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-19 Thread Jan Michálek
2017-04-18 23:06 GMT+02:00 Fabien COELHO : > > Hello, > > There are different flavour of markdown, maybe you should document which >>> one is targetted. Should it be CommonMark? Another variant? Why? >>> >> >> This should be pandoc pipe table. It's because it is similar to

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-18 Thread Fabien COELHO
Hello, There are different flavour of markdown, maybe you should document which one is targetted. Should it be CommonMark? Another variant? Why? This should be pandoc pipe table. It's because it is similar to aligned format. I need add this to documentation (i have it in recent TODO) I

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-18 Thread Jan Michálek
2017-04-18 12:06 GMT+02:00 Fabien COELHO : > > Hello Jan, > > It seems that the patch does not apply anymore on head due to changes in >>> psql non regression tests. Could you rebase? >>> >> >> This should work on current master (all test passed). >> > > Patch applies,

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-18 Thread Fabien COELHO
Hello Jan, It seems that the patch does not apply anymore on head due to changes in psql non regression tests. Could you rebase? This should work on current master (all test passed). Patch applies, compiles and make check is ok. There are different flavour of markdown, maybe you should

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-18 Thread Jan Michálek
2017-04-18 2:27 GMT+02:00 Fabien COELHO : > > Hello Jan, > > Corrected problem with \pset linestyle when format is set to markdown, or >> rst. >> >> Corrected tuples only for markdown and rst (normal and expanded) >> > > It seems that the patch does not apply anymore on head

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-18 Thread Jan Michálek
2017-04-18 2:27 GMT+02:00 Fabien COELHO : > > Hello Jan, > > Corrected problem with \pset linestyle when format is set to markdown, or >> rst. >> >> Corrected tuples only for markdown and rst (normal and expanded) >> > > It seems that the patch does not apply anymore on head

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-17 Thread Fabien COELHO
Hello Jan, Corrected problem with \pset linestyle when format is set to markdown, or rst. Corrected tuples only for markdown and rst (normal and expanded) It seems that the patch does not apply anymore on head due to changes in psql non regression tests. Could you rebase? -- Fabien. --

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-06 Thread Andres Freund
On April 5, 2017 11:19:04 PM PDT, "Jan Michálek" wrote: >2017-04-06 0:55 GMT+02:00 Andres Freund : > >> Hi, >> >> On 2017-04-02 22:28:40 +0200, Jan Michálek wrote: >> > 2017-03-23 17:26 GMT+01:00 Pierre Ducroquet : >> > > The

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-06 Thread Jan Michálek
2017-04-06 0:55 GMT+02:00 Andres Freund : > Hi, > > On 2017-04-02 22:28:40 +0200, Jan Michálek wrote: > > 2017-03-23 17:26 GMT+01:00 Pierre Ducroquet : > > > The new status of this patch is: Waiting on Author > > > > > > > Corrected problem with \pset

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-05 Thread Andres Freund
Hi, On 2017-04-02 22:28:40 +0200, Jan Michálek wrote: > 2017-03-23 17:26 GMT+01:00 Pierre Ducroquet : > > The new status of this patch is: Waiting on Author > > > > Corrected problem with \pset linestyle when format is set to markdown, or > rst. > > Corrected tuples only

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-04-02 Thread Jan Michálek
2017-03-23 17:26 GMT+01:00 Pierre Ducroquet : > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-31 Thread Pierre Ducroquet
On Friday, March 31, 2017 7:17:08 AM CEST, Jan Michálek wrote: 2017-03-30 21:53 GMT+02:00 Pavel Stehule : 2017-03-29 20:11 GMT+02:00 Jan Michálek : 2017-03-27 19:41 GMT+02:00 Jan Michálek : 2017-03-23 17:26

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-31 Thread Jan Michálek
2017-03-31 12:01 GMT+02:00 Pierre Ducroquet : > On Friday, March 31, 2017 7:17:08 AM CEST, Jan Michálek wrote: > >> >> >> 2017-03-30 21:53 GMT+02:00 Pavel Stehule : >> >> >> 2017-03-29 20:11 GMT+02:00 Jan Michálek : >> >> >>

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-30 Thread Jan Michálek
2017-03-30 21:53 GMT+02:00 Pavel Stehule : > > > 2017-03-29 20:11 GMT+02:00 Jan Michálek : > >> >> >> 2017-03-27 19:41 GMT+02:00 Jan Michálek : >> >>> >>> >>> 2017-03-23 17:26 GMT+01:00 Pierre Ducroquet

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-30 Thread Pavel Stehule
2017-03-29 20:11 GMT+02:00 Jan Michálek : > > > 2017-03-27 19:41 GMT+02:00 Jan Michálek : > >> >> >> 2017-03-23 17:26 GMT+01:00 Pierre Ducroquet : >> >>> The following review has been posted through the commitfest application:

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-29 Thread Jan Michálek
2017-03-27 19:41 GMT+02:00 Jan Michálek : > > > 2017-03-23 17:26 GMT+01:00 Pierre Ducroquet : > >> The following review has been posted through the commitfest application: >> make installcheck-world: tested, passed >> Implements feature:

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-27 Thread Jan Michálek
2017-03-23 17:26 GMT+01:00 Pierre Ducroquet : > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-23 Thread Jan Michálek
2017-03-23 17:26 GMT+01:00 Pierre Ducroquet : > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-23 Thread Pierre Ducroquet
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Hi This is my first review (Magnus said in his presentation

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-21 Thread Ideriha, Takeshi
>>I like the idea taking advantage of linestyle utilities >>to implement rst and markdown format efficiently instead of newly developing >>pset format things. >>But I'm thinking two comments below needs change to something about not >>focusing only linestyle. >>That's because they really take

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-21 Thread Jan Michálek
code). >> >> >>> >>> >>> - And I also found patch cannot be applied to current master. >>> >> >> I have 9.6.2 source code. It is not correct? Where i find source code i >> should use? >> > > Please use git master htt

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-21 Thread Pavel Stehule
find source code i > should use? > Please use git master https://wiki.postgresql.org/wiki/Working_with_Git Regards Pavel > > Have nice day > Jan > > >> >> >> Regards, >> >> Ideriha, Takeshi >> >> >> >> *From:* pgsql-hac

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-21 Thread Jan Michálek
*On Behalf Of *Jan Michalek > *Sent:* Sunday, March 19, 2017 5:10 AM > *To:* Peter Eisentraut <peter.eisentr...@2ndquadrant.com> > *Cc:* Pavel Stehule <pavel.steh...@gmail.com>; PostgreSQL mailing lists < > pgsql-hackers@postgresql.org> > *Subject:* Re: [HACKERS] Ot

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-21 Thread Pavel Stehule
-hackers-ow...@postgresql.org [mailto:pgsql-hackers-owner@ > postgresql.org] *On Behalf Of *Jan Michalek > *Sent:* Sunday, March 19, 2017 5:10 AM > *To:* Peter Eisentraut <peter.eisentr...@2ndquadrant.com> > *Cc:* Pavel Stehule <pavel.steh...@gmail.com>; PostgreSQL mailing li

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-21 Thread Ideriha, Takeshi
avel.steh...@gmail.com>; PostgreSQL mailing lists <pgsql-hackers@postgresql.org> Subject: Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki 2017-03-12 19:21 GMT+01:00 Jan Michálek <godzilalal...@gmail.com<mailto:godzilalal...@gmail.com>>: 2017-03-

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-18 Thread Jan Michálek
2017-03-12 19:21 GMT+01:00 Jan Michálek : > > > 2017-03-10 9:43 GMT+01:00 Jan Michálek : > >> >> >> 2017-03-09 20:10 GMT+01:00 Peter Eisentraut < >> peter.eisentr...@2ndquadrant.com>: >> >>> This is looking pretty neat. I played around with it a

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-12 Thread Jan Michálek
2017-03-10 9:43 GMT+01:00 Jan Michálek : > > > 2017-03-09 20:10 GMT+01:00 Peter Eisentraut com>: > >> This is looking pretty neat. I played around with it a bit. There are >> a couple of edge cases that you need to address, I think. >> >

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-12 Thread Jan Michálek
I find, there is problem in tab indent in rst, it looks that lines should be aligned to left in some cases. 2017-03-10 9:43 GMT+01:00 Jan Michálek : > > > 2017-03-09 20:10 GMT+01:00 Peter Eisentraut com>: > >> This is looking pretty neat.

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-10 Thread Jan Michálek
2017-03-09 20:10 GMT+01:00 Peter Eisentraut < peter.eisentr...@2ndquadrant.com>: > This is looking pretty neat. I played around with it a bit. There are > a couple of edge cases that you need to address, I think. > Thanks, original code is very synoptical and and well prepared for adding new

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-09 Thread Peter Eisentraut
This is looking pretty neat. I played around with it a bit. There are a couple of edge cases that you need to address, I think. - Does not support \x - When \pset format is rst, then \pset linestyle also shows up as "rst". That is wrong. Same for markdown. - Broken output in tuples_only

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-06 Thread Jan Michálek
2017-03-06 19:45 GMT+01:00 Peter Eisentraut : > On 3/5/17 05:40, Jan Michálek wrote: > > jelen=# \pset linestyle rst > > Line style is rst. > > jelen=# \pset format wrapped > > Output format is wrapped. > > jelen=# SELECT repeat('Goodnight Irene ', 30); > >

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-06 Thread Peter Eisentraut
On 3/5/17 05:40, Jan Michálek wrote: > jelen=# \pset linestyle rst > Line style is rst. > jelen=# \pset format wrapped > Output format is wrapped. > jelen=# SELECT repeat('Goodnight Irene ', 30); > +-+ > |

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-06 Thread Jan Michálek
2017-03-06 16:25 GMT+01:00 Pavel Stehule : > > > 2017-03-06 16:17 GMT+01:00 Jan Michálek : > >> >> >> 2017-03-06 15:19 GMT+01:00 Pavel Stehule : >> >>> >>> >>> 2017-03-06 0:26 GMT+01:00 Jan Michálek

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-06 Thread Jan Michálek
2017-03-05 14:02 GMT+01:00 Jan Michálek : > > > 2017-03-05 13:39 GMT+01:00 Pavel Stehule : > >> >> >> 2017-03-05 13:22 GMT+01:00 Pavel Stehule : >> >>> >>> >>> 2017-03-05 13:08 GMT+01:00 Jan Michálek

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-05 Thread Jan Michálek
2017-03-05 13:39 GMT+01:00 Pavel Stehule : > > > 2017-03-05 13:22 GMT+01:00 Pavel Stehule : > >> >> >> 2017-03-05 13:08 GMT+01:00 Jan Michálek : >> >>> It is question if it is really new format, because formating is the

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-05 Thread Pavel Stehule
2017-03-05 13:22 GMT+01:00 Pavel Stehule : > > > 2017-03-05 13:08 GMT+01:00 Jan Michálek : > >> It is question if it is really new format, because formating is the same >> as aligned/wrapped format, changed is only style of lines. >> > > Please,

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-05 Thread Pavel Stehule
2017-03-05 13:08 GMT+01:00 Jan Michálek : > It is question if it is really new format, because formating is the same > as aligned/wrapped format, changed is only style of lines. > Please, don't do top posting https://en.wikipedia.org/wiki/Posting_style#Top-posting >

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-05 Thread Jan Michálek
It is question if it is really new format, because formating is the same as aligned/wrapped format, changed is only style of lines. 2017-03-05 12:36 GMT+01:00 Pavel Stehule : > > > 2017-03-05 11:40 GMT+01:00 Jan Michálek : > >> I know, but, both

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-05 Thread Pavel Stehule
2017-03-05 11:40 GMT+01:00 Jan Michálek : > I know, but, both new linestyles are created literally by cloning ascii > linestyle and few lines in print_aligned_text. Both works with "aligned" > and "wrapped" format. In rst is wrapped format useful, in my opinion, in >

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-05 Thread Jan Michálek
I know, but, both new linestyles are created literally by cloning ascii linestyle and few lines in print_aligned_text. Both works with "aligned" and "wrapped" format. In rst is wrapped format useful, in my opinion, in markdown i can`t find how I can get newline in record (maybe it is not posiible

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-01 Thread Peter Eisentraut
If you want to implement a new table format, you should be looking at \pset format, not \pset linestyle. \pset format sets different table formats, such as html, latex, and asciidoc. \pset linestyle just chooses between different styles for the plain-text table format. On 3/1/17 06:31, Jan

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-01 Thread Jan Michálek
Regression test corrected. 2017-03-01 11:43 GMT+01:00 Jan Michálek : > Sorry, I have some errors in my diff, i had copy something from bad > folder. I will fix it. > > 2017-03-01 0:27 GMT+01:00 Jan Michálek : > >> There it is, what i have. >> I

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-01 Thread Jan Michálek
Sorry, I have some errors in my diff, i had copy something from bad folder. I will fix it. 2017-03-01 0:27 GMT+01:00 Jan Michálek : > There it is, what i have. > I need i small help with psql.out, because \pset format wrapped. I don`t > know, how to have it in fixed

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-02-28 Thread Jan Michálek
There it is, what i have. I need i small help with psql.out, because \pset format wrapped. I don`t know, how to have it in fixed width. 2017-02-28 14:23 GMT+01:00 Jan Michálek : > Current state is something like this (diff is attached). > I currently haven`t regression

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-02-28 Thread Jan Michálek
Current state is something like this (diff is attached). I currently haven`t regression test, tab completion etc., I will add this thing following structure of asciidoc commit. Output is tested using retext, rst is OK, md have problem with cells with newline (i must find out, how it is possible

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-02-23 Thread Michael Paquier
On Fri, Feb 24, 2017 at 3:09 AM, Jan Michálek wrote: > I can try it, doesn`t look dificult, but I`m worry, that I`m not able to > write clean, pretty code. If you want to have something available in Postgres 10, you had better be quick. The last commit fest of the

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-02-23 Thread Pavel Stehule
2017-02-23 19:09 GMT+01:00 Jan Michálek : > I can try it, doesn`t look dificult, but I`m worry, that I`m not able to > write clean, pretty code. > It is not a problem, there is lot of iteration for code cleaning Regards Pavel > > 2017-02-23 18:03 GMT+01:00 Alvaro

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-02-23 Thread Jan Michálek
I can try it, doesn`t look dificult, but I`m worry, that I`m not able to write clean, pretty code. 2017-02-23 18:03 GMT+01:00 Alvaro Herrera : > Leknín Řepánek wrote: > > I was mainly using tables in rst, i think, that this format is very > > similar to "grid tables" in

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-02-23 Thread Alvaro Herrera
Leknín Řepánek wrote: > I was mainly using tables in rst, i think, that this format is very > similar to "grid tables" in markdown. And it is really similar to default > borders used > in psql with border 2. Great. So are you writing the code now? :-) -- Álvaro Herrera

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-02-23 Thread Leknín Řepánek
I was mainly using tables in rst, i think, that this format is very similar to "grid tables" in markdown. And it is really similar to default borders used in psql with border 2. On Thu, Feb 23, 2017 at 12:06:36PM -0300, Alvaro Herrera wrote: > Jan Michálek wrote: > > > Is there posibility, that

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-02-23 Thread Alvaro Herrera
Jan Michálek wrote: > Is there posibility, that support for some others formats will be added in > the future? Or id posible to create some of this formats by manipulating > with pset? Or I need use xml for export and use some xslt templates, or > lxml etc. to create format that I will be able to

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-02-23 Thread Michael Paquier
On Thu, Feb 23, 2017 at 7:29 PM, Jan Michálek wrote: > Is there possibility, that support for some others formats will be added in > the future? Or is it possible to create some of this formats by manipulating > with pset? Addition of new formats is definitely possible,

[HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-02-23 Thread Jan Michálek
Have a nice day I`m using \pset format html for generating tables for some documentation, training, reports, blogs... Mainly sample of data for SQL queries, or explaining structure etc. But in some software like sphinx, wiki on redmine, or markdown on github issues I`m not able to insert table in