Re: [HACKERS] Process startup infrastructure is a mess

2017-09-15 Thread Robert Haas
On Thu, Sep 14, 2017 at 9:30 PM, Stephen Frost wrote: > I'm definitely in agreement with Andres on this one. This isn't > refactoring of little-to-never changed code, it's refactoring bits of > the system which are changed with some regularity and looks likely to > continue

Re: [HACKERS] Process startup infrastructure is a mess

2017-09-14 Thread Stephen Frost
Andres, Simon, * Andres Freund (and...@anarazel.de) wrote: > On 2017-09-15 01:06:54 +0100, Simon Riggs wrote: > > If we add something to an area then its a good time to refactor it > > since we were going to get bugs anyway. > > We've added something to the area on a regular basis. As in last in

Re: [HACKERS] Process startup infrastructure is a mess

2017-09-14 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Andres Freund > I think we should seriously consider doing a larger refactoring of this > soon. I've some ideas about what to do, but I'd welcome some thoughts on > whether others consider this a

Re: [HACKERS] Process startup infrastructure is a mess

2017-09-14 Thread Andres Freund
On 2017-09-15 01:06:54 +0100, Simon Riggs wrote: > On 14 September 2017 at 22:44, Andres Freund wrote: > > > The way we currently start and initialize individual postgres (sub-) > > processes is pretty complicated and duplicative. I've a couple > > complaints: > ... > > I

Re: [HACKERS] Process startup infrastructure is a mess

2017-09-14 Thread Simon Riggs
On 14 September 2017 at 22:44, Andres Freund wrote: > The way we currently start and initialize individual postgres (sub-) > processes is pretty complicated and duplicative. I've a couple > complaints: ... > I think we should seriously consider doing a larger refactoring of

[HACKERS] Process startup infrastructure is a mess

2017-09-14 Thread Andres Freund
Hi, The way we currently start and initialize individual postgres (sub-) processes is pretty complicated and duplicative. I've a couple complaints: 1) It's completely non-obvious that bootstrap.c:AuxiliaryProcessMain() can get invoked both via postmaster for subprocesses (startup, wal