Re: [HACKERS] Re: [BUGS] Problem in using pgbench's --connect(-C) and --rate=rate(-R rate) options together.

2017-03-24 Thread Teodor Sigaev
No, it is really needed so that the lag measure is correct. Thank you, pushed -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Re: [BUGS] Problem in using pgbench's --connect(-C) and --rate=rate(-R rate) options together.

2017-03-24 Thread Fabien COELHO
Hello Teodor, Hi, the patch looks good except why do you remove initialization of is_throttled? Suppose, just a typo? No, it is really needed so that the lag measure is correct. Without the is_throttled change: sh> ./pgbench -T 3 -R 10 -C -S -P 1 starting vacuum...end. progress: 1.0 s,

Re: [HACKERS] Re: [BUGS] Problem in using pgbench's --connect(-C) and --rate=rate(-R rate) options together.

2017-03-23 Thread Teodor Sigaev
Hi, the patch looks good except why do you remove initialization of is_throttled? Suppose, just a typo? --- a/src/bin/pgbench/pgbench.c +++ b/src/bin/pgbench/pgbench.c @@ -1967,7 +1967,6 @@ top: st->listen = false; st->sleeping = false; st->throttling = false; -

[HACKERS] Re: [BUGS] Problem in using pgbench's --connect(-C) and --rate=rate(-R rate) options together.

2017-03-17 Thread David Steele
On 3/17/17 2:08 AM, Fabien COELHO wrote: > > Hello David, > >>> Repost from bugs. >> >> This patch does not apply at cccbdde: > > Indeed. It should not. The fix is for the 9.6 branch. The issue has been > fixed by some heavy but very welcome restructuring in master. Whoops, sorry about that!

[HACKERS] Re: [BUGS] Problem in using pgbench's --connect(-C) and --rate=rate(-R rate) options together.

2017-03-17 Thread Fabien COELHO
Hello David, Repost from bugs. This patch does not apply at cccbdde: Indeed. It should not. The fix is for the 9.6 branch. The issue has been fixed by some heavy but very welcome restructuring in master. Marked as "Waiting for Author". I put it back to "Needs review". -- Fabien.

[HACKERS] Re: [BUGS] Problem in using pgbench's --connect(-C) and --rate=rate(-R rate) options together.

2017-03-16 Thread David Steele
On 1/25/17 2:58 PM, Fabien COELHO wrote: > > Repost from bugs. This patch does not apply at cccbdde: $ patch -p1 < ../other/pgbench-CR-bug-1.patch (Stripping trailing CRs from patch.) patching file src/bin/pgbench/pgbench.c Hunk #1 FAILED at 1967. Hunk #2 succeeded at 4180 with fuzz 2 (offset

[HACKERS] Re: [BUGS] Problem in using pgbench's --connect(-C) and --rate=rate(-R rate) options together.

2017-01-25 Thread Fabien COELHO
Repost from bugs. -- Fabien. -- Forwarded message -- Date: Wed, 25 Jan 2017 18:59:45 +0100 (CET) From: Fabien COELHO To: nuko yokohama Cc: PostgreSQL Bugs List Subject: Re: [BUGS] Problem in using