Re: [HACKERS] valgrind vs. shared typmod registry

2017-09-18 Thread Andres Freund
Hi, On 2017-09-18 18:04:36 +1200, Thomas Munro wrote: > On Mon, Sep 18, 2017 at 5:39 PM, Thomas Munro > wrote: > > Here is a patch to fix that. > > Here's a better one (same code, corrected commit message). Pushed. For a second I was tempted to also replace the

Re: [HACKERS] valgrind vs. shared typmod registry

2017-09-18 Thread Thomas Munro
On Mon, Sep 18, 2017 at 5:39 PM, Thomas Munro wrote: > Here is a patch to fix that. Here's a better one (same code, corrected commit message). -- Thomas Munro http://www.enterprisedb.com 0001-Fix-uninitialized-variable-in-dshash.c.patch Description: Binary data

Re: [HACKERS] valgrind vs. shared typmod registry

2017-09-17 Thread Thomas Munro
On Sun, Sep 17, 2017 at 8:49 AM, Thomas Munro wrote: > On Sun, Sep 17, 2017 at 7:42 AM, Thomas Munro > wrote: >> On Sun, Sep 17, 2017 at 12:30 AM, Tomas Vondra >> wrote: >>> I've been running some

Re: [HACKERS] valgrind vs. shared typmod registry

2017-09-16 Thread Thomas Munro
On Sun, Sep 17, 2017 at 7:42 AM, Thomas Munro wrote: > On Sun, Sep 17, 2017 at 12:30 AM, Tomas Vondra > wrote: >> I've been running some regression tests under valgrind, and it seems >> select_parallel triggers some uses of

Re: [HACKERS] valgrind vs. shared typmod registry

2017-09-16 Thread Peter Geoghegan
On Sat, Sep 16, 2017 at 5:30 AM, Tomas Vondra wrote: > I've been running tests under valgrind not too long ago and I don't > recall such failures, so perhaps something broke it in the past few days. That's what we have the buildfarm animal Skink for. It has indeed

Re: [HACKERS] valgrind vs. shared typmod registry

2017-09-16 Thread Thomas Munro
On Sun, Sep 17, 2017 at 12:30 AM, Tomas Vondra wrote: > I've been running some regression tests under valgrind, and it seems > select_parallel triggers some uses of uninitialized values in dshash. If > I'm reading the reports right, it complains about

[HACKERS] valgrind vs. shared typmod registry

2017-09-16 Thread Tomas Vondra
Hi, I've been running some regression tests under valgrind, and it seems select_parallel triggers some uses of uninitialized values in dshash. If I'm reading the reports right, it complains about hashtable->size_log2 being not being initialized in ensure_valid_bucket_pointers. I've been running