Re: [HACKERS] walsender termination error messages worse in v10

2017-06-09 Thread Peter Eisentraut
On 6/8/17 01:57, Noah Misch wrote: > On Fri, Jun 02, 2017 at 11:51:26AM -0700, Andres Freund wrote: >> commit 7c4f52409a8c7d85ed169bbbc1f6092274d03920 >> Author: Peter Eisentraut >> Date: 2017-03-23 08:36:36 -0400 >> >> Logical replication support for initial data copy >>

Re: [HACKERS] walsender termination error messages worse in v10

2017-06-08 Thread Alvaro Herrera
Petr Jelinek wrote: > It took me a while to understand why walreceiver does this originally, > but it did make sense to me once I understood the [...], so I did it > the same way. In other words, the coding pattern needs a comment in both places. -- Álvaro Herrera

Re: [HACKERS] walsender termination error messages worse in v10

2017-06-08 Thread Petr Jelinek
On 08/06/17 23:57, Andres Freund wrote: > On 2017-06-03 00:55:22 +0200, Petr Jelinek wrote: >> On 02/06/17 23:45, Andres Freund wrote: >>> Hi Petr, >>> >>> On 2017-06-02 22:57:37 +0200, Petr Jelinek wrote: On 02/06/17 20:51, Andres Freund wrote: > I don't understand why the new block is

Re: [HACKERS] walsender termination error messages worse in v10

2017-06-08 Thread Andres Freund
On 2017-06-03 00:55:22 +0200, Petr Jelinek wrote: > On 02/06/17 23:45, Andres Freund wrote: > > Hi Petr, > > > > On 2017-06-02 22:57:37 +0200, Petr Jelinek wrote: > >> On 02/06/17 20:51, Andres Freund wrote: > >>> I don't understand why the new block is there, nor does the commit > >>> message

Re: [HACKERS] walsender termination error messages worse in v10

2017-06-07 Thread Noah Misch
On Fri, Jun 02, 2017 at 11:51:26AM -0700, Andres Freund wrote: > commit 7c4f52409a8c7d85ed169bbbc1f6092274d03920 > Author: Peter Eisentraut > Date: 2017-03-23 08:36:36 -0400 > > Logical replication support for initial data copy > > made walreceiver emit worse messages in

Re: [HACKERS] walsender termination error messages worse in v10

2017-06-02 Thread Petr Jelinek
On 02/06/17 23:45, Andres Freund wrote: > Hi Petr, > > On 2017-06-02 22:57:37 +0200, Petr Jelinek wrote: >> On 02/06/17 20:51, Andres Freund wrote: >>> I don't understand why the new block is there, nor does the commit >>> message explain it. >>> >> >> Hmm, that particular change can actually be

Re: [HACKERS] walsender termination error messages worse in v10

2017-06-02 Thread Andres Freund
Hi Petr, On 2017-06-02 22:57:37 +0200, Petr Jelinek wrote: > On 02/06/17 20:51, Andres Freund wrote: > > I don't understand why the new block is there, nor does the commit > > message explain it. > > > > Hmm, that particular change can actually be reverted. It was needed for > one those custom

Re: [HACKERS] walsender termination error messages worse in v10

2017-06-02 Thread Petr Jelinek
Hi Andres, On 02/06/17 20:51, Andres Freund wrote: > Hi, > > commit 7c4f52409a8c7d85ed169bbbc1f6092274d03920 > Author: Peter Eisentraut > Date: 2017-03-23 08:36:36 -0400 > > Logical replication support for initial data copy > > made walreceiver emit worse messages in

[HACKERS] walsender termination error messages worse in v10

2017-06-02 Thread Andres Freund
Hi, commit 7c4f52409a8c7d85ed169bbbc1f6092274d03920 Author: Peter Eisentraut Date: 2017-03-23 08:36:36 -0400 Logical replication support for initial data copy made walreceiver emit worse messages in v10 than before when the master gets shut down. Before 10 you'll get