[HACKERS] PATCH: CITEXT 2.0 v2

2008-07-05 Thread David E . Wheeler
On Jun 27, 2008, at 18:22, David E. Wheeler wrote: Please find attached a patch adding a locale-aware, case-insensitive text type, called citext, as a contrib module. Here is a new version of the patch, with the following changes: * Fixed formatting to be more like core. * Added appropriate

Re: [HACKERS] CommitFest rules

2008-07-05 Thread Tom Lane
Robert Treat <[EMAIL PROTECTED]> writes: > Hmm, looks like some of the things I was thinking about have been added > recenelt... cool. One question I have still remains though, on the main > developer page (http://wiki.postgresql.org/wiki/Development_information) it > has a link to the "current

Re: [HACKERS] time_stamp type

2008-07-05 Thread Tom Lane
"Stephen R. van den Berg" <[EMAIL PROTECTED]> writes: > What's the deal with this type? It's a domain over timestamptz, as required by the SQL spec definition of the information_schema. postgres=# \dD information_schema.time_stamp List of doma

Re: [PATCHES] [HACKERS] Solaris ident authentication using unix domain sockets

2008-07-05 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Robert Treat wrote: >> Hmm... I've always been told that Solaris didn't support this because the >> Solaris developers feel that IDENT is inherently insecure. > We don't actually use the Ident protocol for Unix sockets on any > platform. Indeed. If

Re: [HACKERS] PATCH: CITEXT 2.0

2008-07-05 Thread David E. Wheeler
On Jul 5, 2008, at 08:13, Tom Lane wrote: Stupid question: What would the negation of || actually be? There isn't one is, there? Per the docs, NEGATOR is only sensible for operators returning boolean. Message received. Many thanks, Tom, as usual. Best, David -- Sent via pgsql-hackers ma

Re: [HACKERS] PATCH: CITEXT 2.0

2008-07-05 Thread David E. Wheeler
On Jul 5, 2008, at 02:58, Gregory Stark wrote: do I need to worry about memory leaks in citext_eq, citext_ne, citext_gt, etc., yes Thanks. David -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/

Re: [HACKERS] PATCH: CITEXT 2.0

2008-07-05 Thread David E. Wheeler
On Jul 5, 2008, at 02:58, Gregory Stark wrote: txt = cilower( PG_GETARG_TEXT_PP(0) ); str = VARDATA_ANY(txt); result = hash_any((unsigned char *) str, VARSIZE_ANY_EXHDR(txt)); I thought your data type implemented a locale dependent collation, not just a case insensitive collation.

Re: [HACKERS] A Windows x64 port of PostgreSQL

2008-07-05 Thread Ron Mayer
chris wrote: C++0x standards committee where they finalized long long as being required to be 8 AFAIK, we oughtn't care what C++ standards say, because PostgreSQL is implemented in C, and therefore needs to follow what the *C* standards say. I agree the C++ standards should matter one bit to

Re: [PATCHES] [HACKERS] Solaris ident authentication using unix domain sockets

2008-07-05 Thread Andrew Dunstan
Robert Treat wrote: On Thursday 03 July 2008 14:01:22 Tom Lane wrote: Garick Hamlin <[EMAIL PROTECTED]> writes: I have a patch that I have been using to support postgresql's notion of ident authentication when using unix domain sockets on Solaris. This patch basically just ad

Re: [HACKERS] CommitFest rules

2008-07-05 Thread Robert Treat
On Saturday 05 July 2008 18:07:46 Robert Treat wrote: > On Thursday 03 July 2008 15:12:08 Joshua D. Drake wrote: > > On Thu, 2008-07-03 at 20:06 +0100, Dave Page wrote: > > > On Thu, Jul 3, 2008 at 8:02 PM, Marko Kreen <[EMAIL PROTECTED]> wrote: > > > > On 7/3/08, Dave Page <[EMAIL PROTECTED]> wrot

Re: [HACKERS] WITH RECURSIVE updated to CVS TIP

2008-07-05 Thread David Fetter
On Sat, Jul 05, 2008 at 10:43:57AM +0200, Hans-Juergen Schoenig wrote: > hello david, > > i did some quick testing with this wonderful patch. > it seems there are some flaws in there still: > > test=# explain select count(*) > test-# from ( WITH RECURSIVE t(n) AS ( SELECT 1 UNION ALL SELECT

Re: [HACKERS] CommitFest rules

2008-07-05 Thread Robert Treat
On Thursday 03 July 2008 18:16:38 Dave Page wrote: > On Thu, Jul 3, 2008 at 10:37 PM, Tom Lane <[EMAIL PROTECTED]> wrote: > > "Merlin Moncure" <[EMAIL PROTECTED]> writes: > >> Are you suggesting that omission of a patch on the 'fest' page means > >> that you are bumped from the fest? > > > > No, if

Re: [HACKERS] CommitFest rules

2008-07-05 Thread Robert Treat
On Thursday 03 July 2008 15:12:08 Joshua D. Drake wrote: > On Thu, 2008-07-03 at 20:06 +0100, Dave Page wrote: > > On Thu, Jul 3, 2008 at 8:02 PM, Marko Kreen <[EMAIL PROTECTED]> wrote: > > > On 7/3/08, Dave Page <[EMAIL PROTECTED]> wrote: > > >> it concerns me that despite it being day 3 of the Ju

Re: [HACKERS] Solaris ident authentication using unix domain sockets

2008-07-05 Thread Robert Treat
On Thursday 03 July 2008 14:01:22 Tom Lane wrote: > Garick Hamlin <[EMAIL PROTECTED]> writes: > > I have a patch that I have been using to support postgresql's > > notion of ident authentication when using unix domain sockets on > > Solaris. This patch basically just adds support for using > >

Re: [HACKERS] introduction of WIP window function patch

2008-07-05 Thread Simon Riggs
On Sun, 2008-07-06 at 03:40 +0900, H.Harada wrote: > Hi, > > 2008/7/6 Simon Riggs <[EMAIL PROTECTED]>: > > > > On Sat, 2008-07-05 at 16:20 +0200, Martijn van Oosterhout wrote: > >> On Sat, Jul 05, 2008 at 07:04:29PM +0900, H.Harada wrote: > > > >> > http://umitanuki.net/pgsql/wfv01/design.html >

Re: [HACKERS] introduction of WIP window function patch

2008-07-05 Thread H . Harada
2008/7/5 Martijn van Oosterhout <[EMAIL PROTECTED]>: > On Sat, Jul 05, 2008 at 07:04:29PM +0900, H.Harada wrote: >> Hi, >> >> As I proposed a month before, I am working on window function. > > Very nice! > >> http://umitanuki.net/pgsql/wfv01/design.html >> >> The problem is, as written in the "Thin

Re: [HACKERS] introduction of WIP window function patch

2008-07-05 Thread H . Harada
Hi, 2008/7/6 Simon Riggs <[EMAIL PROTECTED]>: > > On Sat, 2008-07-05 at 16:20 +0200, Martijn van Oosterhout wrote: >> On Sat, Jul 05, 2008 at 07:04:29PM +0900, H.Harada wrote: > >> > http://umitanuki.net/pgsql/wfv01/design.html >> > >> > The problem is, as written in the "Things to discussed" sect

Re: [HACKERS] introduction of WIP window function patch

2008-07-05 Thread Simon Riggs
On Sat, 2008-07-05 at 16:20 +0200, Martijn van Oosterhout wrote: > On Sat, Jul 05, 2008 at 07:04:29PM +0900, H.Harada wrote: > > http://umitanuki.net/pgsql/wfv01/design.html > > > > The problem is, as written in the "Things to discussed" section of the > > document, how you define window functio

[HACKERS] time_stamp type

2008-07-05 Thread Stephen R. van den Berg
What's the deal with this type? Is it used internally? It's the only type that seems to have anything meaningfull in typdefaultbin and typdefault columns in pg_type. -- Sincerely, Stephen R. van den Berg. WARNING: Do not look into laser with remaining eye -- Sent via pgsql-hackers m

Re: [HACKERS] PATCH: CITEXT 2.0

2008-07-05 Thread Tom Lane
"David E. Wheeler" <[EMAIL PROTECTED]> writes: >>> Also OPERATOR || has probably wrong negator. >> >> Right, good catch. > Stupid question: What would the negation of || actually be? There > isn't one is, there? Per the docs, NEGATOR is only sensible for operators returning boolean.

Re: [HACKERS] introduction of WIP window function patch

2008-07-05 Thread Martijn van Oosterhout
On Sat, Jul 05, 2008 at 07:04:29PM +0900, H.Harada wrote: > Hi, > > As I proposed a month before, I am working on window function. Very nice! > http://umitanuki.net/pgsql/wfv01/design.html > > The problem is, as written in the "Things to discussed" section of the > document, how you define wind

[HACKERS] introduction of WIP window function patch

2008-07-05 Thread H . Harada
Hi, As I proposed a month before, I am working on window function. Although this work is at quite early step, I would like to introduce it since a part of it have been finished. If you can afford and are interested in it, please review the document and patch, or compile the applied source to execu

Re: [HACKERS] PATCH: CITEXT 2.0

2008-07-05 Thread Gregory Stark
"David E. Wheeler" <[EMAIL PROTECTED]> writes: > do I need to worry about memory leaks in citext_eq, citext_ne, citext_gt, > etc., yes -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Ask me about EnterpriseDB's 24x7 Postgres support! -- Sent via pgsql-hackers mailing

Re: [HACKERS] PATCH: CITEXT 2.0

2008-07-05 Thread Gregory Stark
"David E. Wheeler" <[EMAIL PROTECTED]> writes: > On Jul 3, 2008, at 09:53, Alvaro Herrera wrote: > >>> Thanks. What would citext_hash() look like? I don't see a text_hash() to >>> borrow from anywhere in src/. >> >> See hash_any(). I assume the difficulty is making sure that >> hash("FOO") = has

[HACKERS] Re: [COMMITTERS] pgsql: Fix a couple of bugs in win32 shmem name generation: * Don't cut

2008-07-05 Thread Magnus Hagander
Alvaro Herrera wrote: > Magnus Hagander wrote: >> Tom Lane wrote: > >>> According to what you just told me, the original coding is storing the >>> name in a "local namespace", which presumably means it won't conflict >>> anyway. Ergo, the existing coding is simply broken and there's nothing >>> w

Re: [HACKERS] WITH RECURSIVE updated to CVS TIP

2008-07-05 Thread Hans-Juergen Schoenig
hello david, i did some quick testing with this wonderful patch. it seems there are some flaws in there still: test=# explain select count(*) test-# from ( WITH RECURSIVE t(n) AS ( SELECT 1 UNION ALL SELECT DISTINCT n+1 FROM t ) test(# SELECT * FROM t WHERE n < 500