Re: [HACKERS] Window functions patch v04 for the September commit fest

2008-09-02 Thread Heikki Linnakangas
Simon Riggs wrote: On Tue, 2008-09-02 at 15:51 +0300, Heikki Linnakangas wrote: The needs of access to the rows are so different that it seems best to me to delegate the buffering to the window function. That seems sensible in some ways, not others. In the API I proposed later in that mail,

Re: [HACKERS] IN vs EXISTS equivalence

2008-09-02 Thread daveg
On Thu, Aug 14, 2008 at 06:50:09PM +0100, Simon Riggs wrote: > > On Fri, 2008-08-08 at 16:23 -0400, Tom Lane wrote: > > > NOT IN is a lot trickier, > > condition: you must also assume that the comparison operator involved > > never yields NULL for non-null inputs. That might be okay for btree >

Re: [HACKERS] Window functions patch v04 for the September commit fest

2008-09-02 Thread Simon Riggs
On Tue, 2008-09-02 at 15:51 +0300, Heikki Linnakangas wrote: > The needs of access to the rows are so different that it seems best to > me to delegate the buffering to the window function. That seems sensible in some ways, not others. Some of the window functions, like lead and lag merely speci

Re: [HACKERS] make dist does not include man.tar.gz and postgres.tar.gz

2008-09-02 Thread Devrim GÜNDÜZ
Hi, On Tue, 2008-09-02 at 17:03 -0400, Tom Lane wrote: > I think you need "make distprep" first. Still, we have problems here. I first created man.tar.gz, postgres.tar.gz and ran gmake INSTALL HISTORY under doc/src/sgml and moved them to top level directory. However, I am getting the following e

Re: [HACKERS] Publish GUC flags to custom variables

2008-09-02 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > Postgres supports to add custom GUC variables on runtime, but we > cannot use GUC flags in them. This patch adds the flags argument > to DefineCusomXxx() functions. The flags were always 0 until now. Of course the problem with this is that it breaks e

Re: [HACKERS] libpq object hooks (libpq events)

2008-09-02 Thread Andrew Chernow
Alvaro Herrera wrote: Andrew Chernow escribió: Attached is the latest patch. It has addressed the requested changes found here: http://archives.postgresql.org/pgsql-patches/2008-05/msg00389.php Its a tarball because there are two new files, libpq-events.c and libpq-events.h. The patch is

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-02 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Greg just sent me this patch, augmenting the one I sent to add source > > file and line to GUC vars; Greg's patch adds a column with the default > > value of each var. > > I haven't tested, but doesn't this lose the source-location i

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-02 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I haven't tested, but doesn't this lose the source-location information >> if a setting acquired from the config file is temporarily overridden via >> SET (consider SET LOCAL, or a SET in a rolled-back xact)? It'll go to >> NULL and n

[HACKERS] pg_typeof() (was: Mysterious Bus Error with get_fn_expr_argtype())

2008-09-02 Thread Brendan Jurd
On Tue, Sep 2, 2008 at 3:31 PM, Brendan Jurd <[EMAIL PROTECTED]> wrote: > Barring any further comments/objections, I'll go ahead and prepare a > patch to add this to core. > Any opinions on where pg_typeof() should be defined? This function is a little unusual and doesn't seem to slot nicely into

Re: [HACKERS] Window functions patch v04 for the September commit fest

2008-09-02 Thread Hitoshi Harada
2008/9/2 Heikki Linnakangas <[EMAIL PROTECTED]>: > Hitoshi Harada wrote: >> >> 2008/9/2 Heikki Linnakangas <[EMAIL PROTECTED]>: >> In my understanding, the "Window Frame" is defined >> by clauses such like "ROWS BETWEEN ... ", "RANGE BETWEEN ... " or so, >> contrast to "Window Partition" defined by

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-02 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Greg just sent me this patch, augmenting the one I sent to add source > file and line to GUC vars; Greg's patch adds a column with the default > value of each var. I haven't tested, but doesn't this lose the source-location information if a setting acqu

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Alvaro Herrera
Tom Lane escribió: > Gregory Stark <[EMAIL PROTECTED]> writes: > > Tom Lane <[EMAIL PROTECTED]> writes: > >> BTW, there are at least two copies of that code to be changed. I'd > >> suggest grepping for assignments to t_hoff to be sure there aren't more. Besides heap_form_tuple and heap_formtuple,

Re: [HACKERS] What is the use of the CommitFestBlank template?

2008-09-02 Thread Brendan Jurd
On Wed, Sep 3, 2008 at 10:55 AM, Tom Lane <[EMAIL PROTECTED]> wrote: > "Brendan Jurd" <[EMAIL PROTECTED]> writes: >> I suppose we could introduce an argument to the template, so that you >> would call it with {{subst:CommitFestBlank|November 2008}}, but it's >> only going to save us one edit. I ca

Re: [HACKERS] COPY statement cannot take binding parameters

2008-09-02 Thread Tom Lane
"Stephen R. van den Berg" <[EMAIL PROTECTED]> writes: > Trying to parse and bind the following: >COPY (SELECT $1::INT) TO STDOUT > gives a correct parsing-done, but then in the parameterdescription tells > me that there are no parameters. > Is this intended? It's an artifact of the klugy way

Re: [HACKERS] What is the use of the CommitFestBlank template?

2008-09-02 Thread Tom Lane
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > I suppose we could introduce an argument to the template, so that you > would call it with {{subst:CommitFestBlank|November 2008}}, but it's > only going to save us one edit. I can add this in quite trivially if > you see it as an improvement. +1. As

Re: [HACKERS] What is the use of the CommitFestBlank template?

2008-09-02 Thread Brendan Jurd
On Wed, Sep 3, 2008 at 10:31 AM, Tom Lane <[EMAIL PROTECTED]> wrote: > > It still seems a bit awkward though. AFAICS the sentence about > "This is the page for CommitFest starting 2008 November" would > have to be inserted after committing the first version of the > page? > Yes, you do have to pe

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > Tom Lane <[EMAIL PROTECTED]> writes: >> BTW, there are at least two copies of that code to be changed. I'd >> suggest grepping for assignments to t_hoff to be sure there aren't more. > I did send in a patch a while ago to get rid of the old HeapFormTupl

Re: [HACKERS] What is the use of the CommitFestBlank template?

2008-09-02 Thread Tom Lane
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > This template is a useful way to create a blank CommitFest page. Just > start a new page and include the template's contents with > {{subst:CommitFestBlank}} Oh, I guess I forgot the subst: part. Thanks for the clue. It still seems a bit awkward t

Re: [HACKERS] What is the use of the CommitFestBlank template?

2008-09-02 Thread Brendan Jurd
On Wed, Sep 3, 2008 at 3:39 AM, Tom Lane <[EMAIL PROTECTED]> wrote: > The description of the CommitFestBlank template suggests that it sets up > an editable page for you, but AFAICT it does no such thing. I had to > manually create all the right sections: > http://wiki.postgresql.org/index.php?tit

Re: [HACKERS] libpq object hooks (libpq events)

2008-09-02 Thread Alvaro Herrera
Andrew Chernow escribió: > Attached is the latest patch. It has addressed the requested changes > found here: > http://archives.postgresql.org/pgsql-patches/2008-05/msg00389.php > > Its a tarball because there are two new files, libpq-events.c and > libpq-events.h. The patch is in the tarball

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Gregory Stark
Tom Lane <[EMAIL PROTECTED]> writes: > BTW, there are at least two copies of that code to be changed. I'd > suggest grepping for assignments to t_hoff to be sure there aren't more. I did send in a patch a while ago to get rid of the old HeapFormTuple() and friends. -- Gregory Stark Enterpr

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-02 Thread Marko Kreen
On 9/3/08, Tom Lane <[EMAIL PROTECTED]> wrote: > "Asko Oja" <[EMAIL PROTECTED]> writes: > > Anything that will reduce potential downtime should be way to go. > > That argument didn't seem to me to be worth the electrons to rebut, > but now that someone else has repeated it, maybe I should. It's

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-02 Thread Marko Kreen
On 9/3/08, Tom Lane <[EMAIL PROTECTED]> wrote: > Gregory Stark <[EMAIL PROTECTED]> writes: > > "Marko Kreen" <[EMAIL PROTECTED]> writes: > >> Uh. So you want force "proper" units in presentations at the price > >> of everyday admin operations? Does not seem like a sensible tradeoff. > > > It

Re: [HACKERS] Feature request: better debug messages

2008-09-02 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Brian Hurt wrote: >> So I thought upping the debug level of postgres would help, by adding >> a -o '-d 5' to the pg_ctl command line. The log file that gets spit >> out in this case is attached. What is noticeable is how unhelpfull >> it is. > I t

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-02 Thread Tom Lane
"Asko Oja" <[EMAIL PROTECTED]> writes: > Anything that will reduce potential downtime should be way to go. That argument didn't seem to me to be worth the electrons to rebut, but now that someone else has repeated it, maybe I should. It's ludicrous to claim that allowing case insensitivity here w

Re: [HACKERS] gsoc, oprrest function for text search take 2

2008-09-02 Thread Tom Lane
I wrote: > ... One possibly > performance-relevant point is to use DatumGetTextPP for detoasting; > you've already paid the costs by using VARDATA_ANY etc, so you might > as well get the benefit. Actually, wait a second. That code doesn't work at all on toasted data, because it's trying to use V

Re: [HACKERS] WIP: Column-level Privileges

2008-09-02 Thread Stephen Frost
g, and last will be working on the changes to implement the permission checks. Thanks, Stephen colprivs_wip.20080902.diff.gz Description: Binary data signature.asc Description: Digital signature

Re: [HACKERS] gsoc, oprrest function for text search take 2

2008-09-02 Thread Tom Lane
=?UTF-8?B?SmFuIFVyYmHFhHNraQ==?= <[EMAIL PROTECTED]> writes: > Pre-sorting introduced one problem (see XXX in code): it's not easy > anymore to get the minimal frequency of MCELEM values. I was using it to > assert that the selectivity of a tsquery node containing a lexeme not in > MCELEM is no

Re: [HACKERS] Feature request: better debug messages

2008-09-02 Thread Alvaro Herrera
Brian Hurt wrote: > So I thought upping the debug level of postgres would help, by adding > a -o '-d 5' to the pg_ctl command line. The log file that gets spit > out in this case is attached. What is noticeable is how unhelpfull > it is. I think this is just the stderr. The rest of the err

Re: [HACKERS] Window functions patch v04 for the September commit fest

2008-09-02 Thread Neil Conway
On Tue, Sep 2, 2008 at 9:35 AM, David Fetter <[EMAIL PROTECTED]> wrote: > Any chance we can buy a few copies of the official one for use on the > project? AFAIK there is no significant difference between the "official" standard and the draft version available online, so I don't see the point. Nei

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Ryan Bradetich
Hello Tom, > Well, as Greg pointed out, setting t_hoff correctly should be sufficient > for squeezing out useless padding between the tuple header and the tuple > data. The real objection here is that that's leaving most of the > possible gain still on the table. The tuple *as a whole* (header a

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Ryan Bradetich
Hello Greg, On Tue, Sep 2, 2008 at 9:54 AM, Gregory Stark <[EMAIL PROTECTED]> wrote: > "Ryan Bradetich" <[EMAIL PROTECTED]> writes: > The structure on the page is to have a bunch of tuples stored one after the > other. Each tuple is maxaligned after the previous (actually before the > previous sin

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-02 Thread Asko Oja
Anything that will reduce potential downtime should be way to go. To me it seems that Peter uses the loudest voice and others just don't care enough. Using kB for kilobyte seems quite alien and confusing. I have not noticed that to be used in software i use in my everyday work and could not find a

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-02 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > "Marko Kreen" <[EMAIL PROTECTED]> writes: >> Uh. So you want force "proper" units in presentations at the price >> of everyday admin operations? Does not seem like a sensible tradeoff. > It didn't to anyone else when Peter wrote the current version eit

Re: [HACKERS] make dist does not include man.tar.gz and postgres.tar.gz

2008-09-02 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > I'm wondering how are these things supposed to be generated. Does Marc > create the regular tarballs using "make dist", and then unpack them and > include the other tarballs inside? Does he use a different make target? I think you need "make distprep"

Re: [HACKERS] [PATCH] Make gram.y use palloc/pfree for memory management

2008-09-02 Thread Tom Lane
"Marko Kreen" <[EMAIL PROTECTED]> writes: > On 9/1/08, Marko Kreen <[EMAIL PROTECTED]> wrote: >> First a correction, overriding malloc/free seems dangerous they >> seems to leak out, so correct would be to use YYMALLOC/YYFREE. >> This leaves 1.875 potentially leaking, but danger seems small. > Her

[HACKERS] make dist does not include man.tar.gz and postgres.tar.gz

2008-09-02 Thread Alvaro Herrera
Hi, Devrim has been trying to set up RPM files for 8.4devel. However, the tarballs he is generating are not alike those found in our FTP site; official ones include manpages and HTML docs as man.tar.gz and postgres.tar.gz, but a simple "make dist" does not seem to include them. I'm wondering how

Re: [HACKERS] Page layout footprint

2008-09-02 Thread Zdenek Kotala
Zdenek Kotala napsal(a): 32/64 bit issue is little bit different story and it is general (not only SPARC but on SPARC has bigger impact). Problem is that CRC32 gives probably different result when it is compiled 32bit or 64bit. I'm going to examine it more. I'm sorry about noise. Everythin

Re: [HACKERS] WIP patch: Collation support

2008-09-02 Thread Tom Lane
Martijn van Oosterhout <[EMAIL PROTECTED]> writes: > And I think that's backwards. Why can we only use a feature once every > OS out there implements it? We still run on systems that don't have SSL > support. LC_TYPE settings are not portable between systems, yet that > doesn't bother anyone. Why s

Re: [HACKERS] Index scan troubles

2008-09-02 Thread Markus Wanner
Hi, Gregory Stark wrote: It's right for your equality case which is effectively x=const, y=const, z=const. It's not for row comparisons case for which you need a funny "header" ScanKey. See the comments in access/skey.h, search for "row comparisons". I'm not sure if there's a function to create

Re: [HACKERS] WIP patch: Collation support

2008-09-02 Thread Alvaro Herrera
Radek Strnad escribió: > Ok, so do you suggest to leave it with a notice "reindex database" or start > to solve it somehow? I don't know. If there are two tasks that need the same treatment, it seems a safe conclusion that they need a common solution. -- Alvaro Herrera

Re: [HACKERS] Mysterious Bus Error with get_fn_expr_argtype()

2008-09-02 Thread David E. Wheeler
On Sep 2, 2008, at 11:06, Tom Lane wrote: Better try that again. regression=# select 1043::regtype; regtype --- character varying (1 row) regression=# I see no need for two functions here. Oh. I tried: try=# select 1::regtype; regtype - 1 I had assumed that

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > The other 4 bytes you could save is by packing the whole tuples themselves > more closely on the page. That happens when the item pointer is added and > pointed to the tuple. To do that heap_form_tuple would have to return data > back to the caller about

Re: [HACKERS] Mysterious Bus Error with get_fn_expr_argtype()

2008-09-02 Thread Tom Lane
"David E. Wheeler" <[EMAIL PROTECTED]> writes: > Looks like regtype displays as an integer. Better try that again. regression=# select 1043::regtype; regtype --- character varying (1 row) regression=# I see no need for two functions here. r

Re: [HACKERS] Index scan troubles

2008-09-02 Thread Tom Lane
Markus Wanner <[EMAIL PROTECTED]> writes: > I'm having a hard time using an index scan. So far, I've done quite well > with ScanKeyInit for equality searches. But now I need to scan an index > from a given starting point. Something like: > (x, y, z,...) > (const, const, const,...) > For the

Re: [HACKERS] Mysterious Bus Error with get_fn_expr_argtype()

2008-09-02 Thread David E. Wheeler
On Sep 2, 2008, at 10:43, David E. Wheeler wrote: Looks like regtype displays as an integer. So how about pg_regtypeof() and pg_typeof()? Sorry, make that: PG_FUNCTION_INFO_V1(pg_regtypeof); Datum pg_regtypeof(PG_FUNCTION_ARGS) { PG_RETURN_OID(get_fn_expr_argtype(fcinfo->flinfo, 0)); }

Re: [HACKERS] Mysterious Bus Error with get_fn_expr_argtype()

2008-09-02 Thread David E. Wheeler
On Sep 2, 2008, at 08:58, David E. Wheeler wrote: On Sep 1, 2008, at 22:31, Brendan Jurd wrote: Oh, another thing: it shouldn't be STRICT. Nulls have perfectly good types. Agreed. Barring any further comments/objections, I'll go ahead and prepare a patch to add this to core. So it will

Re: [HACKERS] Mysterious Bus Error with get_fn_expr_argtype()

2008-09-02 Thread Martijn van Oosterhout
On Tue, Sep 02, 2008 at 08:58:04AM -0700, David E. Wheeler wrote: > >Barring any further comments/objections, I'll go ahead and prepare a > >patch to add this to core. > > So it will return a text representation or an Oid? Hopefully regtype. The function doesn't need changing, but then users can

[HACKERS] What is the use of the CommitFestBlank template?

2008-09-02 Thread Tom Lane
The description of the CommitFestBlank template suggests that it sets up an editable page for you, but AFAICT it does no such thing. I had to manually create all the right sections: http://wiki.postgresql.org/index.php?title=CommitFest:2008-11&diff=2260&oldid=2258 in order to have a page that peop

Re: [HACKERS] WIP patch: Collation support

2008-09-02 Thread Martijn van Oosterhout
On Tue, Sep 02, 2008 at 05:42:13PM +0100, Gregory Stark wrote: > Martijn van Oosterhout <[EMAIL PROTECTED]> writes: > > On Tue, Sep 02, 2008 at 04:46:16PM +0300, Peter Eisentraut wrote: > >> >While it's true POSIX locales don't handle this, other collation > >> >libraries do and we should support t

Re: [HACKERS] Index scan troubles

2008-09-02 Thread Gregory Stark
Markus Wanner <[EMAIL PROTECTED]> writes: > Hi, > > I'm having a hard time using an index scan. So far, I've done quite well with > ScanKeyInit for equality searches. But now I need to scan an index from a > given > starting point. Something like: > >(x, y, z,...) > (const, const, const,...)

Re: [HACKERS] What is d2mdir?

2008-09-02 Thread Devrim GÜNDÜZ
On Tue, 2008-09-02 at 12:47 -0400, Alvaro Herrera wrote: > > Unknown SDATA: [mdash ] > at /usr/share/sgml/docbook/utils-0.6.14/helpers//docbook2man-spec.pl > line 1241, line 11975. > > Please see here: > > http://archives.postgresql.org/message-id/20080821130203.GN4169% > 40alvh.no-ip.org Thank

Re: [HACKERS] Window functions patch v04 for the September commit fest

2008-09-02 Thread Simon Riggs
On Tue, 2008-09-02 at 09:35 -0700, David Fetter wrote: > On Tue, Sep 02, 2008 at 12:42:45PM +0100, Simon Riggs wrote: > > > > On Tue, 2008-09-02 at 03:14 -0400, Tom Lane wrote: > > > David Fetter <[EMAIL PROTECTED]> writes: > > > > On Tue, Sep 02, 2008 at 02:42:25AM -0400, Tom Lane wrote: > > > >

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Tom Lane
"Ryan Bradetich" <[EMAIL PROTECTED]> writes: > On Tue, Sep 2, 2008 at 8:07 AM, Tom Lane <[EMAIL PROTECTED]> wrote: >> It's conceivable that we could make this work if we wanted to dedicate >> an infomask bit to showing whether the tuple needs int or double >> alignment. I don't really think it's w

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Gregory Stark
"Ryan Bradetich" <[EMAIL PROTECTED]> writes: > Hello Greg, > > On Tue, Sep 2, 2008 at 8:30 AM, Gregory Stark <[EMAIL PROTECTED]> wrote: >> >> But I'm confused. You seem to be tweaking the alignment of the data inside >> the >> tuple? After the tuple header? I thought we had only one byte of waste

Re: [HACKERS] WIP patch: Collation support

2008-09-02 Thread Gregory Stark
Martijn van Oosterhout <[EMAIL PROTECTED]> writes: > On Tue, Sep 02, 2008 at 04:46:16PM +0300, Peter Eisentraut wrote: >> >While it's true POSIX locales don't handle this, other collation >> >libraries do and we should support them if the user wants. I think that's backwards. We have to go with

Re: [HACKERS] What is d2mdir?

2008-09-02 Thread Alvaro Herrera
Devrim GÜNDÜZ wrote: > $ make man.tar.gz D2MDIR=/usr/share/sgml/docbook/utils-0.6.14/helpers/ > make -C sgml man > make[1]: Entering directory `/home/devrim/PostgreSQL/pgsql/doc/src/sgml' > onsgmls -D . postgres.sgml | sgmlspl > /usr/share/sgml/docbook/utils-0.6.14/helpers//docbook2man-spec.pl -

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > Tom Lane <[EMAIL PROTECTED]> writes: >> In particular, how would code *reading* the tuple know where the >> data starts? > Uh, at t_hoff, no? Doh, right. Obviously need more caffeine. regards, tom lane -- Sent via pgsql-hac

Re: [HACKERS] Window functions patch v04 for the September commit fest

2008-09-02 Thread David Fetter
On Tue, Sep 02, 2008 at 12:42:45PM +0100, Simon Riggs wrote: > > On Tue, 2008-09-02 at 03:14 -0400, Tom Lane wrote: > > David Fetter <[EMAIL PROTECTED]> writes: > > > On Tue, Sep 02, 2008 at 02:42:25AM -0400, Tom Lane wrote: > > >> It's not like we haven't seen a SQL draft go down in flames > > >>

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Ryan Bradetich
Hello Greg, On Tue, Sep 2, 2008 at 8:30 AM, Gregory Stark <[EMAIL PROTECTED]> wrote: > "Ryan Bradetich" <[EMAIL PROTECTED]> writes: > >>4. If require_max_align = true, use the MAXALIGN macro; otherwise >> use the INTALIGN macro. > > Huh, I didn't think of doing it like that. > > But I'm confus

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Ryan Bradetich
Hello Tom, On Tue, Sep 2, 2008 at 8:07 AM, Tom Lane <[EMAIL PROTECTED]> wrote: > "Ryan Bradetich" <[EMAIL PROTECTED]> writes: >> The patch concept is fairly simple. > >>1. Add a new boolean local variable: require_max_align >> (initialized to false). > > This really can't possibly work, becau

Re: [HACKERS] rmgr hooks and contrib/rmgr_hook

2008-09-02 Thread Simon Riggs
On Tue, 2008-09-02 at 11:39 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > On Tue, 2008-09-02 at 18:30 +0900, ITAGAKI Takahiro wrote: > >> How about adding a new variable "recovery_preload_libaries" like as > >> shared_preload_libraries? Rmgr libs in it are loaded only in sta

Re: [HACKERS] What is d2mdir?

2008-09-02 Thread Devrim GÜNDÜZ
On Tue, 2008-09-02 at 19:07 +0300, Devrim GÜNDÜZ wrote: > > On Tue, 2008-09-02 at 18:40 +0300, Peter Eisentraut wrote: > > The documentation says that Oh, sorry -- I had missed the remaining part of your e-mail. -- Devrim GÜNDÜZ, RHCE devrim~gunduz.org, devrim~PostgreSQL.org, devrim.gunduz~linux

[HACKERS] Index scan troubles

2008-09-02 Thread Markus Wanner
Hi, I'm having a hard time using an index scan. So far, I've done quite well with ScanKeyInit for equality searches. But now I need to scan an index from a given starting point. Something like: (x, y, z,...) > (const, const, const,...) For the equality operatior, I've used get_sort_group_

Re: [HACKERS] What is d2mdir?

2008-09-02 Thread Devrim GÜNDÜZ
On Tue, 2008-09-02 at 18:40 +0300, Peter Eisentraut wrote: > The documentation says that Even though I could not find it, here is an error: $ make man.tar.gz D2MDIR=/usr/share/sgml/docbook/utils-0.6.14/helpers/ make -C sgml man make[1]: Entering directory `/home/devrim/PostgreSQL/pgsql/doc/src/sg

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Ryan Bradetich
Hello Martijn, > You need to arrange testing on an architechture that has strict > alignment reuiqrements. For example i386 doesn't care about alignment > at all and will anything from anywhere, with performance degradation. > > Other architechtures will simply throw exceptions, that's the smoke >

Re: [HACKERS] Mysterious Bus Error with get_fn_expr_argtype()

2008-09-02 Thread David E. Wheeler
On Sep 1, 2008, at 22:31, Brendan Jurd wrote: Oh, another thing: it shouldn't be STRICT. Nulls have perfectly good types. Agreed. Barring any further comments/objections, I'll go ahead and prepare a patch to add this to core. So it will return a text representation or an Oid? Best, David

Re: [HACKERS] WIP patch: Collation support

2008-09-02 Thread Martijn van Oosterhout
On Tue, Sep 02, 2008 at 04:46:16PM +0300, Peter Eisentraut wrote: > >While it's true POSIX locales don't handle this, other collation > >libraries do and we should support them if the user wants. > > Do they handle exactly those two attributes specifically? Can you point > out references? Or do

Re: [HACKERS] What is d2mdir?

2008-09-02 Thread Peter Eisentraut
Tom Lane wrote: Abhijit Menon-Sen <[EMAIL PROTECTED]> writes: At 2008-09-02 15:10:23 +0300, [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] sgml]$ make man As Alvaro noted recently, you need to use "make man D2MDIR=/some/path". I see it's been like that for quite some time, but still it seems p

Re: [HACKERS] rmgr hooks and contrib/rmgr_hook

2008-09-02 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > On Tue, 2008-09-02 at 18:30 +0900, ITAGAKI Takahiro wrote: >> How about adding a new variable "recovery_preload_libaries" like as >> shared_preload_libraries? Rmgr libs in it are loaded only in startup >> process and only if recovery is needed. > Good poin

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Gregory Stark
Tom Lane <[EMAIL PROTECTED]> writes: > "Ryan Bradetich" <[EMAIL PROTECTED]> writes: >> The patch concept is fairly simple. > >>1. Add a new boolean local variable: require_max_align >> (initialized to false). > > This really can't possibly work, because you'd need to propagate > knowledge of

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Gregory Stark
"Ryan Bradetich" <[EMAIL PROTECTED]> writes: >4. If require_max_align = true, use the MAXALIGN macro; otherwise > use the INTALIGN macro. Huh, I didn't think of doing it like that. But I'm confused. You seem to be tweaking the alignment of the data inside the tuple? After the tuple header? I

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-02 Thread Gregory Stark
"Marko Kreen" <[EMAIL PROTECTED]> writes: > Uh. So you want force "proper" units in presentations at the price > of everyday admin operations? Does not seem like a sensible tradeoff. It didn't to anyone else when Peter wrote the current version either, but as the person willing to actually do t

Re: [HACKERS] Question regarding the database page layout.

2008-09-02 Thread Tom Lane
"Ryan Bradetich" <[EMAIL PROTECTED]> writes: > The patch concept is fairly simple. >1. Add a new boolean local variable: require_max_align > (initialized to false). This really can't possibly work, because you'd need to propagate knowledge of the tuple's alignment requirement all over the pl

Re: [HACKERS] Is this really really as designed or defined in some standard

2008-09-02 Thread Pavel Stehule
2008/9/2 Tom Lane <[EMAIL PROTECTED]>: > "Pavel Stehule" <[EMAIL PROTECTED]> writes: >> 2008/9/2 Tom Lane <[EMAIL PROTECTED]>: >>> BTW, there are actually two separate issues here: input parameters and >>> output parameters. After brief thought it seems like we should enforce >>> uniqueness of non

Re: [HACKERS] Is this really really as designed or defined in some standard

2008-09-02 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > 2008/9/2 Tom Lane <[EMAIL PROTECTED]>: >> BTW, there are actually two separate issues here: input parameters and >> output parameters. After brief thought it seems like we should enforce >> uniqueness of non-omitted parameter names for IN parameters (i

Re: [HACKERS] What is d2mdir?

2008-09-02 Thread Tom Lane
Abhijit Menon-Sen <[EMAIL PROTECTED]> writes: > At 2008-09-02 15:10:23 +0300, [EMAIL PROTECTED] wrote: >> >> [EMAIL PROTECTED] sgml]$ make man > As Alvaro noted recently, you need to use "make man D2MDIR=/some/path". I see it's been like that for quite some time, but still it seems pretty bogus.

Re: [HACKERS] Out-of-tree compilation seems broken in HEAD (plpgsql)

2008-09-02 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Marko Kreen escribió: >> I'll try with new cvs checkout. > That'll have the same effect as make maintainer-clean, and should work > equally well. No, it'll work better. The real problem here is that in the CVS-HEAD makefiles, "make maintainer-clean" f

Re: [HACKERS] What is d2mdir?

2008-09-02 Thread Devrim GÜNDÜZ
On Tue, 2008-09-02 at 19:47 +0530, Abhijit Menon-Sen wrote: > > [EMAIL PROTECTED] sgml]$ make man > > As Alvaro noted recently, I probably missed that. > you need to use "make man D2MDIR=/some/path". Thanks :) Cheers. -- Devrim GÜNDÜZ, RHCE devrim~gunduz.org, devrim~PostgreSQL.org, devrim.gu

Re: [HACKERS] What is d2mdir?

2008-09-02 Thread Abhijit Menon-Sen
At 2008-09-02 15:10:23 +0300, [EMAIL PROTECTED] wrote: > > [EMAIL PROTECTED] sgml]$ make man As Alvaro noted recently, you need to use "make man D2MDIR=/some/path". -- ams -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.post

Re: [HACKERS] Out-of-tree compilation seems broken in HEAD (plpgsql)

2008-09-02 Thread Alvaro Herrera
Marko Kreen escribió: > On 9/2/08, Alvaro Herrera <[EMAIL PROTECTED]> wrote: > > Marko Kreen escribió: > > > error: pl_gram.h: No such file or directory > > > > Try running "make maintainer-clean" -- see > > > > > > http://archives.postgresql.org/message-id/20080829162252.GG3983%40alvh.no-ip.or

Re: [HACKERS] Out-of-tree compilation seems broken in HEAD (plpgsql)

2008-09-02 Thread Marko Kreen
On 9/2/08, Alvaro Herrera <[EMAIL PROTECTED]> wrote: > Marko Kreen escribió: > > $ mkdir build > > $ cd build > > $ ../PostgreSQL.dev/configure > > $ make > > [...] > > gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith > > -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing >

Re: [HACKERS] Out-of-tree compilation seems broken in HEAD (plpgsql)

2008-09-02 Thread Alvaro Herrera
Marko Kreen escribió: > $ mkdir build > $ cd build > $ ../PostgreSQL.dev/configure > $ make > [...] > gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith > -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing > -fwrapv -fpic -I/home/marko/src/build/../PostgreSQL.dev/src/pl/plpgsql/src >

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-02 Thread Marko Kreen
On 9/2/08, Peter Eisentraut <[EMAIL PROTECTED]> wrote: > Gregory Stark wrote: > > Peter Eisentraut <[EMAIL PROTECTED]> writes: > > > Marko Kreen wrote: > > > > In the meantime, here is simple patch for case-insensivity. > > > > > > > You might be able to talk me into accepting various unambiguous,

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-02 Thread Marko Kreen
On 9/2/08, Peter Eisentraut <[EMAIL PROTECTED]> wrote: > Marko Kreen wrote: > > In the meantime, here is simple patch for case-insensivity. > > You might be able to talk me into accepting various unambiguous, common > alternative spellings of various units. But for instance allowing MB and Mb > t

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-02 Thread Peter Eisentraut
Gregory Stark wrote: Peter Eisentraut <[EMAIL PROTECTED]> writes: Marko Kreen wrote: In the meantime, here is simple patch for case-insensivity. You might be able to talk me into accepting various unambiguous, common alternative spellings of various units. But for instance allowing MB and Mb

Re: [HACKERS] WIP patch: Collation support

2008-09-02 Thread Peter Eisentraut
Martijn van Oosterhout wrote: On Tue, Sep 02, 2008 at 02:50:47PM +0300, Peter Eisentraut wrote: Radek Strnad wrote: - new collations can be defined with command CREATE COLLATION name> FOR FROM [STRCOLFN ] [ ] [ ] [ LCCOLLATE ] [ LCCTYPE ] How do you plan to make a collation case sensiti

Re: [HACKERS] Page layout footprint

2008-09-02 Thread Heikki Linnakangas
Zdenek Kotala wrote: Hi Heikki, I'm sorry for lack of explanation. It is my fault. Heikki says (on commit fest wiki): I believe I debunked this patch enough already. Apparently there's some compatibility issue between 32-bit and 64-bit Sparcs, but this patch didn't catch that. It

Re: [HACKERS] Window functions patch v04 for the September commit fest

2008-09-02 Thread Heikki Linnakangas
Martijn van Oosterhout wrote: On Tue, Sep 02, 2008 at 10:44:31AM +0100, Simon Riggs wrote: If we only have the combined (brain * time) to get a partial implementation in for this release then I would urge we go for that, rather than wait for perfection - as long as there are no other negative ef

Re: [HACKERS] Window functions patch v04 for the September commit fest

2008-09-02 Thread Heikki Linnakangas
Hitoshi Harada wrote: 2008/9/2 Heikki Linnakangas <[EMAIL PROTECTED]>: In my understanding, the "Window Frame" is defined by clauses such like "ROWS BETWEEN ... ", "RANGE BETWEEN ... " or so, contrast to "Window Partition" defined by "PARTITION BY" clause. A frame slides within a partition or the

[HACKERS] Page layout footprint

2008-09-02 Thread Zdenek Kotala
Hi Heikki, I'm sorry for lack of explanation. It is my fault. Heikki says (on commit fest wiki): I believe I debunked this patch enough already. Apparently there's some compatibility issue between 32-bit and 64-bit Sparcs, but this patch didn't catch that. It doesn't seem like thi

Re: [HACKERS] posix advises ...

2008-09-02 Thread Greg Smith
On Sun, 31 Aug 2008, Alvaro Herrera wrote: Greg Smith wrote: This patch does need a bit of general care in a couple of areas. The reviewing game plan I'm working through goes like this: Did this review effort go anywhere? Haven't made much progress--all my spare time for work like this la

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-02 Thread Gregory Stark
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Marko Kreen wrote: >> In the meantime, here is simple patch for case-insensivity. > > You might be able to talk me into accepting various unambiguous, common > alternative spellings of various units. But for instance allowing MB and Mb > to > mean t

[HACKERS] What is d2mdir?

2008-09-02 Thread Devrim GÜNDÜZ
$ grep -i D2MDIR * -R doc/src/sgml/Makefile:D2MSCRIPT= $(D2MDIR)/docbook2man-spec.pl I could not find anything in the code related to this. I am trying to create man pages in -HEAD, and getting an error: [EMAIL PROTECTED] sgml]$ make man onsgmls -D . postgres.sgml | sgmlspl /docbook2man-spec.pl

Re: [HACKERS] Window functions patch v04 for the September commit fest

2008-09-02 Thread Hitoshi Harada
2008/9/2 Simon Riggs <[EMAIL PROTECTED]>: > If you've done all of that, then I'm impressed. Well done. > > Few general comments > > * The docs talk about "windowing functions", yet you talk about "window > functions" here. I think the latter is correct, but whichever we choose > we should be consis

Re: [HACKERS] WIP patch: Collation support

2008-09-02 Thread Radek Strnad
I think at least case sensitivity can be done by comparing two strings converted to upper case with toupper() function. Regards Radek Strnad > > On Tue, Sep 2, 2008 at 2:00 PM, Martijn van Oosterhout <[EMAIL > PROTECTED]>wrote: > >> On Tue, Sep 02, 2008 at 02:50:47PM +0300, Peter Eisentraut wro

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-02 Thread Peter Eisentraut
Marko Kreen wrote: In the meantime, here is simple patch for case-insensivity. You might be able to talk me into accepting various unambiguous, common alternative spellings of various units. But for instance allowing MB and Mb to mean the same thing is insane. -- Sent via pgsql-hackers mai

Re: [HACKERS] WIP patch: Collation support

2008-09-02 Thread Martijn van Oosterhout
On Tue, Sep 02, 2008 at 02:50:47PM +0300, Peter Eisentraut wrote: > Radek Strnad wrote: > >- new collations can be defined with command CREATE COLLATION >name> FOR FROM > >[STRCOLFN ] > >[ ] [ ] [ LCCOLLATE ] > >[ LCCTYPE ] > > How do you plan to make a collation case sensitive or accent

Re: [HACKERS] TODO item: Implement Boyer-Moore searching (First time hacker)

2008-09-02 Thread Peter Eisentraut
David Rowley wrote: Reference: Bruce Momjian writes: -> http://archives.postgresql.org/pgsql-committers/2007-09/msg00402.php Other references: Boyer Moore?? -> http://www.cs.utexas.edu/users/moore/best-ideas/string-searching/fstrpos-example.html I look forward to receiving feedback on this.

Re: [HACKERS] WIP patch: Collation support

2008-09-02 Thread Peter Eisentraut
Radek Strnad wrote: - new collations can be defined with command CREATE COLLATION name> FOR FROM [STRCOLFN ] [ ] [ ] [ LCCOLLATE ] [ LCCTYPE ] How do you plan to make a collation case sensitive or accent sensitive? I have previously commented that this is not a realistic view on how

  1   2   >