[HACKERS] Lock conflict behavior?

2008-12-22 Thread Tatsuo Ishii
Hi, I'm wondering if following behavior of PostgreSQL regarding lock conflict is an expected one. Here's a scenario: Session A: BEGIN; SELECT * FROM pg_class limit 1; -- acquires access share lock Session B: BEGIN; ALTER TABLE pg_class ; -- waits for

Re: [HACKERS] a small proposal for avoiding foot-shooting

2008-12-22 Thread Albe Laurenz
Tom Lane wrote: I propose that this behaviour be changed such that 'terse' is ignored for all log messages of FATAL or PANIC severity. [ on the strength of a single example ] [...] It seems like it might be better to rephrase error messages to ensure that anything really critical is

Re: [HACKERS] a small proposal for avoiding foot-shooting

2008-12-22 Thread Andrew Gierth
Albe == Albe Laurenz laurenz.a...@wien.gv.at writes: Albe I *guess* it is the problem addressed by Albe http://archives.postgresql.org/pgsql-committers/2008-04/msg00275.php Albe and Albe http://archives.postgresql.org/pgsql-committers/2008-04/msg00358.php No; the problem is with stop

Re: [HACKERS] Lock conflict behavior?

2008-12-22 Thread Tom Lane
Tatsuo Ishii is...@postgresql.org writes: I'm wondering if following behavior of PostgreSQL regarding lock conflict is an expected one. Here's a scenario: Session A: BEGIN; SELECT * FROM pg_class limit 1; -- acquires access share lock Session B: BEGIN; ALTER

Re: [HACKERS] WIP: Automatic view update rules

2008-12-22 Thread Bernd Helmle
--On Mittwoch, November 26, 2008 10:54:01 +0100 Bernd Helmle maili...@oopsware.de wrote: --On Dienstag, November 25, 2008 23:43:02 -0500 Robert Haas robertmh...@gmail.com wrote: Do you intend to submit an updated version of this patch for this commitfest? I'll do asap, i've updated the

Re: [HACKERS] Lock conflict behavior?

2008-12-22 Thread Jan Urbański
Tom Lane wrote: Tatsuo Ishii is...@postgresql.org writes: I'm wondering if following behavior of PostgreSQL regarding lock conflict is an expected one. Here's a scenario: Session A: BEGIN; SELECT * FROM pg_class limit 1; -- acquires access share lock Session B: BEGIN;

Re: [HACKERS] Proposed Patch to Improve Performance of Multi-Batch Hash Join for Skewed Data Sets

2008-12-22 Thread Joshua Tolley
On Sun, Dec 21, 2008 at 10:25:59PM -0500, Robert Haas wrote: [Some performance testing.] I (finally!) have a chance to post my performance testing results... my apologies for the really long delay. Excuses omitted Unfortunately I'm not seeing wonderful speedups with the particular queries I did

Re: [HACKERS] reloptions and toast tables

2008-12-22 Thread Jaime Casanova
On 12/20/08, Alvaro Herrera alvhe...@commandprompt.com wrote: ALTER TABLE foo SET (TOAST autovacuum_enabled = false); ... ALTER TABLE foo SET TOAST (autovacuum_enabled = false); i will be happy with any of this options (actually i prefer the second one but don't have a strong argument against

[HACKERS] encoding cleanups in cvs repo

2008-12-22 Thread Magnus Hagander
I have cleaned up a couple of badly broken encodings in cvs commit messages in: src/backend/utils/error/Attic/exc.c,v per discussion with Alvaro, by simply editing the RCS file directly in the cvs repository. Only the commit message was changed (broken character removed) Should have no effect.

Re: [HACKERS] generic reloptions improvement

2008-12-22 Thread Alvaro Herrera
ITAGAKI Takahiro wrote: Alvaro Herrera alvhe...@commandprompt.com wrote: Here's a patch for improving the general reloptions mechanism. What this patch does is add a table-based option parser. This allows adding new options very easily, and stops the business of having to pass the

Re: [HACKERS] DTrace probes patch

2008-12-22 Thread Robert Lor
Tom Lane wrote: Robert Lor robert@sun.com writes: Tom Lane wrote: I agree. If the probe is meant to track only *some* WAL writes then it needs to be named something less generic than TRACE_POSTGRESQL_WAL_BUFFER_WRITE. How about change it to

[HACKERS] Some semantic details of the window-function spec

2008-12-22 Thread Tom Lane
After a couple of hours reading the SQL:2008 spec, I've come to some conclusions about the semantics that are demanded for window functions. Anyone want to to check my work? * If window functions are used together with aggregates or grouping, the grouping and regular aggregation happens first,

[HACKERS] incoherent view of serializable transactions

2008-12-22 Thread Kevin Grittner
As I've understood limitations of the PostgreSQL implementation of SERIALIZABLE transactions, at least the only example given in the documentation, revolve around a rather unlikely situation: Given concurrent transactions T1 and T2 and non-overlapping sets of data A and B, T1 reads data

Re: [HACKERS] incoherent view of serializable transactions

2008-12-22 Thread Martijn van Oosterhout
On Mon, Dec 22, 2008 at 11:00:53AM -0600, Kevin Grittner wrote: As I've understood limitations of the PostgreSQL implementation of SERIALIZABLE transactions, at least the only example given in the documentation, revolve around a rather unlikely situation: Given concurrent transactions T1

Re: [HACKERS] incoherent view of serializable transactions

2008-12-22 Thread Kevin Grittner
Martijn van Oosterhout klep...@svana.org wrote: On Mon, Dec 22, 2008 at 11:00:53AM -0600, Kevin Grittner wrote: As I've understood limitations of the PostgreSQL implementation of SERIALIZABLE transactions, at least the only example given in the documentation, revolve around a rather unlikely

Re: [HACKERS] Visibility map and freezing

2008-12-22 Thread Heikki Linnakangas
Heikki Linnakangas wrote: Peter Eisentraut wrote: Heikki Linnakangas wrote: I think we need a threshold similar to autovacuum_freeze_max_age for manual vacuums as well: vacuum_freeze_max_age. If you run VACUUM, and relfrozenxid is older than vacuum_freeze_max_age, the visibility map is

Re: [HACKERS] Some semantic details of the window-function spec

2008-12-22 Thread Hitoshi Harada
2008/12/23 Tom Lane t...@sss.pgh.pa.us: * Unlike aggregates, there doesn't seem to be any concept of a window function being attached to an outer-level query --- in fact 6.10 rule 4 says that a window function's argument can't contain outer references at all. That seems excessively strong,

Re: [HACKERS] [PATCHES] updated hash functions for postgresql v1

2008-12-22 Thread Kenneth Marshall
Dear PostgreSQL developers, I am re-sending this to keep this last change to the internal hash function on the radar. Ken Sorry about the delay for this update to the new hash index implementation. I was trying to get the WAL logging in place and forgot to post the actual patch. The

Re: [HACKERS] [PATCHES] updated hash functions for postgresql v1

2008-12-22 Thread Alvaro Herrera
Kenneth Marshall wrote: Dear PostgreSQL developers, I am re-sending this to keep this last change to the internal hash function on the radar. Please add it to the commitfest wiki page, http://wiki.postgresql.org/wiki/CommitFest_2008-11 Thanks -- Alvaro Herrera

Re: [HACKERS] affected rows count

2008-12-22 Thread Bruce Momjian
Grzegorz Jaskiewicz wrote: Hey folks, It doesn't stop to bug me, that postgres will return 0 number of affected rows, if table is triggered. Now, question is - is this fixable, but no one cares, or is it some sort of a design/implementation flaw and we just have to live with it. Would

Re: [HACKERS] affected rows count

2008-12-22 Thread Jeff Davis
On Mon, 2008-12-22 at 15:07 -0500, Bruce Momjian wrote: Grzegorz Jaskiewicz wrote: Hey folks, It doesn't stop to bug me, that postgres will return 0 number of affected rows, if table is triggered. Now, question is - is this fixable, but no one cares, or is it some sort of a

[HACKERS] HAVE_FSEEKO for WIN32

2008-12-22 Thread Andrew Dunstan
Cleaning up the parallel restore patch I came across a question I might have asked before, but one which in any case I worked around: Why do we carefully define fseeko() for WIN32 but then not define HAVE_FSEEKO, which makes doing the former pretty much pointless? cheers andrew -- Sent

Re: [HACKERS] affected rows count

2008-12-22 Thread Grzegorz Jaskiewicz
On 2008-12-22, at 21:07, Bruce Momjian wrote: Grzegorz Jaskiewicz wrote: Hey folks, It doesn't stop to bug me, that postgres will return 0 number of affected rows, if table is triggered. Now, question is - is this fixable, but no one cares, or is it some sort of a design/implementation flaw

Re: [HACKERS] affected rows count

2008-12-22 Thread Dawid Kuroczko
On Mon, Dec 22, 2008 at 9:07 PM, Bruce Momjian br...@momjian.us wrote: Grzegorz Jaskiewicz wrote: Hey folks, It doesn't stop to bug me, that postgres will return 0 number of affected rows, if table is triggered. Now, question is - is this fixable, but no one cares, or is it some sort of a

Re: [HACKERS] affected rows count

2008-12-22 Thread Grzegorz Jaskiewicz
On 2008-12-22, at 22:35, Dawid Kuroczko wrote: atlantis= CREATE OR REPLACE FUNCTION foo_trigger() RETURNS trigger AS $$ BEGIN UPDATE bar SET t=NEW.t WHERE i=NEW.i; RETURN NULL; END; $$ LANGUAGE plpgsql; atlantis= CREATE TRIGGER foo_update BEFORE UPDATE ON foo FOR EACH ROW EXECUTE PROCEDURE

Re: [HACKERS] HAVE_FSEEKO for WIN32

2008-12-22 Thread Bruce Momjian
Andrew Dunstan wrote: Cleaning up the parallel restore patch I came across a question I might have asked before, but one which in any case I worked around: Why do we carefully define fseeko() for WIN32 but then not define HAVE_FSEEKO, which makes doing the former pretty much pointless?

Re: [HACKERS] contrib/pg_stat_statements 1212

2008-12-22 Thread Alex Hunsaker
On Mon, Dec 22, 2008 at 00:44, ITAGAKI Takahiro itagaki.takah...@oss.ntt.co.jp wrote: Alex Hunsaker bada...@gmail.com wrote: A few comments: Is there a reason you add sourceText to QueryDesc? AFAICT you can do ActivePortal-sourceText and it will always be populated correctly. That's for

Re: [HACKERS] Lock conflict behavior?

2008-12-22 Thread Jeff Davis
On Mon, 2008-12-22 at 17:14 +0900, Tatsuo Ishii wrote: Also, it seems that an attacker could do a denial service attack if he could open session A and B, since other users on session C or following sessions will be blocked. LOCK TABLE checks the permissions before attempting to acquire the

Re: [HACKERS] incoherent view of serializable transactions

2008-12-22 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: At this point, SERIALIZABLE transactions appear to have worked, with receipt 3 happening before the update of deposit_date; however, there was a window of time when the update to deposit_date was visible and receipt 3 was not. This

Re: [HACKERS] encoding cleanups in cvs repo

2008-12-22 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: I have cleaned up a couple of badly broken encodings in cvs commit messages in: src/backend/utils/error/Attic/exc.c,v Out of curiosity ... what problems exactly? I just looked through my last complete dump of CVS log history and didn't see anything

Re: [HACKERS] [PATCHES] Infrastructure changes for recovery (v8)

2008-12-22 Thread Fujii Masao
On Tue, Dec 23, 2008 at 5:18 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Simon Riggs wrote: On Wed, 2008-12-17 at 23:32 -0300, Alvaro Herrera wrote: Simon Riggs escribió: Please let me know how I can make the reviewer's job easier. Diagrams, writeups, whatever.

Re: [HACKERS] Some semantic details of the window-function spec

2008-12-22 Thread Tom Lane
Hitoshi Harada umi.tan...@gmail.com writes: 2008/12/23 Tom Lane t...@sss.pgh.pa.us: * Unlike aggregates, there doesn't seem to be any concept of a window function being attached to an outer-level query --- in fact 6.10 rule 4 says that a window function's argument can't contain outer

Re: [HACKERS] incoherent view of serializable transactions

2008-12-22 Thread Emmanuel Cecchet
Kevin, If you want to know how to build SERIALIZABLE with a database that provides SI (Snapshot Isolation), read http://portal.acm.org/citation.cfm?doid=1376616.137669 Note that in practice, READ COMMITTED is the most largely used isolation level and its limitations are relatively well

Re: [HACKERS] Visibility map and freezing

2008-12-22 Thread Fujii Masao
On Tue, Dec 23, 2008 at 4:24 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Heikki Linnakangas wrote: Peter Eisentraut wrote: Heikki Linnakangas wrote: I think we need a threshold similar to autovacuum_freeze_max_age for manual vacuums as well: vacuum_freeze_max_age. If

Re: [HACKERS] Sync Rep: Second thoughts

2008-12-22 Thread Emmanuel Cecchet
Hi Markus, I'm not quite sure what you mean by certification protocol, there's no such thing in Postgres-R (as proposed by Kemme). Although, I remember having heard that term in the context of F. Pedone's work. Can you point me to some paper explaining this certification protocol? What