it seems to work
fine (and eliminates the warnings). I left it with int32 in my version
of the patch because I thought you may have some reason for using it.
Regards,
Jeff Davis
btree-gin.20081228.patch.gz
Description: GNU Zip compressed data
--
Sent via pgsql-hackers mailing list
2008/12/29 Tom Lane :
> The core window-functions patch is now committed and ready for wider
> testing. However, there are a number of unfinished items, at least
> some of which I'd like to see addressed before 8.4 release. In rough
> order of importance:
>
> * Support creation of user-defined wi
Hi,
On Tue, Nov 18, 2008 at 12:39 AM, Simon Riggs wrote:
>
> On Mon, 2008-11-17 at 16:18 +0200, Heikki Linnakangas wrote:
>> Simon Riggs wrote:
>> > @@ -3845,6 +3850,52 @@ sigusr1_handler(SIGNAL_ARGS)
>> >
>> > PG_SETMASK(&BlockSig);
>> >
>> > + if (CheckPostmasterSignal(PMSIGNAL_RE
2008/12/29 Tom Lane :
> ... and it's committed. Congratulations!
>
>regards, tom lane
>
Great! I am really glad I can contribute PostgreSQL project by such a
big improvement.
And I really thank all the hackers, without all the helps by you it
wouldn't be done, obviously.
Tom Lane wrote:
> Alvaro Herrera writes:
> > I'm intending to have a new routine which would reserve a value at
> > runtime. This value would be later be passed by the AM to create new
> > options on the table.
>
> What do you mean by "at runtime"? Surely the value would have to remain
> stabl
On Sun, 2008-12-28 at 18:39 -0500, Tom Lane wrote:
> > Err, to which (RPM) package should the dummy_fdw.so and
> > postgresql_fdw.so go? -server, or the regular package?
>
> -server, I'd say. They're of no value without the server installed,
> for sure.
Thanks Tom.
Regards,
--
Devrim GÜNDÜZ, R
Devrim =?ISO-8859-1?Q?G=DCND=DCZ?= writes:
> Err, to which (RPM) package should the dummy_fdw.so and
> postgresql_fdw.so go? -server, or the regular package?
-server, I'd say. They're of no value without the server installed,
for sure.
regards, tom lane
--
Sent via pgs
Hi,
On Fri, 2008-12-19 at 16:25 +, Peter Eisentraut wrote:
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/foreign/dummy/Makefile?rev=1.1&content-type=text/x-cvsweb-markup)
> dummy_fdw.c (r1.1)
>
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/foreign/postg
"Andreas 'ads' Scherbaum" writes:
> the march 2008 commitfest added a patch[1] with extended information for
> \l+. The may 2008 commitfest added a patch[2] which reformats the
> permission output in \z. I like the new output in \z, but the \l+
> output is still missing this feature. The attached
> I thought about this, but upon due reflection I think it's the wrong
> approach. Raising work_mem is a pretty common tuning step - it's 4MB
> even on my small OLTP systems, and in a data-warehousing environment
> where this optimization will bring the most benefit, it could easily
> be higher.
"David Rowley" writes:
> Unsure how difficult it is, maybe another one for a TODO, 8.4 or 8.5 I'm not
> sure:
> * Minimise sorts in a query such as:
I'm not tremendously excited about improving that situation. As the
code stands, the user can control what happens by ordering the WINDOW
clause ap
On Sun, Dec 28, 2008 at 9:29 AM, Bernd Helmle wrote:
>
> Yes, it seems we have to check for target lists having negative attnums in
> checkTree(). Another solution would be to simply ignore those columns
> (extract them from the target list and include all updatable columns
> only).
>
i would say
Tom Lane Wrote:
> The core window-functions patch is now committed and ready for wider
> testing. However, there are a number of unfinished items, at least
> some of which I'd like to see addressed before 8.4 release. In rough
> order of importance:
>
> * Support creation of user-defined window
It hadn't occurred to me to try the ecpg tests before committing the
window functions patch :-(. It looks like those grammar additions have
resulted in whitespace changes in a lot of the test outputs. Would you
confirm that there's nothing seriously wrong and update the output
files?
It strikes
The core window-functions patch is now committed and ready for wider
testing. However, there are a number of unfinished items, at least
some of which I'd like to see addressed before 8.4 release. In rough
order of importance:
* Support creation of user-defined window functions. I think this is
... and it's committed. Congratulations!
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
"Hitoshi Harada" writes:
> 2008/12/28 David Rowley :
>> I've started running my test queries that I used when reviewing the patch.
>> The following crashes the backend:
> It seems that parseCheckWindowFuncs() doesn't check CTE case whereas
> parseCheckAggregates() checks it, including check of wi
Hitoshi Harada wrote:
> > WITH RECURSIVE bom AS (
> > SELECT parentpart,childpart,quantity,ROW_NUMBER() OVER (ORDER BY
> > parentpart DESC) rn
> > FROM billofmaterials
> > WHERE parentpart = 'KITCHEN'
> > UNION ALL
> > SELECT b.parentpart,b.childpart,b.quantity,ROW_NUMBER() OVER (ORDER BY
> >
"Hitoshi Harada" writes:
> I ran the patch witouht any errors. Though it's trivial, I noticed
> window_gettupleslot has to be fixed a bit.
Yeah, it could uselessly spool the partition before failing. I think
it had been that way before and I left it alone, but changing it is
good --- diff includ
"David Rowley" writes:
> I've started running my test queries that I used when reviewing the patch.
> The following crashes the backend:
Fixed, thanks. (begin_partition was failing to reset spooled_rows when
falling out early because of empty outerplan; which could only cause an
issue if the out
2008/12/28 David Rowley :
> Tom Lane Wrote:
>> I've spent quite a bit of time reviewing the window functions patch,
>> and I think it is now ready to commit, other than the documentation
>> (which I've not looked at yet at all). Attached is my current patch
>> against HEAD, sans documentation. Th
Tom Lane Wrote:
> I've spent quite a bit of time reviewing the window functions patch,
> and I think it is now ready to commit, other than the documentation
> (which I've not looked at yet at all). Attached is my current patch
> against HEAD, sans documentation. This incorporates the recently
> d
> On Mon, Dec 22, 2008 at 8:53 AM, Bernd Helmle
> wrote:
>> --On Mittwoch, November 26, 2008 10:54:01 +0100 Bernd Helmle
>> wrote:
>>
>> Okay, i've finally managed to create an updated version with (hopefully)
>> all
>> issues mentioned by Robert adressed.
>>
>
> Hi Bernd,
>
> 1) i found a crash
>> 2) Another less important bug, the WITH CHECK OPTION is accepted even
>> when that functionality is not implemented.
>>
>> updatable_views=# create or replace view v2 as select * from foo where
>> id < 10 with check option;
>> NOTICE: CREATE VIEW will create implicit INSERT/UPDATE/DELETE rules
> I totally agree that 10,000 MCVs changes things. Ideally, these 10,000
> MCVs should be kept in memory because they will join with the most
> tuples. However, the size of the MCV hash table (as you point out) can
> be bigger than work_mem *by itself* not even considering the tuples in
> the tab
25 matches
Mail list logo
