Re: [HACKERS] One less footgun: deprecating pg_dump -d

2009-03-10 Thread David Fetter
On Mon, Mar 09, 2009 at 09:02:01PM +0100, Magnus Hagander wrote: Andrew Dunstan wrote: Tom Lane wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: Magnus Hagander mag...@hagander.net wrote: but maybe it's better to use -i and -I, and thus change them both? That's

Re: [HACKERS] Prepping to break every past release...

2009-03-10 Thread Simon Riggs
On Wed, 2009-03-04 at 12:32 -0800, Joshua D. Drake wrote: Something that continues to grind my teeth about our software is that we are horribly inconsistent with our system catalogs. Now I am fully and 100% aware that changing this will break things in user land but I want to do it anyway.

Re: [HACKERS] Sampling Profler for Postgres

2009-03-10 Thread Simon Riggs
On Mon, 2009-03-09 at 21:57 -0400, Tom Lane wrote: ITAGAKI Takahiro itagaki.takah...@oss.ntt.co.jp writes: For resource-based profilers, we have DTrace probes[1] and continue to extend them[2], but unfortunately DTrace only works on Solaris and limited platforms. FWIW, the systemtap

Re: [HACKERS] One less footgun: deprecating pg_dump -d

2009-03-10 Thread Simon Riggs
On Mon, 2009-03-09 at 21:02 +0100, Magnus Hagander wrote: Andrew Dunstan wrote: Tom Lane wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: Magnus Hagander mag...@hagander.net wrote: but maybe it's better to use -i and -I, and thus change them both?

Re: [HACKERS] Prepping to break every past release...

2009-03-10 Thread Simon Riggs
On Thu, 2009-03-05 at 01:27 +, Andrew Gierth wrote: Now, of course, counting the upcoming 8.4 there have been three (and a bit - the original design predates 8.1, though it did anticipate some 8.1 features) new releases against which the original concept can be tested. And, guess what,

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Hannu Krosing
On Tue, 2009-03-10 at 09:56 +0900, KaiGai Kohei wrote: Joshua D. Drake wrote: ... Is there any possibility of having it be enabled at compile time? The default would be know but those distributions that would like to make use of it could? It was the design a half year ago, but Bruce

Re: [HACKERS] postgresql.conf: patch to have ParseConfigFile report all parsing errors, then bail

2009-03-10 Thread Simon Riggs
On Sun, 2009-03-08 at 16:27 -0700, Selena Deckelmann wrote: ParseConfigFile currently exits on the first parsing error. Changed guc_file.l to report all parsing errors before exiting: * Moved parse_error: block inside while() loop * Removed cleanup_exit: and associated 'goto' * Added

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread KaiGai Kohei
Hannu Krosing wrote: On Tue, 2009-03-10 at 09:56 +0900, KaiGai Kohei wrote: Joshua D. Drake wrote: ... Is there any possibility of having it be enabled at compile time? The default would be know but those distributions that would like to make use of it could? It was the design a half year

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Heikki Linnakangas
Stephen Frost wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: KaiGai Kohei wrote: As I promised last week, SE-PostgreSQL patches are revised here: The patch adds permission checks to SET/SHOW. If that's useful functionality, it

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread KaiGai Kohei
Heikki Linnakangas wrote: This seems to be a recurring theme with this patch. We stripped row-level permissions, now we have SET/SHOW and the function installation permissions. And the read/write file permissions. To make progress, we need to consider each new feature like that separately, as

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Gregory Stark
KaiGai Kohei kai...@kaigai.gr.jp writes: Heikki Linnakangas wrote: If we drop the goal of trying to restrict what a superuser can do, is the patch still useful? I want to keep permission checks on files specified by users, because the superuser permission affects very wide scope, and all or

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-03-10 Thread Heikki Linnakangas
patches to be rebased to HEAD again (readahead-20090310.patch). The other (addShBufCheck-20090120.patch) is not changed. Comment: we might reach consistent recovery state *before* redoing the safe starting point, because readahead slightly delays the actual redo. Is this safe? No. If you haven't

Re: [HACKERS] Sampling Profler for Postgres

2009-03-10 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On Mon, 2009-03-09 at 21:57 -0400, Tom Lane wrote: I'm not at all convinced that we should be putting effort into a homegrown, partial substitute for DTrace. I was, but I'm not anymore. Do you think we will be able to enable this in builds for 8.4?

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: If we drop the goal of trying to restrict what a superuser can do, is the patch still useful? One idea is to add a single is superuser permission to sepgsql. The agreement back in January was that what we'd consider for 8.4 is a

Re: [HACKERS] Prepping to break every past release...

2009-03-10 Thread Andrew Gierth
Simon == Simon Riggs si...@2ndquadrant.com writes: Now, of course, counting the upcoming 8.4 there have been three (and a bit - the original design predates 8.1, though it did anticipate some 8.1 features) new releases against which the original concept can be tested. And, guess what,

Re: [HACKERS] Prepping to break every past release...

2009-03-10 Thread David Fetter
On Tue, Mar 10, 2009 at 08:46:28AM +, Simon Riggs wrote: On Thu, 2009-03-05 at 01:27 +, Andrew Gierth wrote: Now, of course, counting the upcoming 8.4 there have been three (and a bit - the original design predates 8.1, though it did anticipate some 8.1 features) new releases

Re: [HACKERS] postgresql.conf: patch to have ParseConfigFile report all parsing errors, then bail

2009-03-10 Thread Selena Deckelmann
Hi! Simon Riggs wrote: On Sun, 2009-03-08 at 16:27 -0700, Selena Deckelmann wrote: ParseConfigFile currently exits on the first parsing error. Changed guc_file.l to report all parsing errors before exiting: * Moved parse_error: block inside while() loop * Removed cleanup_exit: and associated

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread David Fetter
On Tue, Mar 10, 2009 at 08:02:05PM +0900, KaiGai Kohei wrote: Please wait for a while. With all due respect to your hard work, waiting for this patch, even one more hour, is exactly what we shouldn't do for 8.4. Sad as it is, even if this patch were causing no controversy in its design, it

Re: [HACKERS] Prepping to break every past release...

2009-03-10 Thread Simon Riggs
On Tue, 2009-03-10 at 07:28 -0700, David Fetter wrote: Would it be better to publish them as an external project? It's been an external project, newsysviews, since before 8.1 came out. I think it's time to bring it in from the cold. Call the new schema pg_sysviews, plop it in there, and

Re: [HACKERS] postgresql.conf: patch to have ParseConfigFile report all parsing errors, then bail

2009-03-10 Thread Simon Riggs
On Tue, 2009-03-10 at 07:30 -0700, Selena Deckelmann wrote: Is it possible to check for parameters that have been changed, yet will not be applied at reload? This was already implemented! :) For example: LOG: attempted change of parameter shared_buffers ignored DETAIL: This

Re: [HACKERS] postgresql.conf: patch to have ParseConfigFile report all parsing errors, then bail

2009-03-10 Thread Selena Deckelmann
Simon Riggs wrote: On Tue, 2009-03-10 at 07:30 -0700, Selena Deckelmann wrote: A thing that could be added, however, is reporting of all invalid (as opposed to valid, but requires a restart to apply) parameters before exiting. This change requires refactoring ProcessConfigFile() more

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Joshua D. Drake
On Mon, 2009-03-09 at 20:55 -0400, Tom Lane wrote: Joshua D. Drake j...@commandprompt.com writes: I know we are a little uncomfortable here but KaiGai-San (forgive me if I type that wrong) has proven to be a contributor in his own right, Perhaps it would help you calibrate the problem if

Re: [HACKERS] Prepping to break every past release...

2009-03-10 Thread Joshua D. Drake
On Tue, 2009-03-10 at 15:02 +, Simon Riggs wrote: On Tue, 2009-03-10 at 07:28 -0700, David Fetter wrote: Would it be better to publish them as an external project? It's been an external project, newsysviews, since before 8.1 came out. I think it's time to bring it in from the

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Tom Lane
Joshua D. Drake j...@commandprompt.com writes: I think you misunderstand me. I have watched this thread very closely because it has specific strategic interest. For the record: * This patch does scare me * With great risk comes great reward ... or great failure. My key concern is that we

Re: [HACKERS] Prepping to break every past release...

2009-03-10 Thread Andrew Gierth
Joshua == Joshua D Drake j...@commandprompt.com writes: On Tue, 2009-03-10 at 15:02 +, Simon Riggs wrote: Yeh Andrew said. That I never noticed in the last 3+ years makes me think there's not many people using it... The fact that it never got beyond an early incomplete alpha version

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Joshua D. Drake
On Tue, 2009-03-10 at 13:08 -0400, Tom Lane wrote: Joshua D. Drake j...@commandprompt.com writes: I think you misunderstand me. I have watched this thread very closely because it has specific strategic interest. For the record: * This patch does scare me * With great risk comes great

Re: [HACKERS] Prepping to break every past release...

2009-03-10 Thread Dave Page
On Tue, Mar 10, 2009 at 5:23 PM, Andrew Gierth and...@tao11.riddles.org.uk wrote: Other than some experiments in getting it to load on 8.2, there hasn't been any serious work done on it since May 2005, which is when it was presented (and shot down) on -hackers. If memory serves (and it may

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Alvaro Herrera
Joshua D. Drake escribió: Yes but I am also offering an opportunity for others to show up. Which denying the patch does not do. If we provide SE support (even with marking it experimental), I would wager that some Linux distributions would begin to test it themselves which would allow us in

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Joshua D. Drake
On Tue, 2009-03-10 at 14:47 -0300, Alvaro Herrera wrote: Joshua D. Drake escribió: Yes but I am also offering an opportunity for others to show up. Which denying the patch does not do. If we provide SE support (even with marking it experimental), I would wager that some Linux

Re: [HACKERS] problem inserting in GIN index

2009-03-10 Thread Teodor Sigaev
A guy just reported on pgsql-es-ayuda that he's getting ERROR: item pointer (543108,2) already exists It will be fine to get test case... Apparently this message only occurs on GIN, in insertItemPointer Reading that routine I

Re: [HACKERS] problem inserting in GIN index

2009-03-10 Thread Teodor Sigaev
Apparently there's a crash involved ... Are other indexes on that table broken? ( Just count(*) with only index scan enabled ) -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Tom Lane
Joshua D. Drake j...@commandprompt.com writes: On Tue, 2009-03-10 at 14:47 -0300, Alvaro Herrera wrote: It was said upthread that SEPostgres is already packaged for Fedora. Yes for but not by, AFAIK it is not actually included with Fedora. Included with Fedora is an extremely loose concept.

Re: [HACKERS] problem inserting in GIN index

2009-03-10 Thread Emanuel Calvo Franco
2009/3/10 Teodor Sigaev teo...@sigaev.ru: Apparently there's a crash involved ... Are other indexes on that table broken? ( Just count(*) with only index scan enabled ) -- Teodor Sigaev                                   E-mail: teo...@sigaev.ru                                                

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Ron Mayer
Tom Lane wrote: Joshua D. Drake j...@commandprompt.com writes: I know we are a little uncomfortable here but KaiGai-San (forgive me if I type that wrong) has proven to be a contributor in his own right, Not to put too fine a point on it, but: no, he hasn't. Show me one significant patch

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Devrim GÜNDÜZ
On Tue, 2009-03-10 at 10:49 -0700, Joshua D. Drake wrote: It was said upthread that SEPostgres is already packaged for Fedora. Yes for but not by, AFAIK it is not actually included with Fedora. It is, with the names sepostgresql*. Essentially it is packaged like the PGSQLRPMS are

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Joshua D. Drake
On Tue, 2009-03-10 at 14:14 -0400, Tom Lane wrote: Joshua D. Drake j...@commandprompt.com writes: On Tue, 2009-03-10 at 14:47 -0300, Alvaro Herrera wrote: It was said upthread that SEPostgres is already packaged for Fedora. You're just putting the hard decision onto packagers, who have no

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Tom Lane
Joshua D. Drake j...@commandprompt.com writes: On Tue, 2009-03-10 at 14:14 -0400, Tom Lane wrote: You're just putting the hard decision onto packagers, who have no more knowledge than you do about what their users want, and (probably) considerably less understanding of the benefits/risks of

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Joshua D. Drake
On Tue, 2009-03-10 at 14:59 -0400, Tom Lane wrote: Joshua D. Drake j...@commandprompt.com writes: On Tue, 2009-03-10 at 14:14 -0400, Tom Lane wrote: You're just putting the hard decision onto packagers, who have no more knowledge than you do about what their users want, and (probably)

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Devrim GÜNDÜZ
On Tue, 2009-03-10 at 14:59 -0400, Tom Lane wrote: Which is exactly why we have two types of RPMS, --integer-datetimes and not. Maybe Devrim is doing that, but nobody else is. It is only available *if* yum repo conf file is specially configured and if the distro is Fedora 10 and RHEL

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Tom Lane
Ron Mayer rm...@cheapcomplexdevices.com writes: As far as I can tell, the community feels interested in the feature set; but relatively unable to contribute since none of the people have that much of a security background. It seems the best way to fix that would be to get more people with a

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread Devrim GÜNDÜZ
On Tue, 2009-03-10 at 11:44 -0700, Joshua D. Drake wrote: We would do the same thing with SE-Postgres. No, no. I already experienced this with --integer-datetimes sets, and I don't ever want to maintain another set. It is horrible. -- Devrim GÜNDÜZ, RHCE devrim~gunduz.org,

Re: [HACKERS] Sampling Profler for Postgres

2009-03-10 Thread Stefan Moeding
Hi! Tom Lane writes: I'm not at all convinced that we should be putting effort into a homegrown, partial substitute for DTrace. In my opinion providing DTrace as the only means of profiling would except a number of users from the tuning benefits. DTrace seems to rely on specific kernel

Re: [HACKERS] problem inserting in GIN index

2009-03-10 Thread Alvaro Herrera
Emanuel Calvo Franco escribió: 2009/3/10 Teodor Sigaev teo...@sigaev.ru: Apparently there's a crash involved ... Are other indexes on that table broken? ( Just count(*) with only index scan enabled ) Yes, there are some btree indexes broken. Alvaro asked him if the option fsync is off.

Re: [HACKERS] libxml incompatibility

2009-03-10 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: David Lee Lambert wrote: Is it supposed to be OK to call xmlCheckVersion() more than once? You are certainly not supposed to call xmlInitParser more than once - see http://xmlsoft.org/html/libxml-parser.html#xmlInitParser No, what that says is that

Re: [HACKERS] parallel restore fixes

2009-03-10 Thread Andrew Dunstan
Tom Lane wrote: How about this: by default, fmtId uses the same logic as now (one static PQExpBuffer). If told to by a call of init_parallel_dump_utils(), which need only be called by pg_restore during its startup, then it switches to using per-thread storage. init_parallel_dump_utils can

Re: [HACKERS] parallel restore fixes

2009-03-10 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: OK, here 'tis. Looks fairly reasonable to me, but of course I haven't tested it. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] About the new %sdt macro in F-11 package

2009-03-10 Thread Tom Lane
Devrim =?ISO-8859-1?Q?G=DCND=DCZ?= dev...@gunduz.org writes: I was trying to make a scratch build in Koji for orafce package, and it failed: http://koji.fedoraproject.org/koji/getfile?taskID=1235602name=build.log I consulted #fedora-devel @ Freenode, and the conclusion was this: walters

Re: [HACKERS] About the new %sdt macro in F-11 package

2009-03-10 Thread Alvaro Herrera
Tom Lane wrote: As of CVS HEAD, I see that we got rid of that, and pg_trace.h is now included only by the .c files that actually need it. ISTM that we should make 8.3 do likewise. Here's a patch for this. -- Alvaro Herrerahttp://www.CommandPrompt.com/

Re: [HACKERS] About the new %sdt macro in F-11 package

2009-03-10 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Tom Lane wrote: As of CVS HEAD, I see that we got rid of that, and pg_trace.h is now included only by the .c files that actually need it. ISTM that we should make 8.3 do likewise. Here's a patch for this. Oh, thanks, I was just about to go

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread KaiGai Kohei
Hannu Krosing wrote: If we compile it with --enable-selinux, it has two working modes controled by a guc option: sepostgresql (bool). If it is disabled, all the sepgsql() invocations returns at the head of themself without doing anything. I believe this behavior follows the previous

Re: [HACKERS] About the new %sdt macro in F-11 package

2009-03-10 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Tom Lane wrote: As of CVS HEAD, I see that we got rid of that, and pg_trace.h is now included only by the .c files that actually need it. ISTM that we should make 8.3 do likewise. Here's a patch for this. Oh,

Re: [HACKERS] Sampling Profler for Postgres

2009-03-10 Thread ITAGAKI Takahiro
Dickson S. Guedes lis...@guedesoft.net wrote: 2) I couldn't find a clear way to disable it. There is one in this patch or are you planning this to future? Ah, I forgot sampling should be disabled when track_activities is off. I'll fix it in the next patch. Also, I'd better measure

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-03-10 Thread Koichi Suzuki
patch version. Oh, sorry for the mistake. I changed one of Suzuki-san's patches to be rebased to HEAD again (readahead-20090310.patch). The other (addShBufCheck-20090120.patch) is not changed. Comment: we might reach consistent recovery state *before* redoing the safe starting point, because

[HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-10 Thread KaiGai Kohei
Heikki, it is the list of updated patches: http://sepgsql.googlecode.com/files/sepgsql-core-8.4devel-r1710.patch http://sepgsql.googlecode.com/files/sepgsql-utils-8.4devel-r1710.patch http://sepgsql.googlecode.com/files/sepgsql-policy-8.4devel-r1710.patch

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1704)

2009-03-10 Thread KaiGai Kohei
Tom Lane wrote: Ron Mayer rm...@cheapcomplexdevices.com writes: As far as I can tell, the community feels interested in the feature set; but relatively unable to contribute since none of the people have that much of a security background. It seems the best way to fix that would be to get