Re: [HACKERS] [PATCH] backend: compare word-at-a-time in bcTruelen

2009-06-23 Thread Stefan Kaltenbrunner
Robert Haas wrote: On Tue, Jun 23, 2009 at 10:46 PM, Jeremy Kerr wrote: Robert, I'd still like to know the workload and exact numbers. From up-thread: http://ozlabs.org/~jk/projects/db/data/postgres.bcTruelen/ - or were there other details you were looking for? Oh! Very nice, sorry, mis

Re: [HACKERS] that picksplit debug message again

2009-06-23 Thread Tom Lane
Peter Eisentraut writes: > Is the %d actually in the right place here? > errmsg("picksplit method for %d column of index \"%s\" failed", > attno + 1, RelationGetRelationName(r)) No, any native speaker of English would say "for column %d". Putting "failed" at the end seems a bit awkward a

[HACKERS] pg_listener attribute number #defines

2009-06-23 Thread Robert Haas
It appears that, for no particularly good reason, pg_listener.h deviates from the usual convention for declaring attribute number constants. Normally, it's #define Anum_{catalog-name}_{column-name} {attribute-number} pg_listener.h, however substitutes a different string that is similar, but not

Re: [HACKERS] Extensions User Design

2009-06-23 Thread Jaime Casanova
On Tue, Jun 23, 2009 at 12:44 PM, Dimitri Fontaine wrote: > >  - a core team approved list of extensions (replacing contribs, are you aware of the enormous job that will imply for core team? maybe a community approved list of extensions or maybe we can have some kind of jury (just like patch revie

Re: [HACKERS] [PATCH] backend: compare word-at-a-time in bcTruelen

2009-06-23 Thread Robert Haas
On Tue, Jun 23, 2009 at 10:46 PM, Jeremy Kerr wrote: > Robert, > >> I'd still like to know the workload and exact numbers. > > From up-thread: > >  http://ozlabs.org/~jk/projects/db/data/postgres.bcTruelen/ > > - or were there other details you were looking for? Oh! Very nice, sorry, missed the o

Re: [HACKERS] [PATCH] backend: compare word-at-a-time in bcTruelen

2009-06-23 Thread Jeremy Kerr
Robert, > I'd still like to know the workload and exact numbers. From up-thread: http://ozlabs.org/~jk/projects/db/data/postgres.bcTruelen/ - or were there other details you were looking for? Cheers, Jeremy -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chan

[HACKERS] dblink for 8.4 should work without user-mappings

2009-06-23 Thread Itagaki Takahiro
contrib/dblink in 8.4 supports a server name by CREATE SERVER for connection string, but it always requires an user-mapping (by CREATE USER MAPPING). However, I think it should work user-mappings because it works when the connection string is passed directly. =# SELECT * FROM dblink('dbname=postgr

Re: [HACKERS] [PATCH] backend: compare word-at-a-time in bcTruelen

2009-06-23 Thread Robert Haas
On Tue, Jun 23, 2009 at 9:05 PM, Jeremy Kerr wrote: > Results in a small performance increase; around 1-2% on my POWER6 test > box. I'd still like to know the workload and exact numbers. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subs

[HACKERS] [PATCH] backend: compare word-at-a-time in bcTruelen

2009-06-23 Thread Jeremy Kerr
The current bcTruelen function uses a simple reverse array scan to find the legth of a space-padded string. On some workloads (it shows in sysbench), this can result in a lot of time spent in this function. This change introduces a word-at-a-time comparison in bcTruelen, aiming to reduce the numbe

[HACKERS] that picksplit debug message again

2009-06-23 Thread Peter Eisentraut
Is the %d actually in the right place here? errmsg("picksplit method for %d column of index \"%s\" failed", attno + 1, RelationGetRelationName(r)) And later in the file there is this, which might have the same problem: elog(LOG, "PickSplit method of %d columns of index '%s' doesn't suppo

Re: [HACKERS] Extensions User Design

2009-06-23 Thread Richard Huxton
David E. Wheeler wrote: On Jun 23, 2009, at 3:02 PM, Dimitri Fontaine wrote: It's "just" PostgreSQL reading an SQL file (foo.install.sql) and parsing each statement etc, so we obviously have the machinery to recognize SQL objects names and schema qualification. Replacing the schema on-the-fly

Re: [HACKERS] Extensions User Design

2009-06-23 Thread David E. Wheeler
On Jun 23, 2009, at 3:02 PM, Dimitri Fontaine wrote: If we happen to accept the debian policy versioning scheme, then the hard work is already done for us, it seems: http://packages.debian.org/fr/sid/postgresql-8.3-debversion As long as we don't need to implement a new data type, fine. Rep

Re: [HACKERS] Extensions User Design

2009-06-23 Thread Dimitri Fontaine
[Skipping most of it as I'd like to read what other people think about it before going in lengthy thread already] :) Le 23 juin 09 à 23:41, David E. Wheeler a écrit : Yes, although as I said before, version numbers are hard to get right. We should keep them very simple, with a strict requirem

Re: [HACKERS] Extensions User Design

2009-06-23 Thread David E. Wheeler
On Jun 23, 2009, at 2:06 PM, Dimitri Fontaine wrote: It'd be nice if it supported other core languages like PL/Perl, but it's okay if it doesn't on the first round (I'd likely want to use some CPAN modules in a PL/Perl extension, anyway). At first sight I though you were talking about a non

Re: [HACKERS] Extensions User Design

2009-06-23 Thread Dimitri Fontaine
Le 23 juin 09 à 20:30, David E. Wheeler a écrit : On Jun 23, 2009, at 10:44 AM, Dimitri Fontaine wrote: - support for home grown SQL/PLpgSQL only extensions in order to make life easier for in-house PG based development (you don't have to code in C to benefit from extensions) It'd be ni

Re: [HACKERS] 8.4RC2 is available

2009-06-23 Thread Devrim GÜNDÜZ
On Tue, 2009-06-23 at 09:25 -0400, Tom Lane wrote: > We spun an 8.4RC2 tarball, mainly to check that Peter's recent fixes > to the man page generation process actually worked. There will not be > binary builds of RC2, Actually RPMs will be available at yum repository sometimes around midnight PDT

Re: [HACKERS] Extensions User Design

2009-06-23 Thread David E. Wheeler
On Jun 23, 2009, at 10:44 AM, Dimitri Fontaine wrote: The contenders are extension, module, bundle and package. My vote is extension. +1 == v1.0 goals We're not trying to be feature complete on first round. * must have - dump & restore support (when upgrading a cluster or just restoring)

[HACKERS] Extensions User Design

2009-06-23 Thread Dimitri Fontaine
Hi, = PostgreSQL Extensions Here's the first round of User Design about PostgreSQL Extensions. I tried to put together the ideas expressed by a lot of different people. The aim here is to first agree on the naming and the goals, then talk about what user design we propose. == name The contender

Re: [HACKERS] 8.4RC2 is available

2009-06-23 Thread David E. Wheeler
On Jun 23, 2009, at 6:25 AM, Tom Lane wrote: We spun an 8.4RC2 tarball, mainly to check that Peter's recent fixes to the man page generation process actually worked. There will not be binary builds of RC2, but if anyone who's building from source wants to double check it, it should be on mos

Re: [HACKERS] PK not being restored

2009-06-23 Thread Merlin Moncure
On Tue, Jun 23, 2009 at 2:11 AM, Rajdeep Das wrote: > Dear Sir/Madam, > > > > I am using postgresql db server for our production environment. I have > created a schema by the name “application”. The public schema is not being > used at all. I have noticed that suddenly, the public schema is having

[HACKERS] PK not being restored

2009-06-23 Thread Rajdeep Das
Dear Sir/Madam, I am using postgresql db server for our production environment. I have created a schema by the name "application". The public schema is not being used at all. I have noticed that suddenly, the public schema is having some table definition and a whole lot of functions. I have no

[HACKERS] 8.4RC2 is available

2009-06-23 Thread Tom Lane
We spun an 8.4RC2 tarball, mainly to check that Peter's recent fixes to the man page generation process actually worked. There will not be binary builds of RC2, but if anyone who's building from source wants to double check it, it should be on most mirrors by now. regards,

Re: [HACKERS] Changed error message for blocks by prepared transactions

2009-06-23 Thread Andreas 'ads' Scherbaum
On Mon, 22 Jun 2009 19:24:28 -0400 Tom Lane wrote: > "Andreas 'ads' Scherbaum" writes: > > the small attached patch changes the error message for a blocked > > database in case there are prepared transactions. > > Isn't this duplicative of the errdetail_busy_db code? And anyway > I do not see a