Re: [HACKERS] final patch - plpgsql: for-in-array

2010-11-17 Thread Jaime Casanova
On Thu, Sep 30, 2010 at 7:46 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello this patch implement a new iteration construct - iteration over an array. The sense of this new iteration is:  * a simple and cleaner syntax i will start the review of this one... but before that sorry for

Re: [HACKERS] Label switcher function

2010-11-17 Thread Robert Haas
2010/11/17 KaiGai Kohei kai...@ak.jp.nec.com: I also fixed up regression test, dummy_seclabel module and its documentation as Robert pointed out in another topic. I have committed the documentation portion of this patch with some editing. I also fixed the markup, which was broken, because you

Re: [HACKERS] Label switcher function

2010-11-17 Thread Robert Haas
2010/11/17 KaiGai Kohei kai...@ak.jp.nec.com: I revised my patch as I attached. The hook function is modified and consolidated as follows:  typedef enum FunctionCallEventType  {     FCET_BE_HOOKED,     FCET_PREPARE,     FCET_START,     FCET_END,     FCET_ABORT,  }

Re: [HACKERS] Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running

2010-11-17 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Tom Lane wrote: Possibly the cleanest fix is to implement pg_ping as a libpq function. You do have to distinguish connection failures (ie connection refused) from errors that came back from the postmaster, and the easiest place to

Re: [HACKERS] MergeAppend costing

2010-11-17 Thread Tom Lane
I wrote: What this example suggests is that we should consider ways to pass down the top-N-ness to sorts executed as part of a MergeAppend tree. That seems a tad messy though, both in the executor and the planner. Actually the executor side of it doesn't seem too bad. A Limit node already

Re: [HACKERS] Indent authentication overloading

2010-11-17 Thread Jeroen Vermeulen
On 2010-11-18 00:14, Magnus Hagander wrote: If it was a matter of changing it for those who use ident over tcp, I really wouldn't hesitate - they're few :-) But the problem is that it's the ident-over-tcp that's correctly named, not the other one... True. By the way ISTR we don't fall back

Re: [HACKERS] final patch - plpgsql: for-in-array

2010-11-17 Thread Merlin Moncure
On Wed, Nov 17, 2010 at 7:08 PM, Jaime Casanova ja...@2ndquadrant.com wrote: On Thu, Sep 30, 2010 at 7:46 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello this patch implement a new iteration construct - iteration over an array. The sense of this new iteration is:  * a simple and

Re: [HACKERS] final patch - plpgsql: for-in-array

2010-11-17 Thread Tom Lane
Merlin Moncure mmonc...@gmail.com writes: On Wed, Nov 17, 2010 at 7:08 PM, Jaime Casanova ja...@2ndquadrant.com wrote: i will start the review of this one... but before that sorry for suggesting this a bit later but about using UNNEST as part of the sintax? Does for-in-array do what unnset

Re: [HACKERS] Indent authentication overloading

2010-11-17 Thread Stuart Bishop
On Wed, Nov 17, 2010 at 10:35 PM, Magnus Hagander mag...@hagander.net wrote: Currently, we overload indent meaning both unix socket authentication and ident over tcp, depending on what type of connection it is. This is quite unfortunate - one of them being one of the most secure options we

Re: [HACKERS] final patch - plpgsql: for-in-array

2010-11-17 Thread Pavel Stehule
2010/11/18 Tom Lane t...@sss.pgh.pa.us: Merlin Moncure mmonc...@gmail.com writes: On Wed, Nov 17, 2010 at 7:08 PM, Jaime Casanova ja...@2ndquadrant.com wrote: i will start the review of this one... but before that sorry for suggesting this a bit later but about using UNNEST as part of the

[HACKERS] Unused parameter in vacuum.c

2010-11-17 Thread Shigeru HANADA
Hi, When I was reading vacuum.c, I found that the parameter 'stmttype' of get_rel_oids() is not used at all. The parameter had been used as command tag in the notice message about invalid object type, but now such messages are reported by other functions. Please find attached

<    1   2