Re: is JSON really a type (Re: [HACKERS] data to json enhancements)

2012-09-30 Thread Darren Duncan
Hannu Krosing wrote: Reflecting over the dual possible interpretation of what it does mean to convert between text and json data types it has dawned to me that the confusion may come mainly from wanting json to be two things at once: 1. - a serialisation of of a subset of javascript objects

[HACKERS] Question regarding Sync message and unnamed portal

2012-09-30 Thread Tatsuo Ishii
From the manual: An unnamed portal is destroyed at the end of the transaction At completion of each series of extended-query messages, the frontend should issue a Sync message. This parameterless message causes the backend to close the current transaction if it's not inside a BEGIN/COMMIT

Re: [HACKERS] 64-bit API for large object

2012-09-30 Thread Kohei KaiGai
2012/9/30 Tatsuo Ishii is...@postgresql.org: * At inv_seek(), it seems to me it checks offset correctness with wrong way, as follows: | case SEEK_SET: | if (offset 0) | elog(ERROR, invalid seek offset: INT64_FORMAT, offset); |

[HACKERS] pg_regress running for ~10 hours using 100% CPU

2012-09-30 Thread Thomas Munro
Hi Buildfarm machine lyrebird, clang 2.9, amd64, Debian 6, 'HEAD'. I have been unsuccessful in finding out what it's doing using gdb: pg_animal@asterix:~/work/HEAD/pgsql$ gdb --pid=10681 GNU gdb (GDB) 7.0.1-debian Copyright (C) 2009 Free Software Foundation, Inc. License GPLv3+: GNU GPL version

Re: [HACKERS] Question regarding Sync message and unnamed portal

2012-09-30 Thread Tom Lane
Tatsuo Ishii is...@postgresql.org writes: From the manual: An unnamed portal is destroyed at the end of the transaction Actually, all portals are destroyed at end of transaction (unless they're from holdable cursors). Named or not doesn't enter into it. From these statements, I would think

Re: [HACKERS] embedded list v3

2012-09-30 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: Patch 0001 contains a assert_compatible_types(a, b) and a assert_compatible_types_bool(a, b) macro which I found very useful to make it harder to misuse the api. I think its generally useful and possibly should be used in more places. This seems

Re: [HACKERS] embedded list v3

2012-09-30 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: Current version is available at branch ilist in: git://git.postgresql.org/git/users/andresfreund/postgres.git ssh://g...@git.postgresql.org/users/andresfreund/postgres.git I'm still pretty desperately unhappy with your insistence on circularly

Re: [HACKERS] embedded list v3

2012-09-30 Thread Andres Freund
On Sunday, September 30, 2012 06:57:32 PM Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: Patch 0001 contains a assert_compatible_types(a, b) and a assert_compatible_types_bool(a, b) macro which I found very useful to make it harder to misuse the api. I think its generally

Re: [HACKERS] embedded list v3

2012-09-30 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: Perhaps we need to decouple _Static_assert support from compound statement support at some point, but we will see. Yeah, possibly, but until we have an example of a non-gcc-compatible compiler that can do something equivalent, it's hard to guess how

Re: [HACKERS] embedded list v3

2012-09-30 Thread Andres Freund
Hi, On Sunday, September 30, 2012 10:33:28 PM Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: Current version is available at branch ilist in: git://git.postgresql.org/git/users/andresfreund/postgres.git ssh://g...@git.postgresql.org/users/andresfreund/postgres.git I'm

Re: [HACKERS] embedded list v3

2012-09-30 Thread Andres Freund
On Sunday, September 30, 2012 10:48:01 PM Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: Perhaps we need to decouple _Static_assert support from compound statement support at some point, but we will see. Yeah, possibly, but until we have an example of a non-gcc-compatible

Re: [HACKERS] Statistics and selectivity estimation for ranges

2012-09-30 Thread Jeff Davis
On Tue, 2012-09-04 at 17:27 +0400, Alexander Korotkov wrote: Addon patch is attached. Actually, I don't get your intention of introducing STATISTIC_KIND_RANGE_EMPTY_FRAC stakind. Did you plan to leave it as empty frac in distinct stakind or replace this stakind with

Re: [HACKERS] gistchoose vs. bloat

2012-09-30 Thread Jeff Davis
On Tue, 2012-09-04 at 19:21 +0400, Alexander Korotkov wrote: New version of patch is attached. Parameter randomization was introduced. It controls whether to randomize choose. Choose algorithm was rewritten. Review comments: 1. Comment above while loop in gistRelocateBuildBuffersOnSplit

Re: [HACKERS] WIP checksums patch

2012-09-30 Thread Jeff Davis
On Fri, 2012-09-14 at 17:58 -0700, Jeff Davis wrote: This is just a rebased version of the patch by Simon here: I just noticed the following note in the docs for this patch: The default is literaloff/ for backwards compatibility and to allow upgrade. The recommended setting is literalon/

Re: [HACKERS] WIP checksums patch

2012-09-30 Thread Jeff Davis
On Fri, 2012-09-14 at 17:58 -0700, Jeff Davis wrote: * we might want to make it slightly easier for external utilities, like for backup/replication, to verify the pages Ideally, PageVerificationInfoOK should be available to external utilities, so that someone might script a background job to

Re: [HACKERS] Switching timeline over streaming replication

2012-09-30 Thread Amit kapila
On Friday, September 28, 2012 6:38 PM Amit Kapila wrote: On Tuesday, September 25, 2012 6:29 PM Heikki Linnakangas wrote: On 25.09.2012 10:08, Heikki Linnakangas wrote: On 24.09.2012 16:33, Amit Kapila wrote: In any case, it will be better if you can split it into multiple patches: 1.

Re: [HACKERS] Extending range of to_tsvector et al

2012-09-30 Thread Dan Scott
On Sun, Sep 30, 2012 at 1:56 PM, johnkn63 john.knight...@gmail.com wrote: When using to_tsvector a number of newer unicode characters and pua characters are not included. How do I add the characters which I desire to be found? I've just started digging into this code a bit, but from what I've

Re: [HACKERS] Unportable use of uname in pg_upgrade test script

2012-09-30 Thread Peter Eisentraut
On Sat, 2012-09-29 at 13:33 -0400, Andrew Dunstan wrote: On 09/29/2012 01:06 PM, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: The trouble with uname -s is that its output is a bit variable. I think this will work: testhost=`uname -a | sed 's/.* //'` What do you mean

Re: [HACKERS] Doc patch, normalize search_path in index

2012-09-30 Thread Dan Scott
On Fri, Sep 28, 2012 at 1:40 PM, Karl O. Pinc k...@meme.com wrote: Hi, The attached patch (against git head) normalizes search_path as the thing indexed and uses a secondary index term to distinguish the configuration parameter from the run-time setting. Makes sense to me, although I

Re: [HACKERS] Extending range of to_tsvector et al

2012-09-30 Thread john knightley
Dear Dan, thank you for your reply. The OS I am using is Ubuntu 12.04, with PostgreSQL 9.1.5 installed on a utf8 local A short 5 line dictionary file is sufficient to test:- raeuz 我们 昭厵 꽖떂 撘䮬 line 1 raeuz Zhuang word written using English letters and show up under ts_vector ok line 2 我们 uses

Re: [HACKERS] pg_upgrade tests vs alter generic changes

2012-09-30 Thread Peter Eisentraut
On Sat, 2012-09-29 at 17:52 -0400, Andrew Dunstan wrote: It turns out that the reason is that we support collations on MSVC but not on Mingw. The cause for that is that on Windows locale_t is called _locale_t, and there is a workaround for that in src/include/port/win32.h for the MSVC build,

Re: [HACKERS] Extending range of to_tsvector et al

2012-09-30 Thread Dan Scott
Hi John: On Sun, Sep 30, 2012 at 11:45 PM, john knightley john.knight...@gmail.com wrote: Dear Dan, thank you for your reply. The OS I am using is Ubuntu 12.04, with PostgreSQL 9.1.5 installed on a utf8 local A short 5 line dictionary file is sufficient to test:- raeuz 我们 昭厵 꽖떂 撘䮬

Re: [HACKERS] Extending range of to_tsvector et al

2012-09-30 Thread Tom Lane
john knightley john.knight...@gmail.com writes: The OS I am using is Ubuntu 12.04, with PostgreSQL 9.1.5 installed on a utf8 local A short 5 line dictionary file is sufficient to test:- raeuz 我们 𦘭𥎵 𪽖𫖂 󶒘󴮬 line 1 raeuz Zhuang word written using English letters and

Re: [HACKERS] Extending range of to_tsvector et al

2012-09-30 Thread john knightley
On Mon, Oct 1, 2012 at 12:11 PM, Tom Lane t...@sss.pgh.pa.us wrote: john knightley john.knight...@gmail.com writes: The OS I am using is Ubuntu 12.04, with PostgreSQL 9.1.5 installed on a utf8 local A short 5 line dictionary file is sufficient to test:- raeuz 我们 昭厵 꽖떂 撘䮬 line 1 raeuz

Re: [HACKERS] Extending range of to_tsvector et al

2012-09-30 Thread john knightley
On Mon, Oct 1, 2012 at 11:58 AM, Dan Scott deni...@gmail.com wrote: Hi John: On Sun, Sep 30, 2012 at 11:45 PM, john knightley john.knight...@gmail.com wrote: Dear Dan, thank you for your reply. The OS I am using is Ubuntu 12.04, with PostgreSQL 9.1.5 installed on a utf8 local A short 5

Re: [HACKERS] Question regarding Sync message and unnamed portal

2012-09-30 Thread Tatsuo Ishii
Tatsuo Ishii is...@postgresql.org writes: From the manual: An unnamed portal is destroyed at the end of the transaction Actually, all portals are destroyed at end of transaction (unless they're from holdable cursors). Named or not doesn't enter into it. We need to fix the document then.