Thanks for reviewing, Andres.
On Thu, Sep 11, 2014 at 7:01 AM, Andres Freund wrote:
>> +static void bgreclaim_quickdie(SIGNAL_ARGS);
>> +static void BgreclaimSigHupHandler(SIGNAL_ARGS);
>> +static void ReqShutdownHandler(SIGNAL_ARGS);
>> +static void bgreclaim_sigusr1_handler(SIGNAL_ARGS);
>
> Th
On Thu, Sep 11, 2014 at 09:37:07AM -0300, Arthur Silva wrote:
> I agree that there's no reason to fix an algorithm to it, unless maybe it's
> pglz. There's some initial talk about implementing pluggable compression
> algorithms for TOAST and I guess the same must be taken into consideration
> for t
(3) I wish that the maximum implied multiplier could be explicitely
documented in the source code. From pg_rand48 source code, I think
that it is 33.27106466687737
Small possibly buggy code attached, to show how I computed the above
figure.
--
Fabien.#include
#include
int main(void
I agree that there's no reason to fix an algorithm to it, unless maybe it's
pglz. There's some initial talk about implementing pluggable compression
algorithms for TOAST and I guess the same must be taken into consideration
for the WAL.
--
Arthur Silva
On Thu, Sep 11, 2014 at 2:46 AM, Rahila Sye
Hello Heikki,
Now that I've finished the detour and committed and backpatched the changes
to the way latency is calculated, we can get back to this patch. It needs to
be rebased.
Before rebasing, I think that there are a few small problems with the
modification applied to switch from an int
* Pavel Stehule (pavel.steh...@gmail.com) wrote:
> Can I help with something, it is there some open question?
I had been hoping for a more definitive answer regarding this option for
array_to_json, or even a comment about the change to row_to_json.
Andrew- any thoughts on this? (that's what the p
On Wed, Sep 10, 2014 at 4:54 AM, Kyotaro HORIGUCHI
wrote:
> Finally I think that we need case-insensitive version of
> get_role_id and() get_database_id() to acoomplish this patch'es
> objective. (This runs full-scans on pg_database or pg_authid X()
Any such thing is certainly grounds for rejecti
On 09/11/2014 02:30 PM, Etsuro Fujita wrote:
Actually, this patch allows the exact same thing to apply to foreign
tables. My explanation was insufficient about that. Sorry for that.
Great, that's what I thought.
So, should I split the patch into the two?
Yeah, please do.
- Heikki
--
Se
On Fri, Jul 25, 2014 at 11:41 PM, Robert Haas wrote:
>
> Patch 4 adds infrastructure that allows one session to save all of its
> non-default GUC values and another session to reload those values.
> This was written by Amit Khandekar and Noah Misch. It allows
> pg_background to start up the backg
(2014/09/11 19:46), Heikki Linnakangas wrote:
On 09/11/2014 12:22 PM, Etsuro Fujita wrote:
(2014/09/11 4:32), Heikki Linnakangas wrote:
I had a cursory look at this patch and the discussions around this.
Thank you!
ISTM there are actually two new features in this: 1) allow CHECK
constraints
Erik,
* Erik Rijkers (e...@xs4all.nl) wrote:
> On Wed, September 10, 2014 23:50, Stephen Frost wrote:
> > [rls_9-10-2014.patch]
>
> I can't get this to apply; I attach the complaints of patch.
Thanks for taking a look at this!
[...]
> patching file src/include/catalog/catversion.h
> Hunk #1 FA
On Thu, Aug 28, 2014 at 12:40 PM, Michael Paquier
wrote:
>
> On Wed, Aug 27, 2014 at 2:46 PM, Rajeev rastogi
> wrote:
> > I have done some more review, below are my comments:
> Thanks!
>
> > 1. There are currently two loops on *num_sync, Can we simplify the
function SyncRepGetSynchronousNodes by
On Thu, Aug 28, 2014 at 6:23 AM, Tom Lane wrote:
>
> If the majority of the added code is code that will be needed for
> less-bogus optimizations, it might be all right; but I'd kind of want to
> see the less-bogus optimizations working first.
>
>
That seems fair. Likely there'd be not a great dea
Hi,
On 2014-09-10 12:17:34 +0530, Amit Kapila wrote:
> include $(top_srcdir)/src/backend/common.mk
> diff --git a/src/backend/postmaster/bgreclaimer.c
> b/src/backend/postmaster/bgreclaimer.c
> new file mode 100644
> index 000..3df2337
> --- /dev/null
> +++ b/src/backend/postmaster/bgreclaim
On 09/11/2014 12:52 PM, David Rowley wrote:
The attached small patch fixes the following warning:
src\backend\utils\adt\arrayfuncs.c(5613): warning C4013: '_isnan'
undefined; assuming extern returning int [D:\Postgres\a\postgres.vcxproj]
The fix is pretty much just a copy and paste from costsiz
On 09/11/2014 12:22 PM, Etsuro Fujita wrote:
(2014/09/11 4:32), Heikki Linnakangas wrote:
I had a cursory look at this patch and the discussions around this.
Thank you!
ISTM there are actually two new features in this: 1) allow CHECK
constraints on foreign tables, and 2) support inheritance
On 08/30/2014 07:16 PM, Fabien COELHO wrote:
+ if (latency_limit)
+ printf("number of transactions above the %.1f ms latency limit: "
INT64_FORMAT "\n",
+ latency_limit / 1000.0, latency_late);
+
Any reason not to report a percentage here?
Yes:
On 09/10/2014 05:47 PM, Mitsumasa KONDO wrote:
Hi,
I find typo in your patch. Please confirm.
@line 239
- agg->sum2_lag = 0;
+ agg->sum_lag = 0;
Ah thanks, cood catch!
And back patch is welcome for me.
I've committed and backpatched this, as well as a patch to refactor the
way the Poiss
The attached small patch fixes the following warning:
src\backend\utils\adt\arrayfuncs.c(5613): warning C4013: '_isnan'
undefined; assuming extern returning int [D:\Postgres\a\postgres.vcxproj]
The fix is pretty much just a copy and paste from costsize.c
Regards
David Rowley
isnan_msvc_fix.pa
On 09/11/2014 12:22 PM, Andres Freund wrote:
On 2014-09-11 12:14:42 +0300, Heikki Linnakangas wrote:
On 09/11/2014 11:43 AM, Abhijit Menon-Sen wrote:
At 2014-08-21 10:06:39 +0300, hlinnakan...@vmware.com wrote:
I think the names that rm_identify returns should match those that the
rm_desc func
On 2014-09-11 12:14:42 +0300, Heikki Linnakangas wrote:
> On 09/11/2014 11:43 AM, Abhijit Menon-Sen wrote:
> >At 2014-08-21 10:06:39 +0300, hlinnakan...@vmware.com wrote:
> >>I think the names that rm_identify returns should match those that the
> >>rm_desc functions print.
> >
> >I had originally
(2014/09/11 4:32), Heikki Linnakangas wrote:
I had a cursory look at this patch and the discussions around this.
Thank you!
ISTM there are actually two new features in this: 1) allow CHECK
constraints on foreign tables, and 2) support inheritance for foreign
tables. How about splitting it int
On 09/11/2014 11:43 AM, Abhijit Menon-Sen wrote:
At 2014-08-21 10:06:39 +0300, hlinnakan...@vmware.com wrote:
I think the names that rm_identify returns should match those that the
rm_desc functions print.
I had originally started off trying to keep the output in sync, but it
doesn't work very
At 2014-08-21 10:06:39 +0300, hlinnakan...@vmware.com wrote:
>
> Committed the patch to add INT64_MODIFIER, with minor fixes.
Thank you.
> The new rm_identify method needs to be documented. […]
> Perhaps add comments to the RmgrData struct, explaining
> all of the methods.
OK, I'll submit a patc
On Thu, Sep 11, 2014 at 9:10 AM, Michael Paquier
wrote:
> On Thu, Sep 11, 2014 at 5:21 AM, Heikki Linnakangas
> wrote:
> > On 08/28/2014 10:10 AM, Michael Paquier wrote:
> >>
> >> + #synchronous_standby_num = -1 # number of standbys servers using sync
> >> rep
> >
> >
> > To be honest, that's a h
On 09/11/2014 06:08 AM, Xiaoyulei wrote:
I use benchmarksql with more than 200 clients on pg 9.3.3. when the test is
going on, I collect all the process stack. I found about 100 processes are
blocked by btree insert. Another 100 are blocked by xloginsert.
Does btree has bad performance in conc
On Wed, September 10, 2014 23:50, Stephen Frost wrote:
> [rls_9-10-2014.patch]
I can't get this to apply; I attach the complaints of patch.
Erik Rijkers
-- git clone git://git.postgresql.org/git/postgresql.git master
Cloning into 'master'...
-- git branch
* master
patching file doc/src/s
101 - 127 of 127 matches
Mail list logo
