[HACKERS] How about a option to disable autovacuum cancellation on lock conflict?

2014-11-29 Thread Andres Freund
Hi, I've more than once seen that autovacuums on certain tables never succeed because regular exclusive (or similar) lockers cause it to give way/up before finishing. Usually if some part of the application uses explicit exclusive locks. In general I think it's quite imortant that autovacuum

[HACKERS] Removing INNER JOINs

2014-11-29 Thread David Rowley
Hi, Starting a new thread which continues on from http://www.postgresql.org/message-id/caaphdvoec8ygwoahvsri-84en2k0tnh6gpxp1k59y9juc1w...@mail.gmail.com To give a brief summary for any new readers: The attached patch allows for INNER JOINed relations to be removed from the plan, providing none

Re: [HACKERS] How about a option to disable autovacuum cancellation on lock conflict?

2014-11-29 Thread Magnus Hagander
On Nov 29, 2014 9:23 AM, Andres Freund and...@2ndquadrant.com wrote: Hi, I've more than once seen that autovacuums on certain tables never succeed because regular exclusive (or similar) lockers cause it to give way/up before finishing. Usually if some part of the application uses explicit

Re: [HACKERS] PATCH: decreasing memory needlessly consumed by array_agg

2014-11-29 Thread Tomas Vondra
Hi, Attached is v2 of the patch lowering array_agg memory requirements. Hopefully it addresses the issues issues mentioned by TL in this thread (not handling some of the callers appropriately etc.). The v2 of the patch does this: * adds 'subcontext' flag to initArrayResult* methods If it's

Re: [HACKERS] [COMMITTERS] pgsql: Revert Add libpq function PQhostaddr().

2014-11-29 Thread Tom Lane
Noah Misch n...@leadboat.com writes: Revert Add libpq function PQhostaddr(). This reverts commit 9f80f4835a55a1cbffcda5d23a617917f3286c14. The function returned the raw value of a connection parameter, a task served by PQconninfo(). The next commit will reimplement the psql \conninfo change

Re: [HACKERS] [COMMITTERS] pgsql: Revert Add libpq function PQhostaddr().

2014-11-29 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Looks like this has broken the docs. See http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=crakedt=2014-11-29%2018%3A41%3A56 That's because the cross-reference from the release notes wasn't removed. regards, tom lane --

Re: [HACKERS] [COMMITTERS] pgsql: Revert Add libpq function PQhostaddr().

2014-11-29 Thread Noah Misch
On Sat, Nov 29, 2014 at 02:09:09PM -0500, Tom Lane wrote: Noah Misch n...@leadboat.com writes: Revert Add libpq function PQhostaddr(). This reverts commit 9f80f4835a55a1cbffcda5d23a617917f3286c14. The function returned the raw value of a connection parameter, a task served by

Re: [HACKERS] Review of GetUserId() Usage

2014-11-29 Thread Stephen Frost
All, * Stephen Frost (sfr...@snowman.net) wrote: * Stephen Frost (sfr...@snowman.net) wrote: Attached is a patch to address the pg_cancel/terminate_backend and the statistics info as discussed previously. It sounds like we're coming to And I forgot the attachment, of course. Apologies.

Re: [HACKERS] [COMMITTERS] pgsql: Revert Add libpq function PQhostaddr().

2014-11-29 Thread Tom Lane
Noah Misch n...@leadboat.com writes: On Sat, Nov 29, 2014 at 02:09:09PM -0500, Tom Lane wrote: I confess to not having been paying too much attention to your discussion with Fujii over the holiday, but isn't it a bit too late to be making client-API-breaking changes in 9.4? I would have been

Re: [HACKERS] [COMMITTERS] pgsql: Revert Add libpq function PQhostaddr().

2014-11-29 Thread David G Johnston
Noah Misch-2 wrote On Sat, Nov 29, 2014 at 02:09:09PM -0500, Tom Lane wrote: Noah Misch lt; noah@ gt; writes: Revert Add libpq function PQhostaddr(). This reverts commit 9f80f4835a55a1cbffcda5d23a617917f3286c14. The function returned the raw value of a connection parameter, a task

[HACKERS] Determining typmod of *source* of a cast

2014-11-29 Thread Jim Nasby
Is there any way to determine the typemod of the source data for a cast? Perhaps a modification on get_call_expr_argtype(), though I'd hate to put that in an extension... BTW, it'd be nice if we better emphasized that the typmod passed to a cast function is for the destination... :/ -- Jim

Re: [HACKERS] Securing make check (CVE-2014-0067)

2014-11-29 Thread Noah Misch
On Sun, Sep 21, 2014 at 02:31:15AM -0400, Noah Misch wrote: It then dawned on me that every Windows build of PostgreSQL already has a way to limit connections to a particular OS user. SSPI authentication is essentially the Windows equivalent of peer authentication. A brief trial thereof

Re: [HACKERS] [COMMITTERS] pgsql: Revert Add libpq function PQhostaddr().

2014-11-29 Thread Tom Lane
David G Johnston david.g.johns...@gmail.com writes: Noah Misch-2 wrote I had considered that, and one could make a reasonable case for living with the new symbol on that basis. For the release candidate stage to have value, though, the treat as released principle must not be absolute. I

Re: [HACKERS] How about a option to disable autovacuum cancellation on lock conflict?

2014-11-29 Thread Jim Nasby
On 11/29/14, 2:22 AM, Andres Freund wrote: Hi, I've more than once seen that autovacuums on certain tables never succeed because regular exclusive (or similar) lockers cause it to give way/up before finishing. Usually if some part of the application uses explicit exclusive locks. In general I