On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Another thing in that patch was that I had to add the sql/ directory to
the source tree, but other than that .gitignore file it was empty.
Maybe pg_regress should create the sql/ directory in the build dir if it
On Thu, Dec 18, 2014 at 2:21 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Wed, Dec 17, 2014 at 11:33 PM, Rahila Syed rahilasye...@gmail.com
wrote:
I had a look at code. I have few minor points,
Thanks!
+ bkpb.fork_flags |= BKPBLOCK_HAS_IMAGE;
+
+ if
On 2014-12-16 18:37:48 +0200, Heikki Linnakangas wrote:
On 12/11/2014 04:21 PM, Marco Nenciarini wrote:
Il 11/12/14 12:38, Andres Freund ha scritto:
On December 11, 2014 9:56:09 AM CET, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
On 12/11/2014 05:45 AM, Andres Freund wrote:
Yeah. I
On Thu, Dec 18, 2014 at 12:52 PM, Etsuro Fujita
fujita.ets...@lab.ntt.co.jp wrote:
Hi,
The attached patch just removes one bad-looking blank line in the
comments at the top of a function in explain.c.
Applied.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list
(2014/12/18 17:34), Fujii Masao wrote:
On Thu, Dec 18, 2014 at 12:52 PM, Etsuro Fujita
fujita.ets...@lab.ntt.co.jp wrote:
The attached patch just removes one bad-looking blank line in the
comments at the top of a function in explain.c.
Applied.
Thanks!
Best regards,
Etsuro Fujita
--
Sent
On Tue, Dec 16, 2014 at 3:51 AM, Simon Riggs si...@2ndquadrant.com wrote:
Currently, WALReceiver writes and fsyncs data it receives. Clearly,
while we are waiting for an fsync we aren't doing any other useful
work.
Following patch starts WALWriter during recovery and makes it
responsible for
On 16.12.2014 08:33, David Rowley wrote:
On 16 December 2014 at 18:18, Josh Berkus j...@agliodbs.com
mailto:j...@agliodbs.com wrote:
Man. You're equating stuff that's not the same. You didn't get your way
(and I'm tentatively on your side onthat one) and take that to imply
that
Isn't it better to allocate the memory for compression_scratch in
InitXLogInsert()
like hdr_scratch?
I think making compression_scratch a statically allocated global variable
is the result of following discussion earlier,
On Wed, Dec 17, 2014 at 4:11 AM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
On 12/16/2014 10:24 AM, Borodin Vladimir wrote:
12 дек. 2014 г., в 16:46, Heikki Linnakangas
hlinnakan...@vmware.com написал(а):
There have been a few threads on the behavior of WAL archiving,
after a standby
On Thu, Dec 18, 2014 at 7:31 PM, Rahila Syed rahilasye...@gmail.com wrote:
Isn't it better to allocate the memory for compression_scratch in
InitXLogInsert()
like hdr_scratch?
I think making compression_scratch a statically allocated global variable
is the result of following discussion
On Thu, Dec 18, 2014 at 7:31 PM, Rahila Syed rahilasye...@gmail.com wrote:
Isn't it better to allocate the memory for compression_scratch in
InitXLogInsert()
like hdr_scratch?
I think making compression_scratch a statically allocated global variable
is the result of following discussion
On 18 December 2014 at 04:56, Teodor Sigaev teo...@sigaev.ru wrote:
You could well be right, but it would be good to compare the numbers just
so we
know this for sure.
I wasn't right :(
# set work_mem='64kB';
# set enable_seqscan = off;
Patched: 1194.094 ms
Master: 1765.338 ms
Are
On Tue, Dec 16, 2014 at 9:47 AM, Jim Nasby jim.na...@bluetreble.com wrote:
config.cache is created when you pass -C to configure, which speeds it up
considerably (3.5s vs 16.5 on my laptop). It would be nice to just ignore
the cache file it generates.
Originally this patch also ignored the
On Sun, Dec 14, 2014 at 11:43 AM, Tatsuo Ishii is...@postgresql.org wrote:
If we care enough about that case to attempt the vacuum anyway then we
need to do something about the error message; either squelch it or
check for the existence of the tables before attempting to
vacuum. Since there's
Hi,
v2 version of this patch is attached.
On 16/12/14 09:31, Petr Jelinek wrote:
On 16/12/14 08:43, Jaime Casanova wrote:
Sadly when the jsonb functions patch was committed a few oids where
used, so you should update the ones you are using. at least to make
the patch easier for testing.
On Mon, Dec 15, 2014 at 12:25 PM, Andrew Gierth
and...@tao11.riddles.org.uk wrote:
Fujii == Fujii Masao masao.fu...@gmail.com writes:
Fujii Pushed.
Bug found:
regression=# select count(*) from generate_series(1::numeric,10) v,
generate_series(1,v) w;
count
---
0
(1 row)
On Mon, Dec 15, 2014 at 2:38 PM, Andrew Gierth
and...@tao11.riddles.org.uk wrote:
Ali == Ali Akbar the.ap...@gmail.com writes:
Ali I think yes, it will be good. The alternative is restructuring
Ali this paragraph in the SRF docs:
The memory context that is current when the SRF is called
Michael Paquier wrote:
It would be good to be consistent on Windows with what is now done on other
platforms: those modules should not be installed by default, but it would
be good to make install.pm a bit smarter with for example an option full,
aka install server + client + test modules.
On 17.12.2014 20:00, Stephen Frost wrote:
* Jaime Casanova (ja...@2ndquadrant.com) wrote:
On Tue, Dec 16, 2014 at 11:32 AM, Robert Haas robertmh...@gmail.com wrote:
It has been proposed that we do a general list of people at the bottom
of the release notes who helped review during that
At 2014-12-16 13:28:07 -0500, sfr...@snowman.net wrote:
The magic audit role has SELECT rights on a given table. When any
user does a SELECT against that table, ExecCheckRTPerms is called and
there's a hook there which the module can use to say ok, does the
audit role have any permissions
Mark Dilger wrote:
I've been going through a copy of the code and replacing int32 and uint32
with the appropriate type such as Oid, TransactionId, and such, and have
created my own typedef for TypeModType, in order to help chase through
the code and figure out what functions handle what kind
Hi all,
Today I spent a bit of time looking at the activity of autovacuum for
one table particularly bloated. log_autovacuum_min_duration was
enabled and set to a high value but even with that I had to deal with
some spam from the jobs of other tables. It would be cool to have the
possibility to
On Wed, Dec 17, 2014 at 8:40 AM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
At the end of archive recovery, we copy the last segment from the old
timeline, to initialize the first segment on the new timeline. For example,
if the timeline switch happens in the middle of WAL segment
On Wed, Dec 17, 2014 at 11:20 AM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
LOG: automatic vacuum of table postgres.public.foo: index scans: 0
pages: 0 removed, 7256 remain, 0 pinned
tuples: 79415 removed, 513156 remain, 0 are dead but not yet
removable
buffer
Abhijit,
* Abhijit Menon-Sen (a...@2ndquadrant.com) wrote:
At 2014-12-16 13:28:07 -0500, sfr...@snowman.net wrote:
The magic audit role has SELECT rights on a given table. When any
user does a SELECT against that table, ExecCheckRTPerms is called and
there's a hook there which the
On Fri, Nov 28, 2014 at 9:07 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Wed, Nov 26, 2014 at 4:05 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Aug 15, 2014 at 8:17 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Fri, Aug 15, 2014 at 3:40 AM, Andres Freund
Michael Paquier wrote:
Hi all,
Today I spent a bit of time looking at the activity of autovacuum for
one table particularly bloated. log_autovacuum_min_duration was
enabled and set to a high value but even with that I had to deal with
some spam from the jobs of other tables. It would be
On 12/18/2014 01:02 AM, Peter Geoghegan wrote:
On Wed, Dec 17, 2014 at 1:12 PM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
Now, let's imagine a table like this:
CREATE TABLE persons (
username text unique,
real_name text unique,
data text
);
Is there any way to specify both of
On Wed, Dec 17, 2014 at 5:00 PM, Stephen Frost sfr...@snowman.net wrote:
Another thought I had was to suggest we consider *everyone* to be a
contributor and implement a way to tie together the mailing list
archives with the commit history and perhaps the commitfest app and make
it searchable
On Thu, Dec 18, 2014 at 8:44 PM, Fabrízio de Royes Mello
fabriziome...@gmail.com wrote:
On Wed, Dec 17, 2014 at 5:00 PM, Stephen Frost sfr...@snowman.net wrote:
Another thought I had was to suggest we consider *everyone* to be a
contributor and implement a way to tie together the
On Thu, Dec 18, 2014 at 5:27 PM, Fujii Masao masao.fu...@gmail.com wrote:
Thanks!
Thanks for your input.
+else
+memcpy(compression_scratch, page, page_len);
I don't think the block image needs to be copied to scratch buffer here.
We can try to compress
Re: Tom Lane 2014-12-16 14615.1418694...@sss.pgh.pa.us
Jim Nasby jim.na...@bluetreble.com writes:
On 12/15/14, 1:39 PM, Christoph Berg wrote:
Well, if it's not interesting, let's just forget it. Sorry.
At the risk of sticking my head in the lions mouth... this is the kind of
response
On Mon, Dec 15, 2014 at 11:06 PM, Peter Geoghegan p...@heroku.com wrote:
On Mon, Dec 15, 2014 at 4:59 PM, Peter Geoghegan p...@heroku.com wrote:
On Mon, Dec 15, 2014 at 4:22 PM, Jeff Janes jeff.ja...@gmail.com
wrote:
Also, in both Linux and MinGW under option 1 patch I get an OID
conflict
On Thu, Dec 18, 2014 at 10:49 AM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
On 12/18/2014 03:53 PM, Robert Haas wrote:
On Wed, Dec 17, 2014 at 8:40 AM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
At the end of archive recovery, we copy the last segment from the old
timeline, to
On Thu, Dec 18, 2014 at 9:20 AM, Jeff Janes jeff.ja...@gmail.com wrote:
After actually reading the documentation more closely, I decided this should
be an error because foo is not a valid table alias in the update set
expression. Instead of being a parsing/planning error, this executes and
On 12/18/14, 7:56 AM, Robert Haas wrote:
On Wed, Dec 17, 2014 at 11:20 AM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
LOG: automatic vacuum of table postgres.public.foo: index scans: 0
pages: 0 removed, 7256 remain, 0 pinned
tuples: 79415 removed, 513156 remain, 0 are
On 12/18/14, 9:21 AM, Tom Lane wrote:
As it stands, no extension can use the numeric type in any non-trivial
way without paying a large penalty for repeated pallocs and data copies.
Given that the ability to write C extensions easily is one of pg's great
strengths, this is a defect that should
On 12/18/2014 04:53 AM, Torsten Zuehlsdorff wrote:
Having your name in a list of other names at the bottom of the release
notes page, without any indication of what you helped with, would work
better? Perhaps it would but I tend to doubt it.
Out of my personal experience in Germany: yes, it
On 12/18/2014 07:31 AM, Andrew Dunstan wrote:
+1
It does feel good to be acknowledged for our work especially when
there is a policy to acknowledge this in our community.
I like this idea but who is going to code our new social network?
Frankly, this coin is going to become so debased
All,
It's sounding like folks would prefer keeing the master contributors
list up to date, to adding a bunch of names to the release notes.
So, then, I have a proposal for criteria for getting on the contributors
list via patch review:
- substantial, deep review of at least one patch (including
Josh Berkus wrote:
So, then, I have a proposal for criteria for getting on the contributors
list via patch review:
- substantial, deep review of at least one patch (including detailed
code review and possible corrections)
- functionality reviews of at least 3 patches, including full
On 12/18/2014 10:37 AM, Alvaro Herrera wrote:
The problem with complicated rules (which these, I think, already are)
is how to keep track of people that helps to which level. I make a
point of crediting reviewers and code contributors in my commit
messages, but can you tell which ones of the
I wrote:
Here's a proposed patch along this line. I left in oid_hash (in the
form of a macro) so that this does not cause any API break for existing
third-party modules. However, no callers in our own code directly
refer to tag_hash or oid_hash anymore.
Committed that version after some
On 19/12/14 07:02, Joshua D. Drake wrote:
On 12/18/2014 04:53 AM, Torsten Zuehlsdorff wrote:
Having your name in a list of other names at the bottom of the release
notes page, without any indication of what you helped with, would work
better? Perhaps it would but I tend to doubt it.
Out of
On Thu, Dec 18, 2014 at 7:51 AM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
On 12/18/2014 05:46 PM, Kevin Grittner wrote:
I don't think either point was ever really settled beyond Robert
and I preferring ON DUPLICATE versus Peter preferring ON CONFLICT.
I also prefer ON CONFLICT,
On 12/18/2014 11:03 AM, Gavin Flower wrote:
Hey Joshua, what does a 'Normal person look like??? :-)
Hahhhahahah, you have to get out of your basement to see them. Usually,
they are at the latest and newest coffee hub, talking about hating
hipsters while wearing skinny jeans and a new
Jim Nasby wrote:
We have to decide on a tradeoff here. Either we end up with two
different log messages (depending on scan_all) that require two
different translations, or we end up with a generic message that isn't
as clear.
The best option I can think of for the later is something like
On 12/18/2014 09:41 PM, Alvaro Herrera wrote:
Jim Nasby wrote:
We have to decide on a tradeoff here. Either we end up with two
different log messages (depending on scan_all) that require two
different translations, or we end up with a generic message that isn't
as clear.
The best option I can
Heikki Linnakangas wrote:
On 12/18/2014 09:41 PM, Alvaro Herrera wrote:
Here's my proposal. Instead of punting, I split the message in
separately translatable units, and emit only the ones that apply. The
code is messier this way, but I think we can live with that.
Works for me.
Great,
Alvaro Herrera alvhe...@2ndquadrant.com writes:
Great, thanks, pushed. I tweaked it a bit more, so that it would say
either skipped N pages or waited N pins in both autovacuum and
vacuum verbose cases, but only if N 0.
Not directly relevant but ... I think probably all those BlockNumber
On 2014-12-18 16:41:04 -0300, Alvaro Herrera wrote:
+ if (scan_all)
+ appendStringInfo(buf, _(waited for %d buffer
pins\n),
+
vacrelstats-pinned_pages);
+ else
Andres Freund wrote:
On 2014-12-18 16:41:04 -0300, Alvaro Herrera wrote:
+ if (scan_all)
+ appendStringInfo(buf, _(waited for %d buffer
pins\n),
+
vacrelstats-pinned_pages);
+
On 12/18/14, 12:08 PM, Joshua D. Drake wrote:
It does feel good to be acknowledged for our work especially when
there is a policy to acknowledge this in our community.
I like this idea but who is going to code our new social network?
+1. I do like the idea; but I don't like it enough to do
On 12/18/14, 3:02 PM, Alvaro Herrera wrote:
Andres Freund wrote:
On 2014-12-18 16:41:04 -0300, Alvaro Herrera wrote:
+ if (scan_all)
+ appendStringInfo(buf, _(waited for %d buffer
pins\n),
+
On 12/18/14, 12:48 PM, Tom Lane wrote:
I wrote:
Here's a proposed patch along this line. I left in oid_hash (in the
form of a macro) so that this does not cause any API break for existing
third-party modules. However, no callers in our own code directly
refer to tag_hash or oid_hash anymore.
On 12/18/2014 03:02 AM, Michael Paquier wrote:
On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Another thing in that patch was that I had to add the sql/ directory to
the source tree, but other than that .gitignore file it was empty.
Maybe pg_regress should
* Andrew Dunstan (and...@dunslane.net) wrote:
On Wed, Dec 17, 2014 at 5:00 PM, Stephen Frost sfr...@snowman.net
mailto:sfr...@snowman.net wrote:
contributors.postgresql.org/sfrost
http://contributors.postgresql.org/sfrost
- Recent commits
- Recent commit
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
Josh Berkus wrote:
So, then, I have a proposal for criteria for getting on the contributors
list via patch review:
- substantial, deep review of at least one patch (including detailed
code review and possible corrections)
-
* Jim Nasby (jim.na...@bluetreble.com) wrote:
On 12/18/14, 12:08 PM, Joshua D. Drake wrote:
It does feel good to be acknowledged for our work especially when
there is a policy to acknowledge this in our community.
I like this idea but who is going to code our new social network?
+1. I
On Tue, Dec 16, 2014 at 11:57:54AM -0500, Tom Lane wrote:
We seem not to have had a new release of 9.2 since July, which is an
awfully long time ago. So, hopefully soon?
Nothing's likely to happen during the holidays, so probably mid-January
is the earliest feasible target.
I agree
On Thu, Dec 18, 2014 at 10:21 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Andrew Gierth and...@tao11.riddles.org.uk writes:
Tom == Tom Lane t...@sss.pgh.pa.us writes:
Tom If you're concerned about arithmetic performance, there is a
Tom very obvious fix here: use double.
Independently of this
Robert Haas wrote:
I think that's ridiculous. You're basically arguing that numeric
doesn't offer meaningful advantages over float8, which flies in the
face of the fact that essentially every database application I've ever
seen uses numeric and I'm not sure I've ever seen one using float8.
On Mon, Dec 15, 2014 at 03:58:39PM +0200, Heikki Linnakangas wrote:
WITH closest_candidates AS (
SELECT
streets.gid,
streets.name,
streets.geom
FROM
nyc_streets streets
ORDER BY
streets.geom -
'SRID=26918;POINT(583571.905921312
Adam,
* Adam Brightwell (adam.brightw...@crunchydatasolutions.com) wrote:
I have attached an updated patch with initial documentation changes for
review.
Awesome, thanks.
I'm going to continue looking at this in more detail, but wanted to
mention a few things I noticed in the documentation
FWIW I've been giving this patch a look and and adjusting some coding
details here and there. Do you intend to commit it yourself? You're
not listed as reviewer or committer for it in the commitfest app, FWIW.
One thing I don't very much like is that check_role_attribute() receives
a RoleAttr
Alvaro,
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
FWIW I've been giving this patch a look and and adjusting some coding
details here and there. Do you intend to commit it yourself? You're
not listed as reviewer or committer for it in the commitfest app, FWIW.
Oh, great, thanks!
Robert Haas robertmh...@gmail.com writes:
On Thu, Dec 18, 2014 at 10:21 AM, Tom Lane t...@sss.pgh.pa.us wrote:
As the guy who last fooled with the numeric calculation algorithms in any
major way, I'm painfully aware that numeric is not necessarily more
accurate than double for anything more
On Tue, Dec 16, 2014 at 01:05:31AM -0300, Alvaro Herrera wrote:
Noah Misch wrote:
On Mon, Dec 15, 2014 at 12:12:10AM -0800, Michael Paquier wrote:
FWIW, I just tried that with MinGW-32 and I can see the error on Win7.
I also checked that changing now() to = now() fixed the
problem,
On 2014-12-18 10:02:25 -0800, Joshua D. Drake wrote:
I think a lot of hackers forget exactly how tender their egos are. Now I say
this knowing that a lot of them will go, Oh give me a break but as someone
who employs hackers, deals with open source AND normal people :P every
single day, I can
On 2014-12-18 16:05:23 -0600, Jim Nasby wrote:
On 12/18/14, 3:02 PM, Alvaro Herrera wrote:
Andres Freund wrote:
On 2014-12-18 16:41:04 -0300, Alvaro Herrera wrote:
+ if (scan_all)
+ appendStringInfo(buf, _(waited for %d buffer
pins\n),
+
70 matches
Mail list logo
