Re: [HACKERS] pg_regress writes into source tree

2015-02-13 Thread Michael Paquier
On Sat, Feb 14, 2015 at 6:24 AM, Andrew Dunstan wrote: > > On 12/18/2014 06:05 PM, Andrew Dunstan wrote: >> >> >> On 12/18/2014 03:02 AM, Michael Paquier wrote: >>> >>> On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera >>> wrote: >>> Another thing in that patch was that I had to add the sql/

Re: [HACKERS] Strange assertion using VACOPT_FREEZE in vacuum.c

2015-02-13 Thread Michael Paquier
On Sat, Feb 14, 2015 at 8:10 AM, Jim Nasby wrote: > > On 2/12/15 10:54 PM, Michael Paquier wrote: >> >> Hi all, >> >> When calling vacuum(), there is the following assertion using VACOPT_FREEZE: >> Assert((vacstmt->options & VACOPT_VACUUM) || >> !(vacstmt->options & (VACOPT_FULL | VACOPT_FREEZ

Re: [HACKERS] assessing parallel-safety

2015-02-13 Thread Noah Misch
On Fri, Feb 13, 2015 at 05:13:06PM -0500, Robert Haas wrote: > On Fri, Feb 13, 2015 at 12:10 AM, Noah Misch wrote: > > Given your wish to optimize, I recommend first investigating the earlier > > thought to issue eval_const_expressions() once per planner() instead of once > > per subquery_planner(

Re: [HACKERS] Support UPDATE table SET(*)=...

2015-02-13 Thread Atri Sharma
Hi all, Sorry for the delay. Please find attached latest version of UPDATE (*) patch.The patch implements review comments and Tom's gripe about touching transformTargetList is addressed now. I have added regression tests and simplified parser representation a bit. Regards, Atri diff --git a/doc

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE} 2.0

2015-02-13 Thread Jim Nasby
On 2/9/15 6:21 PM, Peter Geoghegan wrote: Thanks for taking a look at it. That's somewhat cleaned up in the attached patchseries - V2.2. In patch 1, "sepgsql is also affected by this commit. Note that this commit necessitates an initdb, since stored ACLs are broken." Doesn't that warrant bump

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-02-13 Thread Jim Nasby
On 2/13/15 2:04 AM, Martijn van Oosterhout wrote: On Thu, Feb 12, 2015 at 08:52:56AM -0500, Robert Haas wrote: > >BTW, I'm not all that thrilled with the "deserialized object" terminology. > >I found myself repeatedly tripping up on which form was serialized and > >which de-. If anyone's got a

Re: [HACKERS] "multiple backends attempting to wait for pincount 1"

2015-02-13 Thread Andres Freund
On 2015-02-13 23:05:16 +, Kevin Grittner wrote: > Andres Freund wrote: > > > How did you get to that recipe? > > I have been working on some patches to allow vacuum to function in > the face of long-held snapshots. (I'm struggling to get them into > presentable shape for the upcoming CF.)

Re: [HACKERS] Strange assertion using VACOPT_FREEZE in vacuum.c

2015-02-13 Thread Jim Nasby
On 2/12/15 10:54 PM, Michael Paquier wrote: Hi all, When calling vacuum(), there is the following assertion using VACOPT_FREEZE: Assert((vacstmt->options & VACOPT_VACUUM) || !(vacstmt->options & (VACOPT_FULL | VACOPT_FREEZE))); I think that this should be changed with sanity checks based on

Re: [HACKERS] "multiple backends attempting to wait for pincount 1"

2015-02-13 Thread Kevin Grittner
Andres Freund wrote: > How did you get to that recipe? I have been working on some patches to allow vacuum to function in the face of long-held snapshots. (I'm struggling to get them into presentable shape for the upcoming CF.) I was devising the most diabolical cases I could to try to break m

Re: [HACKERS] "multiple backends attempting to wait for pincount 1"

2015-02-13 Thread Andres Freund
On 2015-02-13 22:33:35 +, Kevin Grittner wrote: > Andres Freund wrote: > > On 2015-02-13 00:27:04 -0500, Tom Lane wrote: > > >> I'd say we have a problem. I'd even go so far as to say that > >> somebody has completely broken locking, because this looks like > >> autovacuum and manual vacuumi

Re: [HACKERS] "multiple backends attempting to wait for pincount 1"

2015-02-13 Thread Kevin Grittner
Andres Freund wrote: > On 2015-02-13 00:27:04 -0500, Tom Lane wrote: >> I'd say we have a problem. I'd even go so far as to say that >> somebody has completely broken locking, because this looks like >> autovacuum and manual vacuuming are hitting the same table at >> the same time. > One avenue

Re: [HACKERS] question on Postgres smart shutdown mode

2015-02-13 Thread Robert Haas
On Fri, Feb 13, 2015 at 2:15 AM, wei sun wrote: > I have a question on PG smart shutdown mode. > > When shutdown Postgres by issuing Smart Shutdown mode (SIGTERM) request, is > there a way for client to be notified of this shutdown event? I tried > PG_NOTIFY, but I cannot get any notification even

Re: [HACKERS] assessing parallel-safety

2015-02-13 Thread Robert Haas
On Fri, Feb 13, 2015 at 12:10 AM, Noah Misch wrote: > Given your wish to optimize, I recommend first investigating the earlier > thought to issue eval_const_expressions() once per planner() instead of once > per subquery_planner(). Compared to the parallelModeRequired/parallelModeOK > idea, it wo

Re: [HACKERS] SSL renegotiation and other related woes

2015-02-13 Thread Heikki Linnakangas
On 02/12/2015 01:41 AM, Andres Freund wrote: Hi, On 2015-02-05 23:03:02 +0200, Heikki Linnakangas wrote: On 01/26/2015 12:14 PM, Andres Freund wrote: Hi, When working on getting rid of ImmediateInterruptOK I wanted to verify that ssl still works correctly. Turned out it didn't. But neither di

Re: [HACKERS] RangeType internal use

2015-02-13 Thread David Fetter
On Fri, Feb 13, 2015 at 03:13:11PM -0600, Jim Nasby wrote: > On 2/10/15 2:04 PM, David Fetter wrote: > >Yeah, but people expect to be able to partition on ranges that are not > >all of equal width. I think any proposal that we shouldn't support > >that is the kiss of death for a fea

Re: [HACKERS] RangeType internal use

2015-02-13 Thread Mike Blackwell
On Fri, Feb 13, 2015 at 3:13 PM, Jim Nasby wrote: > > If we exclude the issue of needing one or two oddball partitions for +/- > infinity, I expect that fixed sized partitions would actually cover 80-90% > of cases. ​That would not be true in our case. The data is not at all evenly distributed

Re: [HACKERS] pg_regress writes into source tree

2015-02-13 Thread Andrew Dunstan
On 12/18/2014 06:05 PM, Andrew Dunstan wrote: On 12/18/2014 03:02 AM, Michael Paquier wrote: On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera wrote: Another thing in that patch was that I had to add the sql/ directory to the source tree, but other than that .gitignore file it was empty. May

Re: [HACKERS] RangeType internal use

2015-02-13 Thread Jim Nasby
On 2/10/15 2:04 PM, David Fetter wrote: > >Yeah, but people expect to be able to partition on ranges that are not > >all of equal width. I think any proposal that we shouldn't support > >that is the kiss of death for a feature like this - it will be so > >restricted as to eliminate 75% of the us

Re: [HACKERS] Refactoring GUC unit conversions

2015-02-13 Thread Jim Nasby
On 2/13/15 11:44 AM, Heikki Linnakangas wrote: On 02/13/2015 07:34 PM, Jim Nasby wrote: On 2/13/15 7:26 AM, Heikki Linnakangas wrote: In the "redesign checkpoint_segments" patch, Robert suggested keeping the settings' base unit as "number of segments", but allow conversions from MB, GB etc. I s

[HACKERS] why does find_my_exec resolve symlinks?

2015-02-13 Thread Peter Eisentraut
Here is a scenario: ./configure --prefix=/usr/local/pgsql/9.4.1 make make install ln -s 9.4.1 /usr/local/pgsql/9.4 PATH=/usr/local/pgsql/9.4/bin:$PATH And then when 9.4.2 comes out, the symlink is updated. I think this sort of setup in variations is not uncommon. When building other software ag

Re: [HACKERS] pg_basebackup may fail to send feedbacks.

2015-02-13 Thread Fujii Masao
On Tue, Feb 10, 2015 at 7:48 PM, Kyotaro HORIGUCHI wrote: > Hello, > > The attached patch is fix for walreciever not using gettimeofday, > and fix for receivelog using it. > >> > XLogWalRcvProcessMsg doesn't send feedback when processing >> > 'w'=WAL record packet. So the same thing as pg_baseback

Re: [HACKERS] Refactoring GUC unit conversions

2015-02-13 Thread Heikki Linnakangas
On 02/13/2015 07:34 PM, Jim Nasby wrote: On 2/13/15 7:26 AM, Heikki Linnakangas wrote: In the "redesign checkpoint_segments" patch, Robert suggested keeping the settings' base unit as "number of segments", but allow conversions from MB, GB etc. I started looking into that and found that adding a

Re: [HACKERS] Redesigning checkpoint_segments

2015-02-13 Thread Heikki Linnakangas
On 02/04/2015 11:41 PM, Josh Berkus wrote: On 02/04/2015 12:06 PM, Robert Haas wrote: On Wed, Feb 4, 2015 at 1:05 PM, Josh Berkus wrote: Let me push "max_wal_size" and "min_wal_size" again as our new parameter names, because: * does what it says on the tin * new user friendly * encourages peo

Re: [HACKERS] Refactoring GUC unit conversions

2015-02-13 Thread Jim Nasby
On 2/13/15 7:26 AM, Heikki Linnakangas wrote: In the "redesign checkpoint_segments" patch, Robert suggested keeping the settings' base unit as "number of segments", but allow conversions from MB, GB etc. I started looking into that and found that adding a new unit to guc.c is quite messy. The con

Re: [HACKERS] compress method for spgist - 2

2015-02-13 Thread Teodor Sigaev
Now that the input data type and leaf data type can be different, which one is "attType"? It's the leaf data type, as the patch stands. I renamed that to attLeafType, and went fixing all the references to it. In most places it's just a matter of search & replace, but what about the reconstructed d

Re: [HACKERS] GSoC 2015 - mentors, students and admins.

2015-02-13 Thread Thom Brown
On 12 February 2015 at 14:55, Alexander Korotkov wrote: > Hi! > > On Mon, Feb 9, 2015 at 11:52 PM, Thom Brown wrote: > >> Google Summer of Code 2015 is approaching. I'm intending on registering >> PostgreSQL again this year. >> >> Before I do that, I'd like to have an idea of how many people ar

Re: [HACKERS] Help me! Why did the salve stop suddenly ?

2015-02-13 Thread Robert Haas
On Thu, Feb 12, 2015 at 3:27 AM, hailong Li wrote: > Hi, dear pgsql-hackers Please have a look at https://wiki.postgresql.org/wiki/Guide_to_reporting_problems This is the wrong mailing list for this sort of question, and your report is pretty unclear, so it's hard to tell what might have gone wr

[HACKERS] anyarray

2015-02-13 Thread Teodor Sigaev
Some of users of intarray contrib module wish to use its features with another kind of arrays, not only for int4 type. Suggested module generalizes intarray over other (not all) types op pgsql. Anyarray also provides a calculation of similarity two one dimensinal arrays similar to smlar module

[HACKERS] Refactoring GUC unit conversions

2015-02-13 Thread Heikki Linnakangas
In the "redesign checkpoint_segments" patch, Robert suggested keeping the settings' base unit as "number of segments", but allow conversions from MB, GB etc. I started looking into that and found that adding a new unit to guc.c is quite messy. The conversions are done with complicated if-switch

Re: [HACKERS] Using 128-bit integers for sum, avg and statistics aggregates

2015-02-13 Thread Michael Paquier
On Thu, Jan 29, 2015 at 8:28 AM, Peter Geoghegan wrote: > On Mon, Jan 26, 2015 at 11:21 PM, Andreas Karlsson > wrote: > > Do you also think the SQL functions should be named numeric_int128_sum, > > numeric_int128_avg, etc? > > Some quick review comments. These apply to int128-agg-v5.patch. > An

Re: [HACKERS] Logical Replication Helpers WIP for discussion

2015-02-13 Thread Petr Jelinek
On 13/02/15 08:48, Michael Paquier wrote: On Mon, Dec 22, 2014 at 10:26 PM, Robert Haas mailto:robertmh...@gmail.com>> wrote: On Fri, Dec 19, 2014 at 8:40 AM, Petr Jelinek mailto:p...@2ndquadrant.com>> wrote: > What I hope to get from this is agreement on the general approach and >

Re: [HACKERS] PATCH: decreasing memory needlessly consumed by array_agg

2015-02-13 Thread Michael Paquier
On Thu, Jan 29, 2015 at 7:25 AM, Tomas Vondra wrote: > attached is v9 of the patch, modified along the lines of Tom's comments: > Moved this patch to next CF, hopefully it will get more attention, and a reviewer. -- Michael

Re: [HACKERS] BRIN range operator class

2015-02-13 Thread Michael Paquier
On Thu, Feb 12, 2015 at 3:34 AM, Emre Hasegeli wrote: > Thank you for looking at my patch again. New version is attached > with a lot of changes and point data type support. Patch is moved to next CF 2015-02 as work is still going on. -- Michael

Re: [HACKERS] SSL information view

2015-02-13 Thread Michael Paquier
On Fri, Feb 13, 2015 at 5:31 PM, Magnus Hagander wrote: > > On Fri, Feb 13, 2015 at 9:07 AM, Michael Paquier > wrote: > >> Magnus, are you planning to work on this item of your shame list soon? >> Could you clarify the status of this patch? > > > I do, and I hope to work on it over the next week o

Re: [HACKERS] Odd behavior of updatable security barrier views on foreign tables

2015-02-13 Thread Stephen Frost
Etsuro, * Etsuro Fujita (fujita.ets...@lab.ntt.co.jp) wrote: > On 2015/02/11 4:06, Stephen Frost wrote: > >* Etsuro Fujita (fujita.ets...@lab.ntt.co.jp) wrote: > >>On 2015/02/10 7:23, Dean Rasheed wrote: > >>>Sorry, I didn't have time to look at this properly. My initial thought > >>>is that expan

[HACKERS] chkpass with RANDOMIZE_ALLOCATED_MEMORY

2015-02-13 Thread Asif Naeem
Hi, It is been observed on RANDOMIZE_ALLOCATED_MEMORY enabled PG95 build that chkpass is failing because of uninitialized memory and seems showing false alarm. I have tried to add code snippets to explain as following i.e. postgres=# CREATE EXTENSION chkpass; > WARNING: type input function chkpa

[HACKERS] question on Postgres smart shutdown mode

2015-02-13 Thread Bo Tian
Hi All, I have a question on PG smart shutdown mode. When shutdown Postgres by issuing Smart Shutdown mode (SIGTERM) request, is there a way for client to be notified of this shutdown event? I tried PG_NOTIFY, but I cannot get any notification events when this happens. BTW, I am relative new to

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-02-13 Thread Kouhei Kaigai
> Sorry I typed the wrong key. > > So... Are you planning to give up on the ctidscan module and submit only > the module written by Hanada-san on top of postgres_fdw? As I imagine that > the goal is just to have a test module to run the APIs why would the module > submitted by Hanada-san be that n

Re: [HACKERS] gcc5: initdb produces gigabytes of _fsm files

2015-02-13 Thread Geoff Winkless
What does the ASM look like? It's a fairly quick way to tell whether the fail is optimization or memory corruption. Apologies if I'm explaining how to extract albumen to your elderly relative... On 12 February 2015 at 23:16, Tom Lane wrote: > I wrote: > > Christoph Berg writes: > >> gcc5 is lu

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-02-13 Thread Michael Paquier
On Fri, Feb 13, 2015 at 6:12 PM, Michael Paquier wrote: > > > On Fri, Feb 13, 2015 at 4:59 PM, Kouhei Kaigai > wrote: > >> > Where are we on this? AFAIK, we have now a feature with no documentation >> > and no example in-core to test those custom routine APIs, hence moved to >> > next CF. >> > >

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-02-13 Thread Michael Paquier
On Fri, Feb 13, 2015 at 4:59 PM, Kouhei Kaigai wrote: > > Where are we on this? AFAIK, we have now a feature with no documentation > > and no example in-core to test those custom routine APIs, hence moved to > > next CF. > > > Now Hanada-san is working on the example module that use this new > in

Re: [HACKERS] "multiple backends attempting to wait for pincount 1"

2015-02-13 Thread Andres Freund
On 2015-02-13 00:27:04 -0500, Tom Lane wrote: > Two different CLOBBER_CACHE_ALWAYS critters recently reported exactly > the same failure pattern on HEAD: > > http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=markhor&dt=2015-02-06%2011%3A59%3A59 > http://buildfarm.postgresql.org/cgi-bin/show_l

[HACKERS] restrict global access to be readonly

2015-02-13 Thread happy times
Hi PG Developers, I didn’t find any convenient way to restrict access to PostgreSQL databases to be read-only for all users. I need it in following scenarios: A) Planned switch-over from master to slave. We want to minimize impact within the planned switch-overs. So during the process we swit

Re: [HACKERS] SSL information view

2015-02-13 Thread Magnus Hagander
On Fri, Feb 13, 2015 at 9:07 AM, Michael Paquier wrote: > > > On Tue, Feb 3, 2015 at 9:36 PM, Magnus Hagander > wrote: > >> >> On Tue, Feb 3, 2015 at 6:42 AM, Michael Paquier < >> michael.paqu...@gmail.com> wrote: >> >>> Where are we on this patch? No new version has been provided and there >>>

Re: [HACKERS] assessing parallel-safety

2015-02-13 Thread Amit Kapila
On Fri, Feb 13, 2015 at 2:40 AM, Robert Haas wrote: > > On Thu, Feb 12, 2015 at 3:52 PM, Amit Kapila wrote: > >> Probably not, because many queries will scan multiple relations, and > >> we want to do all of this work just once per query. > > > > By this, do you mean to say that if there is any p

Re: [HACKERS] Review of GetUserId() Usage

2015-02-13 Thread Michael Paquier
On Fri, Dec 5, 2014 at 11:28 PM, Stephen Frost wrote: > * Stephen Frost (sfr...@snowman.net) wrote: > > * Stephen Frost (sfr...@snowman.net) wrote: > > > > 3. It messes around with pg_signal_backend(). There are currently no > > > > cases in which pg_signal_backend() throws an error, which is go

Re: [HACKERS] Patch to support SEMI and ANTI join removal

2015-02-13 Thread Michael Paquier
On Fri, Feb 13, 2015 at 5:12 PM, Andres Freund wrote: > On 2015-02-13 17:06:14 +0900, Michael Paquier wrote: > > On Fri, Feb 13, 2015 at 4:57 PM, Marko Tiikkaja wrote: > > > > > On 2/13/15 8:52 AM, Michael Paquier wrote: > > > > > >> On Sun, Nov 23, 2014 at 8:23 PM, David Rowley > > >> wrote: >

Re: [HACKERS] [PATCH] add ssl_protocols configuration option

2015-02-13 Thread Michael Paquier
On Thu, Jan 15, 2015 at 4:17 PM, Michael Paquier wrote: > On Mon, Dec 15, 2014 at 11:15 PM, Alex Shulgin > wrote: > > Michael Paquier writes: > > Perhaps ssloptions.[ch], unless you plan to add non-option-related > code > there later? > >>> > >>> I don't think anything else than

Re: [HACKERS] Patch to support SEMI and ANTI join removal

2015-02-13 Thread Andres Freund
On 2015-02-13 17:06:14 +0900, Michael Paquier wrote: > On Fri, Feb 13, 2015 at 4:57 PM, Marko Tiikkaja wrote: > > > On 2/13/15 8:52 AM, Michael Paquier wrote: > > > >> On Sun, Nov 23, 2014 at 8:23 PM, David Rowley > >> wrote: > >> > >>> As the patch stands there's still a couple of FIXMEs in the

Re: [HACKERS] pg_rewind in contrib

2015-02-13 Thread Michael Paquier
On Mon, Jan 19, 2015 at 2:50 PM, Michael Paquier wrote: > On Mon, Jan 19, 2015 at 2:38 PM, Michael Paquier > wrote: > > Heikki Linnakangas wrote: > >> Addressed most of your comments, and Michael's. Another version > attached. > > Extra thing: src/bin/pg_rewind/Makefile surely forgets to clean u

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE} 2.0

2015-02-13 Thread Michael Paquier
On Tue, Feb 10, 2015 at 9:21 AM, Peter Geoghegan wrote: > * There was some squashing of commits, since Andres felt that they > weren't all useful as separate commits. I've still split out the RTE > permissions commit, as well as the RLS commit (plus the documentation > and test commits, FWIW). I

Re: [HACKERS] SSL information view

2015-02-13 Thread Michael Paquier
On Tue, Feb 3, 2015 at 9:36 PM, Magnus Hagander wrote: > > On Tue, Feb 3, 2015 at 6:42 AM, Michael Paquier > wrote: > >> Where are we on this patch? No new version has been provided and there >> have been comments provided by Heikki here >> (5491e547.4040...@vmware.com) and by Alexei here >> (87

Re: [HACKERS] Patch to support SEMI and ANTI join removal

2015-02-13 Thread Michael Paquier
On Fri, Feb 13, 2015 at 4:57 PM, Marko Tiikkaja wrote: > On 2/13/15 8:52 AM, Michael Paquier wrote: > >> On Sun, Nov 23, 2014 at 8:23 PM, David Rowley >> wrote: >> >>> As the patch stands there's still a couple of FIXMEs in there, so there's >>> still a bit of work to do yet. >>> Comments are we

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-02-13 Thread Martijn van Oosterhout
On Thu, Feb 12, 2015 at 08:52:56AM -0500, Robert Haas wrote: > > BTW, I'm not all that thrilled with the "deserialized object" terminology. > > I found myself repeatedly tripping up on which form was serialized and > > which de-. If anyone's got a better naming idea I'm willing to adopt it. > > M

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-02-13 Thread Kouhei Kaigai
> Where are we on this? AFAIK, we have now a feature with no documentation > and no example in-core to test those custom routine APIs, hence moved to > next CF. > Now Hanada-san is working on the example module that use this new infrastructure on top of postgres_fdw. Probably, he will submit the pa

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-02-13 Thread Michael Paquier
On Tue, Jan 27, 2015 at 6:08 PM, Abhijit Menon-Sen wrote: > Anyway, I think it's reasonably clear now that pgaudit is unlikely to > make it into 9.5 in any form, so I'll find something else to do. > Well, I am marking this patch as rejected then... Let's in any case the discussion continue. Perh