Re: [HACKERS] small fix to possible null pointer dereference in byteaout() varlena.c

2010-09-28 Thread Grzegorz Jaśkiewicz
got it folks. Forgot that elog doesn't return with ERROR -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] small fix to possible null pointer dereference in byteaout() varlena.c

2010-09-28 Thread Grzegorz Jaśkiewicz
2010/9/28 Tom Lane : > =?UTF-8?Q?Grzegorz_Ja=C5=9Bkiewicz?= writes: >> It would crash if input is of unrecognized format. Probably than >> there's going to be more problems to be concerned with, but just in >> case, don't crash in > > I'm not sure why you think this is a good change, but it would

[HACKERS] small fix to possible null pointer dereference in byteaout() varlena.c

2010-09-28 Thread Grzegorz Jaśkiewicz
It would crash if input is of unrecognized format. Probably than there's going to be more problems to be concerned with, but just in case, don't crash in -- GJ diff --git a/src/backend/utils/adt/varlena.c b/src/backend/utils/adt/varlena.c index 363fd3c..48ee55d 100644 --- a/src/backend/utils/adt/

Re: [HACKERS] cvs head doesn't pass make check on one of the machines here

2009-11-13 Thread Grzegorz Jaśkiewicz
Dnia czwartek 12 listopad 2009 o 22:14:14 Andrew Dunstan napisał(a): > Grzegorz Jaskiewicz wrote: > > consistently fails when compiled on ubuntu 9.10 here (on mini 10v). > > + ERROR: incompatible library > "/home/kgrittn/postgresql-8.4.0/src/test/regress/refint.so": version > mismatch > + DETAIL

Re: [HACKERS] overlaps performance

2008-07-21 Thread Grzegorz Jaśkiewicz
Tom Lane pisze: The reason we don't automatically translate OVERLAPS is that the spec's definition of OVERLAPS is too weird for that to work; in particular it demands a true result for some cases in which one of the four endpoints is NULL, which'd be pretty hard to do with an interval-style index

Re: [HACKERS] overlaps performance

2008-07-21 Thread Grzegorz Jaśkiewicz
Gregory Stark pisze: Grzegorz Jaśkiewicz <[EMAIL PROTECTED]> writes: So my question would be, why isn't postgresql using indexes for OVERLAPS, and why optimizer doesn't substitute it with something like: (c <= a AND d > a) OR ( c >= a AND c < b) How would you us

[HACKERS] overlaps performance

2008-07-21 Thread Grzegorz Jaśkiewicz
Hey guys, I am asking here, because I know there is bunch of people here that know the topic very well. I need to use few 'overlaps' for timedate in my query. And I guess it is quite inefficient there. So my question would be, why isn't postgresql using indexes for OVERLAPS, and why optimizer