2014-03-17 13:24 GMT+09:00 Josh Berkus j...@agliodbs.com:
... attached. Please correct!
A couple of drive-by corrections:
each of their standy databases
standy - standby
Prevent erroneous operator push-down in pgsql_fdw
pgsql_fdw - postgres_fdw
Regards
Ian Barwick
--
Sent via
2014-03-05 23:27 GMT+09:00 Andrew Dunstan and...@dunslane.net:
On 03/05/2014 09:11 AM, Michael Paquier wrote:
After testing this feature, I noticed that FORCE_NULL and
FORCE_NOT_NULL can both be specified with COPY on the same column.
This does not seem correct. The attached patch adds some
2014-03-02 8:26 GMT+09:00 Andrew Dunstan and...@dunslane.net:
On 01/29/2014 10:59 AM, Ian Lawrence Barwick wrote:
2014/1/29 Ian Lawrence Barwick barw...@gmail.com:
2014-01-29 Andrew Dunstan and...@dunslane.net:
On 01/28/2014 05:55 AM, Ian Lawrence Barwick wrote:
Hi Payal
Many thanks
2014-02-20 16:16 GMT+09:00 Ashutosh Bapat ashutosh.ba...@enterprisedb.com:
Hi All,
Here is a strange behaviour with master branch with head at
(...)
Looks like a bug in psql to me. Does anybody see that behaviour?
It's not a bug, it's your VM's OS killing off a process which is using
up too
2014/1/29 Ian Lawrence Barwick barw...@gmail.com:
2014-01-29 Andrew Dunstan and...@dunslane.net:
On 01/28/2014 05:55 AM, Ian Lawrence Barwick wrote:
Hi Payal
Many thanks for the review, and my apologies for not getting back to
you earlier.
Updated version of the patch attached
2013-11-01 Payal Singh pa...@omniti.com:
The post was made before I subscribed to the mailing list, so posting my
review separately. The link to the original patch mail is
http://www.postgresql.org/message-id/CAB8KJ=jS-Um4TGwenS5wLUfJK6K4rNOm_V6GRUj+tcKekL2=g...@mail.gmail.com
Hi,
This
2014-01-29 Andrew Dunstan and...@dunslane.net:
On 01/28/2014 05:55 AM, Ian Lawrence Barwick wrote:
Hi Payal
Many thanks for the review, and my apologies for not getting back to
you earlier.
Updated version of the patch attached with suggested corrections.
On a very quick glance, I see
Presumably classifyConditions, not classifyClauses, is meant.
Patch attached.
Regards
Ian Barwick
diff --git a/contrib/postgres_fdw/postgres_fdw.c
b/contrib/postgres_fdw/postgres_fdw.c
index 246a3a9..46ea032 100644
--- a/contrib/postgres_fdw/postgres_fdw.c
+++
2013/11/8 Tom Lane t...@sss.pgh.pa.us:
Albe Laurenz laurenz.a...@wien.gv.at writes:
What I would like to do is add a custom resjunk column
(e.g. a bytea) in AddForeignUpdateTargets that carries a row identifier
from the scan state to the modify state.
Would that be possible? Can I have
2013/12/5 Albe Laurenz laurenz.a...@wien.gv.at:
Ian Lawrence Barwick wrote:
2013/11/8 Tom Lane t...@sss.pgh.pa.us:
[ thinks for awhile... ] Hm. In principle you can put any expression
you want into the tlist during AddForeignUpdateTargets. However, if it's
not a Var then the planner won't
2013/11/20 Tom Lane t...@sss.pgh.pa.us:
Robert Haas robertmh...@gmail.com writes:
On Mon, Nov 18, 2013 at 9:39 AM, Ian Lawrence Barwick barw...@gmail.com
wrote:
I'd expect this to lead to a failed transaction block,
or at least some sort of notice that the transaction itself
has been rolled
Review for Andrew Dunstan's patch in CF 2013-11:
https://commitfest.postgresql.org/action/patch_view?id=1312
This review is more from a usage point of view, I would like
to spend more time looking at the code but only so many hours in a day,
etcetera; I hope this is useful as-is.
Submission
Review for Pavel Stehule's patch in CF 2013-11:
https://commitfest.postgresql.org/action/patch_view?id=1253
Patch applies cleanly and works as intended; it's a very straightforward
patch so no surprises there.
The patch expands the range of completable items for \pset, putting
them in
2013/11/6 Albe Laurenz laurenz.a...@wien.gv.at:
I have a question concerning the Foreign Data Wrapper API:
I find no mention of this in the documentation, but I remember that
you can only add a resjunk column that matches an existing attribute
of the foreign table and not one with an
2013/10/9 Andrew Dunstan and...@dunslane.net:
On 10/08/2013 12:47 PM, Andrew Dunstan wrote:
On 10/08/2013 12:30 PM, Robert Haas wrote:
Andrew, are you planning to review commit this?
Yes.
Incidentally, the patch doesn't seem to add the option to file_fdw, which I
really think it
Hi
2013/9/30 Gilles Darold gilles.dar...@dalibo.com:
(...)
That's right, here is the patch modified with just a little change with
your suggestion:
if (popt-topt.numericLocale)
printf(_(Locale-adjusted numeric output (%s) is
on.\n), param);
Hi,
This patch implements the following TODO item:
Allow COPY in CSV mode to control whether a quoted zero-length
string is treated as NULL
Currently this is always treated as a zero-length string,
which generates an error when loading into an integer column
Re:
Hi
Sorry for the delay on following up on this.
2013/9/18 Marko Tiikkaja ma...@joh.to:
Hi,
Attached is a patch with the following changes:
On 16/09/2013 10:57, I wrote:
On 9/16/13 8:04 AM, Ian Lawrence Barwick wrote:
However the sample function provided in the documentation throws
Attached.
Regards
Ian Barwick
psql-command-c-typo.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
2013/9/15 Marko Tiikkaja ma...@joh.to:
Attached an updated patch to fix the tabs and to change this to a
compile-time option. Now it's not possible to flexibly disable the feature
during runtime, but I think that's fine.
I'm taking a look at this patch as part of the current commitfest [*],
2013/9/16 David Fetter da...@fetter.org:
has begun!
New hackers, this is your chance to contribute by doing the first few
steps of review. Seasoned hackers, this is a way to help the whole
project along. You know the drill.
Too many patches have Nobody today. That's the first thing we'll
2013/9/10 Bruce Momjian br...@momjian.us:
On Tue, Jan 22, 2013 at 07:30:59PM -0500, Tom Lane wrote:
Ian Lawrence Barwick barw...@gmail.com writes:
Related email from the archives on this subject:
http://www.postgresql.org/message-id/37ed240d0611200645l5b70c8ddw5fb735e0d35a7...@mail.gmail.com
2013/8/4 Erik Rijkers e...@xs4all.nl:
On Sun, August 4, 2013 04:51, Ian Lawrence Barwick wrote:
I just noticed that pg_restore executing in verbose mode displays the
name of the object being restored, but not its schema.
Good idea. We have many schemata with tables of the same name
2013/8/4 Ian Lawrence Barwick barw...@gmail.com:
2013/8/4 Erik Rijkers e...@xs4all.nl:
On Sun, August 4, 2013 04:51, Ian Lawrence Barwick wrote:
I just noticed that pg_restore executing in verbose mode displays the
name of the object being restored, but not its schema.
Good idea. We have
I just noticed that pg_restore executing in verbose mode displays the
name of the object being restored, but not its schema.
I'd like to be able to see the fully-qualified object name because
if pg_restore spits out a warning like this:
$ pg_restore -d somedb /path/to/dumpfile.pgd
I noticed an instance of 'appendPQExpBuffer(query, ;);' in pg_dump.c which
seems pointless and mildly confusing. There's another seemingly
useless one in pg_dumpall.c. Attached patch removes both (if that
makes any sense).
Regards
Ian Barwick
pg_dump-cull-semicolons.patch
Description: Binary
2013/5/8 Robert Haas robertmh...@gmail.com:
On Thu, May 2, 2013 at 7:53 PM, Bruce Momjian br...@momjian.us wrote:
OK, what other database supports British spelling of commands? Can we
call this a compatibility feature. ;-) The feature has been there
since 2000:
commit
2013/4/24 Bruce Momjian br...@momjian.us:
Thanks for the many suggestions on improving the 9.3 release notes.
There were many ideas I would have never thought of. Please keep the
suggestions coming.
One small suggestion:
listitem
para
Have quotesession id/ (literal%c/)
2013/5/4 Bruce Momjian br...@momjian.us:
On Sat, May 4, 2013 at 08:34:18PM +0900, Ian Lawrence Barwick wrote:
2013/4/24 Bruce Momjian br...@momjian.us:
Thanks for the many suggestions on improving the 9.3 release notes.
There were many ideas I would have never thought of. Please keep
2013/5/5 Bruce Momjian br...@momjian.us:
(...)
This is such a minor change I am trying to keep it short.
Just out of curiosity, what was the reason for the change in the first place?
(Not that it's something I'm particularly passionate about, I just noticed it
when listing changes with
I guess the 9.2.4 release notes haven't been finalized yet; apologies
if this is already addressed, but following sentence:
para
Also, if you are upgrading from a version earlier than 9.2.2,
see the release notes for 9.2.2.
/para
should read:
para
Also, if you are upgrading
2013/4/4 Tom Lane t...@sss.pgh.pa.us:
Ian Lawrence Barwick barw...@gmail.com writes:
I guess the 9.2.4 release notes haven't been finalized yet; apologies
if this is already addressed, but following sentence:
para
Also, if you are upgrading from a version earlier than 9.2.2,
see
I found this sentence somewhat confusing:
It is possible for a column's value to change even when the trigger
is not fired,
http://www.postgresql.org/docs/devel/static/sql-createtrigger.html#SQL-CREATETRIGGER-NOTES
More precise would be something along the lines It is possible that
changes to
2013/2/22 Andrew Dunstan and...@dunslane.net:
On 02/21/2013 12:56 PM, Magnus Hagander wrote:
On Thu, Feb 21, 2013 at 6:39 PM, Robert Haas robertmh...@gmail.com
wrote:
On Wed, Feb 20, 2013 at 11:58 AM, Ian Lawrence Barwick
barw...@gmail.com wrote:
I'm not sure if this is a documentation
Hi
I'm not sure if this is a documentation or hackers issue, but the
documentation page for contrib module xml2 refers to PostgreSQL 8.4 in
the future tense:
It is planned that this module will be removed in PostgreSQL 8.4 in
favor of the newer standard API
2013/2/14 Tom Lane t...@sss.pgh.pa.us:
Stephen Frost sfr...@snowman.net writes:
* Pavel Stehule (pavel.steh...@gmail.com) wrote:
SELECT * FROM some_relation LIMIT 10
what do you thinking about creating special statement for this purpose?
I'd rather extend TABLE to support a limit clause or
2013/1/23 Tom Lane t...@sss.pgh.pa.us:
I wrote:
If we did think that this specific backslash command needed to be able
to print something other than the filename as-entered, I'd be inclined
to just apply make_absolute_path() to the name, instead of relying on
inadequate dead-reckoning.
there is
presumably no need to worry about supporting Windows-style file paths
- As far as I can tell, this is the only psql slash command which, after saving
data to a file, provides a feedback message containing the filename/path.
Regards
Ian Lawrence Barwick
psql-save-history-2013-01-21
Regards
Ian Lawrence Barwick
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
39 matches
Mail list logo
