Re: [HACKERS] Review: Patch to compute Max LSN of Data Pages

2012-12-07 Thread Muhammad Usama
varo to allow all the segments of the relation for a given relation file name, or add another option do do the same. But if everybody is fine with leaving it for the future, I do not have any further concerns with the patch. It is good from my side. With Regards, > Amit Kapila. > > Thanks Muhammad Usama

[HACKERS] Patch to fix ecpg core dump with nested structure pointer variable

2012-11-29 Thread Muhammad Usama
Hi I have bumped in the segmentation fault in ecpg when using pointer to nested structure variable. ecpg crash.pgc Segmentation fault: 11 Please see the attached patch for the fix and test case to reproduce the scenario. Thanks Regards Muhammad Usama crash.pgc Description: Binary data

Re: [HACKERS] Review: Patch to compute Max LSN of Data Pages

2012-11-27 Thread Muhammad Usama
On Wed, Nov 28, 2012 at 3:06 AM, Alvaro Herrera wrote: > Amit Kapila escribió: > > > > Friday, November 23, 2012 5:38 AM Muhammad Usama wrote: > > > >- I think when finding the max LSN of single file the utility should > > > consider all relation segments.

Re: [HACKERS] Review: Patch to compute Max LSN of Data Pages

2012-11-27 Thread Muhammad Usama
On Tue, Nov 27, 2012 at 5:52 PM, Amit kapila wrote: > Friday, November 23, 2012 5:38 AM Muhammad Usama wrote: > > > Observations and Comments > > --- > > > - If no option is given to pg_computemaxlsn utility then we ge

[HACKERS] Review: Patch to compute Max LSN of Data Pages

2012-11-22 Thread Muhammad Usama
link instead, The utility can be used across the different versions of PG. Regards, Muhammad Usama

[HACKERS] getting carriage return character in vacuumo

2011-04-08 Thread Muhammad Usama
Hi, While using the vacuumlo utility I encountered a redundant carriage return(\r') character in the output. It is required in any scenario? If not, please find attached a tiny patch which will get rid of that extra '\r' character. Regards, Usama carriage_return_in_vacuumlo.patch Description: B