Re: [HACKERS] Fix number skipping in to_number

2017-09-25 Thread Oliver Ford
On Monday, 25 September 2017, Nathan Wagner <nw...@hydaspes.if.org> wrote: > On Thu, Aug 17, 2017 at 12:33:02PM +0100, Oliver Ford wrote: > > > Ok I've made that change in the attached v3. I'm not sure as I'm on > > en_US.UTF-8 locale too. Maybe something Windows specific

Re: [HACKERS] Add Roman numeral conversion to to_number

2017-09-14 Thread Oliver Ford
I'll fix the brace, but there are two other patches in the first email for tests and docs. For some reason the commitfest app didn't pick them up. On Friday, 15 September 2017, Doug Doole wrote: > The following review has been posted through the commitfest application: >

Re: [HACKERS] Fix number skipping in to_number

2017-08-17 Thread Oliver Ford
On Thu, Aug 17, 2017 at 11:55 AM, Thomas Munro wrote: > Hmm. Just in case my macOS laptop (CC=Apple's clang, > LANG=en_NZ.UTF-8) was unduly affected by cosmic rays I tried on a > couple of nearby servers running FreeBSD 11.1 (CC=clang, LANG=) > and CentOS 7.3

Re: [HACKERS] Fix number skipping in to_number

2017-08-17 Thread Oliver Ford
> The tests you added pass for me but the int8 test now fails with the > following (this is from regression.diff after running > 'PG_REGRESS_DIFF_OPTS="-dU10" make check'). It looks like some new > whitespace is appearing on the right in the output of to_char(). I > didn't try to understand why.

[HACKERS] Fix number skipping in to_number

2017-08-10 Thread Oliver Ford
Prevents an issue where numbers can be skipped in the to_number() function when the format mask contains a "G" or a "," but the input string doesn't contain a separator. This resolves the TODO item "Fix to_number() handling for values not matching the format string". == Change == Currently, if

Re: [HACKERS] Add Roman numeral conversion to to_number

2017-08-03 Thread Oliver Ford
On Thursday, 3 August 2017, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Aug 3, 2017 at 9:25 AM, Oliver Ford <ojf...@gmail.com > <javascript:;>> wrote: > > Adds to the to_number() function the ability to convert Roman numerals > > to a number. This feat