Re: [HACKERS] pg_rewind in contrib

2014-12-15 Thread Samrat Revagade
On Sat, Dec 13, 2014 at 10:49 PM, David Fetter da...@fetter.org wrote: On Fri, Dec 12, 2014 at 10:06:32AM -0500, Tom Lane wrote: Heikki Linnakangas hlinnakan...@vmware.com writes: I'd like to include pg_rewind in contrib. I don't object to adding the tool as such, but let's wait to see

Re: [HACKERS] psql: show only failed queries

2014-06-26 Thread Samrat Revagade
I am sending updated patch - buggy statement is printed via more logical psql_error function instead printf Thank you for updating patch, I really appreciate your efforts. Now, everything is good from my side. * it apply cleanly to the current git master * includes necessary docs * I think It

Re: [HACKERS] psql: show only failed queries

2014-06-25 Thread Samrat Revagade
Hi Pavel, After applying patch, on error condition it displays error message two times as follows: ERROR: column abc does not exist at character 23 STATEMENT: insert into ax values(abc); psql:a.sql:7: ERROR: column abc does not exist LINE 2: values(abc); user may confuse because of repeated

[HACKERS] Review of pg_rewind

2013-10-23 Thread Samrat Revagade
While testing pg_rewind I encountered following problem. I used following process to do the testing, Please correct me if I am doing it in wrong way. Problem-1: pg_rewind gives error (target master must be shut down cleanly.) when master crashed unexpectedly. 1. Setup Streaming Replication

Re: [HACKERS] Review of pg_rewind

2013-10-23 Thread Samrat Revagade
of the project is https://github.com/vmware/pg_rewind. Sure, I will add those issues on github. Either way, here are some comments below... On Wed, Oct 23, 2013 at 6:07 PM, Samrat Revagade revagade.sam...@gmail.com wrote: While testing pg_rewind I encountered following problem. I used

Re: [HACKERS] psql tab completion for updatable foreign tables

2013-10-14 Thread Samrat Revagade
On Fri, Sep 20, 2013 at 7:54 PM, Dean Rasheed dean.a.rash...@gmail.comwrote: On 20 September 2013 11:29, Samrat Revagade revagade.sam...@gmail.com wrote: Okay, are you adding this to the september commitfest? OK, I've done that. I think that it's too late for 9.3. +1

Re: [HACKERS] Patch for fail-back without fresh backup

2013-10-09 Thread Samrat Revagade
On Tue, Oct 8, 2013 at 3:16 PM, Andres Freund and...@2ndquadrant.comwrote: On 2013-10-08 15:07:02 +0530, Pavan Deolasee wrote: On Tue, Oct 8, 2013 at 2:33 PM, Sawada Masahiko sawada.m...@gmail.com wrote: On Fri, Oct 4, 2013 at 4:32 PM, Fujii Masao masao.fu...@gmail.com wrote: I

Re: [HACKERS] setting separate values of replication parameters to each standby to provide more granularity

2013-10-03 Thread Samrat Revagade
The idea is to allow configuration of standby servers such that they have there own set of replication parameters as per requirements. How does this interplay with the synchronous_standby_names parameter ? Or do you think that becomes irrelevant if we do like what you are suggesting above

[HACKERS] setting separate values of replication parameters to each standby to provide more granularity

2013-09-26 Thread Samrat Revagade
file. But after all of this, I think it will be a good change and will provide more granularity to the replication. Greetings, Samrat Revagade, NTT DATA OSS Center Pune, India.

Re: [HACKERS] psql tab completion for updatable foreign tables

2013-09-20 Thread Samrat Revagade
) Is that a problem ? Regards, Samrat Revagade

Re: [HACKERS] Patch for fail-back without fresh backup

2013-09-20 Thread Samrat Revagade
On Fri, Sep 20, 2013 at 3:40 PM, Sameer Thakur samthaku...@gmail.comwrote: Attached patch combines documentation patch and source-code patch. I have had a stab at reviewing the documentation. Have a look. Thanks. Attached patch implements suggestions in documentation. But comments from

Re: [HACKERS] Patch for fail-back without fresh backup

2013-09-17 Thread Samrat Revagade
syncrep.c: In function ‘SyncRepReleaseWaiters’: syncrep.c:421:6: warning: variable ‘numdataflush’ set but not used [-Wunused-but-set-variable] Sorry I forgot fix it. I have attached the patch which I modified. Attached patch combines documentation patch and source-code patch. --

[HACKERS] Using ini file to setup replication

2013-07-19 Thread Samrat Revagade
Hi, I was going through the archives and there was a discussion about using ini file to setup replication.(http://www.postgresql.org/message-id/4c9876b4.9020...@enterprisedb.com). I think if we work on this proposal and separate out the replication setup from postgresql.conf file then we can

Re: [HACKERS] Using ini file to setup replication

2013-07-19 Thread Samrat Revagade
Please find updated hyperlinks: Below I have explained how to to use ini file for failback safe stadby setup: While discussing feature of fail-back safe standby (CAF8Q-Gy7xa60HwXc0MKajjkWFEbFDWTG=ggyu1kmt+s2xcq...@mail.gmail.com)

Re: [HACKERS] Using ini file to setup replication

2013-07-19 Thread Samrat Revagade
*for example: for failback safe standby.* I think that introducing another configuration format is a pretty bad idea. While something new might not turn out to be as bad, we've seen how annoying a separate configuration format turned out for recovery.conf. Its not totally different way of

Re: [HACKERS] Patch for fail-back without fresh backup

2013-07-15 Thread Samrat Revagade
ToDo 1. currently this patch supports synchronous transfer. so we can't set different synchronous transfer mode to each server. we need to improve the patch for support following cases. - SYNC standby and make separate ASYNC failback safe standby - ASYNC standby and make separate

Re: [HACKERS] [PATCH] big test separation POC

2013-07-11 Thread Samrat Revagade
Hi Fabien, While applying latest version of the patch (regress-big-v4.patch) on latest PostgreSQL version i encountered following errors: a) Using git: $git apply --index regress-big-v4.patch regress-big-v4.patch:10: trailing whitespace. $(srcdir)/parallel_schedule

Re: [HACKERS] [PATCH] big test separation POC

2013-07-01 Thread Samrat Revagade
Hi Fabien, On Mon, Jul 1, 2013 at 10:42 AM, Fabien COELHO coe...@cri.ensmp.fr wrote: - I do not understand why the makefile specifies $(srcdir) before local files in some places. For VPATH builds :-) Here is a v2 which is more likely to work under VPATH. I really appreciate your

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-17 Thread Samrat Revagade
On Sun, Jun 16, 2013 at 11:08 PM, Simon Riggs si...@2ndquadrant.com wrote: On 16 June 2013 17:25, Samrat Revagade revagade.sam...@gmail.com wrote: On Sun, Jun 16, 2013 at 5:10 PM, Simon Riggs si...@2ndquadrant.com wrote: So I strongly object to calling this patch anything to do

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-16 Thread Samrat Revagade
On Sun, Jun 16, 2013 at 5:10 PM, Simon Riggs si...@2ndquadrant.com wrote: So I strongly object to calling this patch anything to do with failback safe. You simply don't have enough data to make such a bold claim. (Which is why we call it synchronous replication and not zero data loss, for

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-14 Thread Samrat Revagade
That will not happen if there is inconsistency in between both the servers. Please refer to the discussions on the link provided in the first post: http://www.postgresql.org/message-id/caf8q-gxg3pqtf71nvece-6ozraew5pwhk7yqtbjgwrfu513...@mail.gmail.com Regards, Samrat Revgade

Re: [HACKERS] Inconsistent DB data in Streaming Replication

2013-04-10 Thread Samrat Revagade
it's one of the reasons why a fresh base backup is required when starting old master as new standby? If yes, I agree with you. I've often heard the complaints about a backup when restarting new standby. That's really big problem. I think Fujii Masao is on the same page. In case of syncrep the

Re: [HACKERS] Inconsistent DB data in Streaming Replication

2013-04-10 Thread Samrat Revagade
(5) *The master then forces a write of the data page related to this transaction.* *Sorry, this is incorrect. Whenever the master writes the data page it checks that the WAL record is written in standby till that LSN. * * * While master is waiting to force a write (point 5) for this data page,

Re: [HACKERS] Inconsistent DB data in Streaming Replication

2013-04-09 Thread Samrat Revagade
wrote: On Mon, Apr 8, 2013 at 7:34 PM, Samrat Revagade revagade.sam...@gmail.com wrote: Hello, We have been trying to figure out possible solutions to the following problem in streaming replication Consider following scenario: If master receives commit command, it writes and flushes

[HACKERS] Inconsistent DB data in Streaming Replication

2013-04-08 Thread Samrat Revagade
Hello, We have been trying to figure out possible solutions to the following problem in streaming replication Consider following scenario: If master receives commit command, it writes and flushes commit WAL records to the disk, It also writes and flushes data page related to this transaction.