Re: [HACKERS] [PATCH] explain sortorder

2015-01-19 Thread Timmer, Marius
Zentrum für Informationsverarbeitung Westfälische Wilhelms-Universität Münster Einsteinstraße 60 mtimm...@uni-muenster.de Am 17.01.2015 um 00:45 schrieb Tom Lane t...@sss.pgh.pa.us: Timmer, Marius marius.tim...@uni-muenster.de writes: attached is version 8, fixing remaining issues, adding docs

Re: [HACKERS] [PATCH] explain sortorder

2015-01-15 Thread Timmer, Marius
wrote: On 01/14/2015 05:26 PM, Timmer, Marius wrote: Hello Heikki, abbreviated version: Sorry, the problem is only the unhandy patch text format, not different opinions how to proceed. Long version: The v7 patch file already addressed your suggestions, but the file contained serveral (old

Re: [HACKERS] [PATCH] explain sortorder

2015-01-14 Thread Timmer, Marius
mtimm...@uni-muenster.de Am 13.01.2015 um 18:52 schrieb Heikki Linnakangas hlinnakan...@vmware.com: On 01/13/2015 06:04 PM, Timmer, Marius wrote: -malloc() (StringInfo is used as suggested now). There really shouldn't be any snprintf() calls in the patch, when StringInfo is used correctly

Re: [HACKERS] [PATCH] explain sortorder

2015-01-13 Thread Timmer, Marius
Hi, we removed -malloc() (StringInfo is used as suggested now). -leftover commented out code -the splitting of existing declaration and initialization in show_group_keys(). Missing tests and documentation are WIP and will follow with the next patch version. Best regards Marius ---

Re: [HACKERS] [PATCH] explain sortorder

2015-01-07 Thread Timmer, Marius
Hi, we have spent the last days to realize your suggestions in the patch. It affects the result of a EXPLAIN-Statement (even in non-verbose-mode). Now you will get the order-information for every single sort-key which is not ordered by the defaults. best regards, Marius --- Marius Timmer

Re: [HACKERS] [PATCH] explain sortorder

2014-12-16 Thread Timmer, Marius
Hi Mike, Now I've replaced the spaces at the beginning of the lines with tabs. Quotes() in the expected/explain_sortorder.out-File caused failing „make check“. So I changed them to single quotes('). I’ve added the corrected patch as attachment. Kind regards, Marius

[HACKERS] [PATCH] explain sortorder

2014-11-26 Thread Timmer, Marius
Hello everyone, For creating indexes on more than one column, it is useful to know the sort order of each sort key. So now, if you run EXPLAIN in VERBOSE mode, you get the sort order information in the order the sort keys are displayed - Lukas - This patch is meant for discussion - It’s