[HACKERS] questions for the patch 'Enable pl/python to return records based on multiple OUT params' during reviewing

I created a function for testing the patch, but when i run following command, the function always raise an exception select test_in_params('first'); ERROR:  plpython: function "test_in_params" failed DETAIL:  exceptions.NameError: global name 'first' is not defined here is the script of fucntio

[HACKERS] A question for the patch "blooming filter"

i have a view of code, and find a question.There is a variable named 'bloom_pruning" set to be 'false' outside function 'bloom_filter_init' in file 'bloomfn.c', and there is a stataments if (bloom_pruning == false)    return; at begin of the function "bloom_filter_init". And i don't find  any p

[HACKERS] problem i get for Patch "blomming filter"

When i was performancing gmake, i got a error message. The attachment is the detail, i have no ideas about it. Hope someone' help                                           Thanks  gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-stric

[HACKERS] A error reported in patch "clientcert option for pg_hba"

a error blew was reported when peforming gmake. hba.c: In function `parse_hba_line': hba.c:943: error: label `hba_other_error' used but not defined gmake[3]: *** [hba.o] Error 1 there is also not definition of "hba_other_error" in  both handout of the patch and "hba.c".

[HACKERS] Result for "Automatically update view"

The patch can be built and executed, and automatically insert/update/delete action on the view based on single table is worked.  

[HACKERS] another question i met during reviewing

Here is another example for testing "Automatic update view", seems that "check option" doesn't work, i am not sure any other things i need to do, or it is a bug for the patch, anyone give me a help? Thanks postgres=# create view old_customer as postgres-# select name, postgres-#    age, po

[HACKERS] question for patch "Automatically update view"

I got a problem when reviewing patch "Automatically update view", the code can be built and executed successfully, but  when i tried the eaxmple below, it seemed that the patch didn't work create view v_name_account as     select customer.name,    customer.age,    customer.city,

[HACKERS] My review for the patch "Table command"

t;select * from Table",  I think this feature is    unneccessary.                                                                   Unicron

[HACKERS] Questions about patch "Table command"

Hi I am reviewer of Patch "Table command". I wanted to build code checked out from code repo got via rsyn, but I didn't find relating code in file "gram.y". Do i need to add the code to the file?