Re: [HACKERS] "may be unused" warnings for gcc

2017-02-22 Thread Peter Eisentraut
On 2/21/17 22:17, Andres Freund wrote: > I've not run comparisons this year, but late last year I was seeing > 5% > < 10% benefits - that seems plenty enough to care. You mean the 5-minute benchmarks on my laptop are not representative? ;-) Here is a patch that I had lying around that clears the

Re: [HACKERS] "may be unused" warnings for gcc

2017-02-21 Thread Andres Freund
On 2017-02-21 17:20:44 -0500, Peter Eisentraut wrote: > On 2/20/17 09:41, Andres Freund wrote: > > When building with a new-ish gcc (6.3.0 right now, but I've seen this > > for a while) with optimization I get a number of warnings: > > These all look like related to inlining/-O3. > > I have attem

Re: [HACKERS] "may be unused" warnings for gcc

2017-02-21 Thread Peter Eisentraut
On 2/20/17 09:41, Andres Freund wrote: > When building with a new-ish gcc (6.3.0 right now, but I've seen this > for a while) with optimization I get a number of warnings: These all look like related to inlining/-O3. I have attempted to fix these in the past, but I have found that -O3 doesn't get

[HACKERS] "may be unused" warnings for gcc

2017-02-20 Thread Andres Freund
Hi, When building with a new-ish gcc (6.3.0 right now, but I've seen this for a while) with optimization I get a number of warnings: In file included from /home/andres/src/postgresql/src/include/postgres.h:48:0, from /home/andres/src/postgresql/src/backend/parser/parse_collate.c