Re: [HACKERS] [BUG?] pg_event_trigger_ddl_commands() error with ALTER TEXT SEARCH CONFIGURATION

2016-12-22 Thread Stephen Frost
Artur, * Artur Zakirov (a.zaki...@postgrespro.ru) wrote: > 2016-12-21 20:34 GMT+03:00 Stephen Frost : > > Did you happen to look at adding a regression test for this to > > test_ddl_deparse? > > Of course. I updated the patch. I added a few comments and back-patched the

Re: [HACKERS] [BUG?] pg_event_trigger_ddl_commands() error with ALTER TEXT SEARCH CONFIGURATION

2016-12-21 Thread Artur Zakirov
Thank you for your comments, Stephen. 2016-12-21 20:34 GMT+03:00 Stephen Frost : > > Did you happen to look at adding a regression test for this to > test_ddl_deparse? Of course. I updated the patch. > >> This patch only fixes the bug. But I think I also can do a patch which

Re: [HACKERS] [BUG?] pg_event_trigger_ddl_commands() error with ALTER TEXT SEARCH CONFIGURATION

2016-12-21 Thread Stephen Frost
Artur, * Artur Zakirov (a.zaki...@postgrespro.ru) wrote: > 2016-11-19 21:28 GMT+03:00 Michael Paquier : > > On Thu, Nov 17, 2016 at 1:17 PM, Alvaro Herrera > > wrote: > >> It's a bug. You're right that we need to handle the object class > >>

Re: [HACKERS] [BUG?] pg_event_trigger_ddl_commands() error with ALTER TEXT SEARCH CONFIGURATION

2016-11-28 Thread Artur Zakirov
2016-11-28 21:32 GMT+03:00 Robert Haas : > > You might need to add this patch to https://commitfest.postgresql.org/ > so that it doesn't get forgotten. > > -- > Robert Haas > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company I added the patch to

Re: [HACKERS] [BUG?] pg_event_trigger_ddl_commands() error with ALTER TEXT SEARCH CONFIGURATION

2016-11-28 Thread Robert Haas
On Sun, Nov 27, 2016 at 1:59 PM, Artur Zakirov wrote: > Thank you for answers. > > 2016-11-19 21:28 GMT+03:00 Michael Paquier : >> On Thu, Nov 17, 2016 at 1:17 PM, Alvaro Herrera >> wrote: >>> It's a bug. You're

Re: [HACKERS] [BUG?] pg_event_trigger_ddl_commands() error with ALTER TEXT SEARCH CONFIGURATION

2016-11-27 Thread Artur Zakirov
Thank you for answers. 2016-11-19 21:28 GMT+03:00 Michael Paquier : > On Thu, Nov 17, 2016 at 1:17 PM, Alvaro Herrera > wrote: >> It's a bug. You're right that we need to handle the object class >> somewhere. Perhaps I failed to realize that

Re: [HACKERS] [BUG?] pg_event_trigger_ddl_commands() error with ALTER TEXT SEARCH CONFIGURATION

2016-11-19 Thread Michael Paquier
On Thu, Nov 17, 2016 at 1:17 PM, Alvaro Herrera wrote: > It's a bug. You're right that we need to handle the object class > somewhere. Perhaps I failed to realize that tsconfigs could get > altered. It seems to me that the thing to be careful of here is how a new

Re: [HACKERS] [BUG?] pg_event_trigger_ddl_commands() error with ALTER TEXT SEARCH CONFIGURATION

2016-11-17 Thread Alvaro Herrera
Artur Zakirov wrote: > Hello hackers, > > I attached the test extension. It just creates event trigger on > ddl_command_end. And pg_catalog.pg_event_trigger_ddl_commands() is executed > from extension's C-function handler. > > The pg_event_trigger_ddl_commands() returns the error: > > ERROR: