Re: [HACKERS] [BUGS] BUG #4186: set lc_messages does not work

2009-01-21 Thread Magnus Hagander
Hiroshi Inoue wrote: Magnus Hagander wrote: Hiroshi Inoue wrote: Magnus Hagander wrote: There still needs to be some error checking added in IsoLocaleName(), but this is a start. Can someone please test this? :-) OK I would check it tonight. Thanks. OK seems to works here. The

Re: [HACKERS] [BUGS] BUG #4186: set lc_messages does not work

2009-01-20 Thread Hiroshi Inoue
Magnus Hagander wrote: Hiroshi Inoue wrote: Magnus Hagander wrote: There still needs to be some error checking added in IsoLocaleName(), but this is a start. Can someone please test this? :-) OK I would check it tonight. Thanks. OK seems to works here. The attached is a test case using

Re: [HACKERS] [BUGS] BUG #4186: set lc_messages does not work

2009-01-19 Thread Magnus Hagander
Hiroshi Inoue wrote: Hiroshi Inoue wrote: Magnus Hagander wrote: Do you want to send an updated patch for it, or do you want me to look at it? I would send a new patch to which I added a simple ISO style check for locale names. Attached is a new patch. I added a simple ISO style

Re: [HACKERS] [BUGS] BUG #4186: set lc_messages does not work

2009-01-19 Thread Hiroshi Inoue
Magnus Hagander wrote: Hiroshi Inoue wrote: Hiroshi Inoue wrote: Magnus Hagander wrote: Do you want to send an updated patch for it, or do you want me to look at it? I would send a new patch to which I added a simple ISO style check for locale names. Attached is a new patch. I added a

Re: [HACKERS] [BUGS] BUG #4186: set lc_messages does not work

2009-01-08 Thread Hiroshi Inoue
Hiroshi Inoue wrote: Magnus Hagander wrote: Do you want to send an updated patch for it, or do you want me to look at it? I would send a new patch to which I added a simple ISO style check for locale names. Attached is a new patch. I added a simple ISO style locale name check. Avoided

Re: [HACKERS] [BUGS] BUG #4186: set lc_messages does not work

2009-01-07 Thread Magnus Hagander
Hiroshi Inoue wrote: Hiroshi Inoue wrote: Hi, I posted a patch 18 days ago but have got no responce. Anyway I've simplified the patch by using an appropriate gettext module. Hiroshi Inoue wrote: Bruce Momjian wrote: Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: Thomas H.

Re: [HACKERS] [BUGS] BUG #4186: set lc_messages does not work

2009-01-07 Thread Hiroshi Inoue
Magnus Hagander wrote: Hiroshi Inoue wrote: Hiroshi Inoue wrote: Where are we on this? AFAICS there are 2 causes. 1. MSVC version of postgres is using a bad gettext module. 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0. As for 1, we have to use another gettext module.

Re: [HACKERS] [BUGS] BUG #4186: set lc_messages does not work

2009-01-07 Thread Hiroshi Inoue
Magnus Hagander wrote: Hiroshi Inoue wrote: AFAICS there are 2 causes. 1. MSVC version of postgres is using a bad gettext module. 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0. As for 1, we have to use another gettext module. I can provide it if requested. Yes, I think

Re: [HACKERS] [BUGS] BUG #4186: set lc_messages does not work

2009-01-07 Thread Magnus Hagander
Hiroshi Inoue wrote: Magnus Hagander wrote: Hiroshi Inoue wrote: AFAICS there are 2 causes. 1. MSVC version of postgres is using a bad gettext module. 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0. As for 1, we have to use another gettext module. I can provide it if

Re: [HACKERS] [BUGS] BUG #4186: set lc_messages does not work

2009-01-07 Thread Hiroshi Inoue
Magnus Hagander wrote: Hiroshi Inoue wrote: Magnus Hagander wrote: Hiroshi Inoue wrote: AFAICS there are 2 causes. 1. MSVC version of postgres is using a bad gettext module. 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0. As for 1, we have to use another gettext module. I

Re: [HACKERS] [BUGS] BUG #4186: set lc_messages does not work

2009-01-06 Thread Hiroshi Saito
Hi. Sorry very late reaction I report the test checked again. http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES_01.png http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES_02.png

Re: [HACKERS] [BUGS] BUG #4186: set lc_messages does not work

2008-12-26 Thread Hiroshi Inoue
Hi, I posted a patch 18 days ago but have got no responce. Anyway I've simplified the patch by using an appropriate gettext module. Hiroshi Inoue wrote: Bruce Momjian wrote: Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: Thomas H. wrote: so at least that explains the changed

Re: [HACKERS] [BUGS] BUG #4186: set lc_messages does not work

2008-12-26 Thread Hiroshi Inoue
Oops, I forgot to attach the patch, sorry. Hiroshi Inoue wrote: Hi, I posted a patch 18 days ago but have got no responce. Anyway I've simplified the patch by using an appropriate gettext module. Hiroshi Inoue wrote: Bruce Momjian wrote: Tom Lane wrote: Magnus Hagander mag...@hagander.net