Re: [HACKERS] [BUGS] surprising to_timestamp behavior

2014-01-20 Thread Tom Lane
Jeevan Chalke jeevan.cha...@enterprisedb.com writes: I went to review this, and found that there's not actually a patch attached ... Attached. Sorry for that. This looks good to me except for one thing: if the upcoming node is a DCH_FX action (ie, turn on fx_mode), I don't think we want to

Re: [HACKERS] [BUGS] surprising to_timestamp behavior

2014-01-19 Thread Jeevan Chalke
I went to review this, and found that there's not actually a patch attached ... regards, tom lane Attached. Sorry for that. -- Jeevan B Chalke Principal Software Engineer, Product Development EnterpriseDB Corporation The Enterprise PostgreSQL Company diff --git

Re: [HACKERS] [BUGS] surprising to_timestamp behavior

2014-01-17 Thread Tom Lane
Jeevan Chalke jeevan.cha...@enterprisedb.com writes: Attached patch which fixes this issue. I have just tweaked the code around ignoring spaces in DCH_from_char() function. Adding to CommitFest 2014-01 (Open). I went to review this, and found that there's not actually a patch attached ...

Re: [HACKERS] [BUGS] surprising to_timestamp behavior

2014-01-13 Thread Jeevan Chalke
On Thu, Oct 31, 2013 at 10:50 AM, Jeevan Chalke jeevan.cha...@enterprisedb.com wrote: On Tue, Oct 29, 2013 at 11:05 PM, Robert Haas robertmh...@gmail.comwrote: On Tue, Oct 29, 2013 at 12:03 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: It turns out