Re: [HACKERS] [COMMITTERS] pgsql: Account for catalog snapshot in PGXACT->xmin updates.

2017-11-04 Thread Tom Lane
Noah Misch writes: > I plan to use the attached patch after the minor release tags land. If > there's significant support, I could instead push before the wrap. This looks fine to me --- I think you should push now. (which reminds me, I'd better get on with making release

Re: [HACKERS] [COMMITTERS] pgsql: Account for catalog snapshot in PGXACT->xmin updates.

2017-08-21 Thread Simon Riggs
On 19 August 2017 at 20:54, Noah Misch wrote: > On Tue, Dec 06, 2016 at 01:59:18PM -0500, Robert Haas wrote: >> On Tue, Dec 6, 2016 at 1:36 PM, Tom Lane wrote: >> > Robert Haas writes: >> >> On Tue, Nov 15, 2016 at 3:55 PM, Tom Lane

Re: [HACKERS] [COMMITTERS] pgsql: Account for catalog snapshot in PGXACT->xmin updates.

2016-12-06 Thread Robert Haas
On Tue, Dec 6, 2016 at 1:36 PM, Tom Lane wrote: > Robert Haas writes: >> On Tue, Nov 15, 2016 at 3:55 PM, Tom Lane wrote: >>> Account for catalog snapshot in PGXACT->xmin updates. > >> It seems to me that this makes it possible for

Re: [HACKERS] [COMMITTERS] pgsql: Account for catalog snapshot in PGXACT->xmin updates.

2016-12-06 Thread Tom Lane
Robert Haas writes: > On Tue, Nov 15, 2016 at 3:55 PM, Tom Lane wrote: >> Account for catalog snapshot in PGXACT->xmin updates. > It seems to me that this makes it possible for > ThereAreNoPriorRegisteredSnapshots() to fail spuriously. The only > core

Re: [HACKERS] [COMMITTERS] pgsql: Account for catalog snapshot in PGXACT->xmin updates.

2016-12-06 Thread Robert Haas
On Tue, Nov 15, 2016 at 3:55 PM, Tom Lane wrote: > Account for catalog snapshot in PGXACT->xmin updates. > > The CatalogSnapshot was not plugged into SnapshotResetXmin()'s accounting > for whether MyPgXact->xmin could be cleared or advanced. In normal > transactions this was