On 26.03.2013 22:14, Kevin Grittner wrote:
Alvaro Herreraalvhe...@2ndquadrant.com wrote:
Not happy with misc.c as a filename.
We already have two misc.c files:
src/backend/utils/adt/misc.c
src/interfaces/ecpg/ecpglib/misc.c
I much prefer not to repeat the same filename in different
Heikki Linnakangas hlinnakan...@vmware.com writes:
Alvaro Herreraalvhe...@2ndquadrant.com wrote:
Not happy with misc.c as a filename.
There's a bunch of files called pg_backup_*.c that are also shared
between pg_dump and pg_restore, so perhaps pg_backup_utils.c?
Works for me. There's
On 27.03.2013 15:28, Tom Lane wrote:
Heikki Linnakangashlinnakan...@vmware.com writes:
Alvaro Herreraalvhe...@2ndquadrant.com wrote:
Not happy with misc.c as a filename.
There's a bunch of files called pg_backup_*.c that are also shared
between pg_dump and pg_restore, so perhaps
On 26.03.2013 02:02, Tom Lane wrote:
Heikki Linnakangashlinnakan...@vmware.com writes:
On 25.03.2013 15:36, Tom Lane wrote:
Heikki Linnakangasheikki.linnakan...@iki.fi writes:
Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
Per warning from -Wmissing-format-attribute.
Hm, this is exactly
On 26.03.2013 09:51, Heikki Linnakangas wrote:
On 26.03.2013 02:02, Tom Lane wrote:
Heikki Linnakangashlinnakan...@vmware.com writes:
On 25.03.2013 15:36, Tom Lane wrote:
Heikki Linnakangasheikki.linnakan...@iki.fi writes:
Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
Per warning from
Heikki Linnakangas wrote:
This is what I came up with. I created a new file, misc.c (for lack
of a better name), for things that are shared by pg_dump and
pg_restore, but not pg_dumpall or other programs. I moved all the
parallel stuff from dumputils.c to parallel.c, and everything else
Alvaro Herrera alvhe...@2ndquadrant.com wrote:
Not happy with misc.c as a filename.
We already have two misc.c files:
src/backend/utils/adt/misc.c
src/interfaces/ecpg/ecpglib/misc.c
I much prefer not to repeat the same filename in different
directories if we can avoid it.
How about
On 2013-03-26 13:14:53 -0700, Kevin Grittner wrote:
Alvaro Herrera alvhe...@2ndquadrant.com wrote:
Not happy with misc.c as a filename.
We already have two misc.c files:
src/backend/utils/adt/misc.c
src/interfaces/ecpg/ecpglib/misc.c
I much prefer not to repeat the same filename in
Heikki Linnakangas heikki.linnakan...@iki.fi writes:
Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
Per warning from -Wmissing-format-attribute.
Hm, this is exactly what I removed yesterday, because it makes the build
fail outright on old gcc:
gcc -O1 -Wall -Wmissing-prototypes -Wpointer-arith
On 25.03.2013 15:36, Tom Lane wrote:
Heikki Linnakangasheikki.linnakan...@iki.fi writes:
Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
Per warning from -Wmissing-format-attribute.
Hm, this is exactly what I removed yesterday, because it makes the build
fail outright on old gcc:
gcc -O1 -Wall
Heikki Linnakangas hlinnakan...@vmware.com writes:
On 25.03.2013 15:36, Tom Lane wrote:
Heikki Linnakangasheikki.linnakan...@iki.fi writes:
Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
Per warning from -Wmissing-format-attribute.
Hm, this is exactly what I removed yesterday, because it makes
11 matches
Mail list logo
