Re: [HACKERS] [COMMITTERS] pgsql: Refactor flex and bison make rules

2012-11-29 Thread Andrew Dunstan
On 11/28/2012 11:03 PM, Tom Lane wrote: Jeremy Drake writes: While we're talking about odd issues that only seem to happen on Okapi, does anyone know of anything I can do to diagnose the pg_upgrade failure on the 9.2 branch? There are no rogue (non-buildfarm-related) postmaster/postgres proce

Re: [HACKERS] [COMMITTERS] pgsql: Refactor flex and bison make rules

2012-11-29 Thread Jeremy Drake
On Wed, 28 Nov 2012, Tom Lane wrote: > Jeremy Drake writes: > > While we're talking about odd issues that only seem to happen on Okapi, > > does anyone know of anything I can do to diagnose the pg_upgrade failure > > on the 9.2 branch? There are no rogue (non-buildfarm-related) > > postmaster/po

Re: [HACKERS] [COMMITTERS] pgsql: Refactor flex and bison make rules

2012-11-29 Thread Jeremy Drake
On Wed, 28 Nov 2012, Tom Lane wrote: > Andrew Dunstan writes: > > On 11/28/2012 02:14 PM, Alvaro Herrera wrote: > >> Okapi has been failing sporadically on ecpg, and I wonder if it's > >> related to this change. > > > Well, it looks like the make is broken and missing a clear dependency > > requi

Re: [HACKERS] [COMMITTERS] pgsql: Refactor flex and bison make rules

2012-11-28 Thread Tom Lane
Jeremy Drake writes: > While we're talking about odd issues that only seem to happen on Okapi, > does anyone know of anything I can do to diagnose the pg_upgrade failure > on the 9.2 branch? There are no rogue (non-buildfarm-related) > postmaster/postgres processes running on the machine. [ digs

Re: [HACKERS] [COMMITTERS] pgsql: Refactor flex and bison make rules

2012-11-28 Thread Tom Lane
Andrew Dunstan writes: > On 11/28/2012 06:19 PM, Tom Lane wrote: >> It appears to me that the case that okapi is hitting is specific to the >> ecpg preprocessor build rules, and indeed specific to the case where >> preproc.c needs to be rebuilt. A .NOTPARALLEL in ecpg/preproc/Makefile >> would pr

Re: [HACKERS] [COMMITTERS] pgsql: Refactor flex and bison make rules

2012-11-28 Thread Andrew Dunstan
On 11/28/2012 06:19 PM, Tom Lane wrote: Peter Eisentraut writes: On 11/28/12 6:01 PM, Tom Lane wrote: I wonder whether adding another .NOTPARALLEL directive would be a better idea than insisting people get hold of patched versions. We could put ifeq ($(MAKE_VERSION),3.82) .NOTPARALLEL: endif

Re: [HACKERS] [COMMITTERS] pgsql: Refactor flex and bison make rules

2012-11-28 Thread Tom Lane
Peter Eisentraut writes: > On 11/28/12 6:01 PM, Tom Lane wrote: >> I wonder whether adding another .NOTPARALLEL directive would be a better >> idea than insisting people get hold of patched versions. > We could put > ifeq ($(MAKE_VERSION),3.82) > .NOTPARALLEL: > endif > into Makefile.global. I d

Re: [HACKERS] [COMMITTERS] pgsql: Refactor flex and bison make rules

2012-11-28 Thread Andrew Dunstan
On 11/28/2012 06:01 PM, Tom Lane wrote: Andrew Dunstan writes: On 11/28/2012 02:14 PM, Alvaro Herrera wrote: Okapi has been failing sporadically on ecpg, and I wonder if it's related to this change. Well, it looks like the make is broken and missing a clear dependency requirement. I think we

Re: [HACKERS] [COMMITTERS] pgsql: Refactor flex and bison make rules

2012-11-28 Thread Peter Eisentraut
On 11/28/12 6:01 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 11/28/2012 02:14 PM, Alvaro Herrera wrote: >>> Okapi has been failing sporadically on ecpg, and I wonder if it's >>> related to this change. > >> Well, it looks like the make is broken and missing a clear dependency >> requireme

Re: [HACKERS] [COMMITTERS] pgsql: Refactor flex and bison make rules

2012-11-28 Thread Tom Lane
Andrew Dunstan writes: > On 11/28/2012 02:14 PM, Alvaro Herrera wrote: >> Okapi has been failing sporadically on ecpg, and I wonder if it's >> related to this change. > Well, it looks like the make is broken and missing a clear dependency > requirement. I think we need to ask Jeremy to turn off