Re: [HACKERS] [GENERAL] psql \pset pager

2008-05-06 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> If we're going to change it, we should make it match GUC's parse_bool, >> which has had some actual thought put into it. > Good idea. Do I copy the C code into /psql or somehow share the > function? Just copy it --- it's not large en

Re: [HACKERS] [GENERAL] psql \pset pager

2008-05-06 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > So, I think the answer is that we have the current behavior because of > > backward compatibility. Perhaps we should be more strict in > > ParseVariableBool(), perhaps only allowing true/false and on/off. > > If we're going to change

Re: [HACKERS] [GENERAL] psql \pset pager

2008-05-06 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > So, I think the answer is that we have the current behavior because of > backward compatibility. Perhaps we should be more strict in > ParseVariableBool(), perhaps only allowing true/false and on/off. If we're going to change it, we should make it match

Re: [HACKERS] [GENERAL] psql \pset pager

2008-05-06 Thread Bruce Momjian
Steve Crawford wrote: > My fingers sometimes run on "autoappend semicolon" mode and I end up > typing "\pset pager always;" instead of "\pset pager always". No error > is returned, short (but wide) output is not routed to the pager, and I > have to back up and correct the \pset pager command. Af