Re: [HACKERS] [PATCH] Add pg_disable_checksums() and supporting infrastructure

> On Mar 9, 2017, at 1:01 PM, Robert Haas wrote: > > On Sun, Feb 19, 2017 at 12:02 PM, David Christensen > wrote: >> Hi Robert, this is part of a larger patch which *does* enable the checksums >> online; I’ve been extracting the necessary pieces out

Re: [HACKERS] [PATCH] Add pg_disable_checksums() and supporting infrastructure

On Sun, Feb 19, 2017 at 12:02 PM, David Christensen wrote: > Hi Robert, this is part of a larger patch which *does* enable the checksums > online; I’ve been extracting the necessary pieces out with the understanding > that some people thought the disable code might be useful

Re: [HACKERS] [PATCH] Add pg_disable_checksums() and supporting infrastructure

On 2/20/17 11:22 AM, David Christensen wrote: - If an entire cluster is going to be considered as checksummed, then even databases that don't allow connections would need to get enabled. Yeah, the workaround for now would be to require “datallowconn" to be set to ’t' for all databases before

Re: [HACKERS] [PATCH] Add pg_disable_checksums() and supporting infrastructure

> On Feb 19, 2017, at 8:14 PM, Jim Nasby wrote: > > On 2/19/17 11:02 AM, David Christensen wrote: >> My design notes for the patch were submitted to the list with little >> comment; see: >>

Re: [HACKERS] [PATCH] Add pg_disable_checksums() and supporting infrastructure

On 2/19/17 11:02 AM, David Christensen wrote: My design notes for the patch were submitted to the list with little comment; see: https://www.postgresql.org/message-id/1E6E64E9-634B-43F4-8AA2-CD85AD92D2F8%40endpoint.com I have since added the WAL logging of checksum states, however I’d be glad

Re: [HACKERS] [PATCH] Add pg_disable_checksums() and supporting infrastructure

> On Feb 19, 2017, at 5:05 AM, Robert Haas wrote: > > On Fri, Feb 17, 2017 at 2:28 AM, David Christensen wrote: >> - Change "data_checksums" from a simple boolean to "data_checksum_state", an >> enum type for all of >> the potentially-required

Re: [HACKERS] [PATCH] Add pg_disable_checksums() and supporting infrastructure

On Fri, Feb 17, 2017 at 2:28 AM, David Christensen wrote: > - Change "data_checksums" from a simple boolean to "data_checksum_state", an > enum type for all of > the potentially-required states for this feature (as well as enabling). Color me skeptical. I don't know what

Re: [HACKERS] [PATCH] Add pg_disable_checksums() and supporting infrastructure

On Feb 17, 2017, at 10:31 AM, Magnus Hagander wrote: > > On Thu, Feb 16, 2017 at 9:58 PM, David Christensen wrote: > Extracted from a larger patch, this patch provides the basic infrastructure > for turning data > checksums off in a cluster. This also

Re: [HACKERS] [PATCH] Add pg_disable_checksums() and supporting infrastructure

> On Feb 17, 2017, at 10:31 AM, Magnus Hagander wrote: > > Per the point made by somebody else (I think Simon?) on the other thread, I > think it also needs WAL support. Otherwise you turn it off on the master, but > it remains on on a replica which will cause failures

Re: [HACKERS] [PATCH] Add pg_disable_checksums() and supporting infrastructure

On Thu, Feb 16, 2017 at 9:58 PM, David Christensen wrote: > Extracted from a larger patch, this patch provides the basic > infrastructure for turning data > checksums off in a cluster. This also sets up the necessary pg_control > fields to support the > necessary multiple

[HACKERS] [PATCH] Add pg_disable_checksums() and supporting infrastructure

Extracted from a larger patch, this patch provides the basic infrastructure for turning data checksums off in a cluster. This also sets up the necessary pg_control fields to support the necessary multiple states for handling the transitions. We do a few things: - Change "data_checksums" from