On 5 January 2017 at 04:50, Michael Paquier wrote:
> The perldoc documentation is broken for the new routines.
...
> Attached is a patch to fix all those small issues.
Thanks, looks good, will apply.
> It may be a good idea to run perltidy on top of that to be honest...
Should we add that to
On Thu, Jan 5, 2017 at 1:58 AM, Simon Riggs wrote:
> On 4 January 2017 at 08:16, Craig Ringer wrote:
>> When committed I will update the decoding on standby series to omit
>> these pre-requisite patches.
>
> Committed, thanks.
I was planning a round of reviews of those patches, but you were fast
On 4 January 2017 at 08:16, Craig Ringer wrote:
> On 4 January 2017 at 12:39, Craig Ringer wrote:
>
>> To keep things together, I've followed up on the logical decoding on
>> standby thread that now incorporates all these patches.
>
> Attached are the two patches discussed upthread, in their
> pr
On 4 January 2017 at 12:39, Craig Ringer wrote:
> To keep things together, I've followed up on the logical decoding on
> standby thread that now incorporates all these patches.
Attached are the two patches discussed upthread, in their
proposed-for-commit form, as requested by Simon.
These corre
On 3 January 2017 at 12:36, Craig Ringer wrote:
> On 2 January 2017 at 20:17, Simon Riggs wrote:
>
>> Bit confused... can't see a caller for wait_for_slot_catchup() and the
>> slot tests don't call it AFAICS.
>
> The recovery tests for decoding on standby will use it. I can delay
> adding it unti
On 2 January 2017 at 20:17, Simon Riggs wrote:
> Bit confused... can't see a caller for wait_for_slot_catchup() and the
> slot tests don't call it AFAICS.
The recovery tests for decoding on standby will use it. I can delay
adding it until then.
> Also can't see anywhere the LSN stuff is used ei
On 14 November 2016 at 07:01, Craig Ringer wrote:
> Every test I write with the TAP framework for recovery seems to need
> to wait for one node to catch up to another or examine replication
> slot state. So: attached is a patch to add helper methods for these
> tasks.
>
> Also add a new pg_lsn.pm
Every test I write with the TAP framework for recovery seems to need
to wait for one node to catch up to another or examine replication
slot state. So: attached is a patch to add helper methods for these
tasks.
Also add a new pg_lsn.pm helper class to deal with PostgreSQL's
awkward representation
