Re: [HACKERS] [PATCH] Recreate Missing WAL Directories (from TODO)

2008-11-09 Thread Tom Lane
Jonah H. Harris [EMAIL PROTECTED] writes: On Sat, Nov 8, 2008 at 4:08 PM, Tom Lane [EMAIL PROTECTED] wrote: This has been suggested before but I'm unconvinced that it's a good idea. It's reasonably common for pg_xlog to be a symlink. If you neglect to re-establish the symlink then what would

Re: [HACKERS] [PATCH] Recreate Missing WAL Directories (from TODO)

2008-11-09 Thread Decibel!
On Nov 8, 2008, at 3:08 PM, Tom Lane wrote: Jonah H. Harris [EMAIL PROTECTED] writes: When performing a PITR copy of a data cluster, the pg_xlog directory is generally omitted. As such, when starting the copy up for replay/recovery, the WAL directories need to be recreated. This patch

Re: [HACKERS] [PATCH] Recreate Missing WAL Directories (from TODO)

2008-11-09 Thread Tom Lane
Decibel! [EMAIL PROTECTED] writes: What if the the location was recorded in something that's not meant to be touched by users, such as pg_control? At that point we'd have a command for actually moving it. [ shrug... ] Possible, perhaps, but I think we have more important problems to

Re: [HACKERS] [PATCH] Recreate Missing WAL Directories (from TODO)

2008-11-09 Thread Decibel!
On Nov 9, 2008, at 11:44 AM, Tom Lane wrote: Decibel! [EMAIL PROTECTED] writes: On Nov 8, 2008, at 3:08 PM, Tom Lane wrote: ... It's reasonably common for pg_xlog to be a symlink. ISTM it'd be better still to have an official knob that allows you to determine where pg_xlog lives. ISTR

Re: [HACKERS] [PATCH] Recreate Missing WAL Directories (from TODO)

2008-11-09 Thread Tom Lane
Decibel! [EMAIL PROTECTED] writes: On Nov 8, 2008, at 3:08 PM, Tom Lane wrote: ... It's reasonably common for pg_xlog to be a symlink. ISTM it'd be better still to have an official knob that allows you to determine where pg_xlog lives. ISTR discussion about that, but I don't see anything

[HACKERS] [PATCH] Recreate Missing WAL Directories (from TODO)

2008-11-08 Thread Jonah H. Harris
When performing a PITR copy of a data cluster, the pg_xlog directory is generally omitted. As such, when starting the copy up for replay/recovery, the WAL directories need to be recreated. This patch checks to see whether XLOGDIR and XLOGDIR/archive_status exist on XLOGStartup and if not,

Re: [HACKERS] [PATCH] Recreate Missing WAL Directories (from TODO)

2008-11-08 Thread Tom Lane
Jonah H. Harris [EMAIL PROTECTED] writes: When performing a PITR copy of a data cluster, the pg_xlog directory is generally omitted. As such, when starting the copy up for replay/recovery, the WAL directories need to be recreated. This patch checks to see whether XLOGDIR and

Re: [HACKERS] [PATCH] Recreate Missing WAL Directories (from TODO)

2008-11-08 Thread Jonah H. Harris
On Sat, Nov 8, 2008 at 4:08 PM, Tom Lane [EMAIL PROTECTED] wrote: This has been suggested before but I'm unconvinced that it's a good idea. It's reasonably common for pg_xlog to be a symlink. If you neglect to re-establish the symlink then what would happen is that xlog gets recreated on the