On Fri, Jul 3, 2015 at 2:12 AM, Tom Lane wrote:
> Jeevan Chalke writes:
> > Attached patch which fixes my review comments.
>
> Applied with minor adjustments (mostly cosmetic, but did neither of you
> notice the compiler warning?)
>
Oops. Sorry for that.
Added -Wall -Werror in my configuration
Jeevan Chalke writes:
> Attached patch which fixes my review comments.
Applied with minor adjustments (mostly cosmetic, but did neither of you
notice the compiler warning?)
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
> Date: Thu, 4 Jun 2015 13:55:52 +0530
> From: Jeevan Chalke
> To: david.g.johns...@gmail.com
> Cc: PostgreSQL Hackers
> Subject: Re: [PATCH] two-arg current_setting() with fallback
> Message-ID:
>
> Hi,
>
> Attached patch which fixes my review comments.
>
> Since code changes were good, jus
Hi,
Attached patch which fixes my review comments.
Since code changes were good, just fixed reported cosmetic changes.
David, can you please cross check?
Thanks
--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
diff -
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
I have reviewed the patch.
Here are my review comments:
1. P
Hello,
>Well, speaking of the two-arg form vs alternate name, here's a version of
the patch which includes the >new behavior
Thought i will attempt a review.
The patch applies cleanly to latest HEAD.
patch -p1 <
/home/Sameer/Downloads/0001-Add-two-arg-form-of-current_setting-to-optionally-su.pat
> On Mar 20, 2015, at 11:10 AM, David G. Johnston
> wrote:
>
> On Fri, Mar 20, 2015 at 9:04 AM, Robert Haas wrote:
> On Fri, Mar 20, 2015 at 10:54 AM, David Christensen
> wrote:
> > In that case, the other thought I had here is that we change the function
> > signature of current_setting()
On Fri, Mar 20, 2015 at 9:04 AM, Robert Haas wrote:
> On Fri, Mar 20, 2015 at 10:54 AM, David Christensen
> wrote:
> > In that case, the other thought I had here is that we change the
> function signature of current_setting() to be a two-arg form where the
> second argument is a boolean "throw_e
On Fri, Mar 20, 2015 at 10:54 AM, David Christensen wrote:
> In that case, the other thought I had here is that we change the function
> signature of current_setting() to be a two-arg form where the second argument
> is a boolean "throw_error", with a default argument of true to preserve
> exis
> On Mar 19, 2015, at 6:27 PM, Tom Lane wrote:
>
> David Christensen writes:
>> The two-arg form of the current_setting() function will allow a
>> fallback value to be returned instead of throwing an error when an
>> unknown GUC is provided. This would come in most useful when using
>> custom
David Christensen writes:
> The two-arg form of the current_setting() function will allow a
> fallback value to be returned instead of throwing an error when an
> unknown GUC is provided. This would come in most useful when using
> custom GUCs; e.g.:
> -- errors out if the 'foo.bar' setting is
Apologies if this is a double-post.
Enclosed is a patch that creates a two-arg current_setting() function. From
the commit message:
The two-arg form of the current_setting() function will allow a
fallback value to be returned instead of throwing an error when an
unknown GUC is provided. This w
12 matches
Mail list logo
