Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-12 Thread Florian Helmberger
Hi. Florian, I haven't seen this patch yet. Did you send it in? Yes, I sent it to Christopher for reviewing, as allready mentioned by himself :) I still had not the time to update the docs though, hope to get this done next week. Florian ---(end of

Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-11 Thread Bruce Momjian
Florian, I haven't seen this patch yet. Did you send it in? --- Florian Helmberger wrote: Hi. Huh? isalpha() *is* locale-aware according to the ANSI C spec. For instance, the attached test program finds 52 alpha

Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-11 Thread Christopher Kings-Lynne
PROTECTED]] Sent: Friday, 12 July 2002 6:02 AM To: Florian Helmberger Cc: Tom Lane; Christopher Kings-Lynne; Hackers Subject: Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex Florian, I haven't seen this patch yet. Did you send

Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-11 Thread Bruce Momjian
Christopher Kings-Lynne wrote: Yeah, I've got it Bruce - I still haven't had time to look into it and I really don't know what to do about the backward compatibility issue. How do I set up 2 identically named C functions with different parameter lists? Oh, that is easy. When you CREATE

Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-11 Thread Christopher Kings-Lynne
Christopher Kings-Lynne wrote: Yeah, I've got it Bruce - I still haven't had time to look into it and I really don't know what to do about the backward compatibility issue. How do I set up 2 identically named C functions with different parameter lists? Oh, that is easy. When you

Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-11 Thread Bruce Momjian
Christopher Kings-Lynne wrote: Christopher Kings-Lynne wrote: Yeah, I've got it Bruce - I still haven't had time to look into it and I really don't know what to do about the backward compatibility issue. How do I set up 2 identically named C functions with different parameter lists?

Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-11 Thread Christopher Kings-Lynne
Call them different C names, but name them the same in CREATE FUNCTION funcname. Just use a different symbol name here: CREATE [ OR REPLACE ] FUNCTION name ( [ argtype [, ...] ] ) same here RETURNS rettype AS

Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-11 Thread Bruce Momjian
Christopher Kings-Lynne wrote: Call them different C names, but name them the same in CREATE FUNCTION funcname. Just use a different symbol name here: CREATE [ OR REPLACE ] FUNCTION name ( [ argtype [, ...] ] ) same here

Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-01 Thread Christopher Kings-Lynne
Hi Florian, The most recent patches were submitted by me, so I guess you could call me the defacto maintainer. Okay - glad someone answered me :) Actually, I replied to you 5 minutes after you posted, but I think my emails were being stalled somewhere... I will - please give me a few

Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-01 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: Good idea. Is there a locale-aware version of isalpha anywhere? If there is - I couldn't find it. I did find a lot of frustated posts about isalpha and locale-awareness although. Yeah, I can't find anything in the man pages either. Maybe

Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-01 Thread Florian Helmberger
Hi. Huh? isalpha() *is* locale-aware according to the ANSI C spec. For instance, the attached test program finds 52 alpha characters in C locale and 114 in fr_FR locale under HPUX. I am not at all sure that this aspect of Florian's change is a good idea, as it appears to eliminate

Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-01 Thread Tom Lane
Florian Helmberger [EMAIL PROTECTED] writes: Just tried your example - you're right of course! I will remove the hard coded delimited list and replace it with the proper calls as shown in the code you've sent. Well, that was a quick hack not clean code. Coding rules for stuff inside the

Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-01 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: I think that creating a new function, called ftia or ftix or something is the best solution. I think I can handle doing that... Why change the name? If it's got a different argument list then you can just overload the same old name.

Re: [HACKERS] [PATCHES] Changes in /contrib/fulltextindex

2002-07-01 Thread Christopher Kings-Lynne
I am not at all sure that this aspect of Florian's change is a good idea, as it appears to eliminate locale-awareness in favor of a hard coded delimiter list. Just tried your example - you're right of course! I will remove the hard coded delimited list and replace it with the proper