Re: [HACKERS] [REVIEW] Generate column names for subquery expressions

2011-10-01 Thread Tom Lane
Marti Raudsepp ma...@juffo.org writes: On Wed, Sep 14, 2011 at 05:26, Kyotaro HORIGUCHI horiguchi.kyot...@oss.ntt.co.jp wrote: This is a review for the patch `Generate column names for subquery expressions' (https://commitfest.postgresql.org/action/patch_view?id=632) Thanks for the review.

Re: [HACKERS] [REVIEW] Generate column names for subquery expressions

2011-09-29 Thread Kyotaro HORIGUCHI
Hi, PS: When you send a review, you should add the author's email to the To: line to make sure they see it. I noticed your email only today because it was in a new thread and not addressed to me directly. Thanks for the advise. I will do so after this. Good catch, a new patch is attached.

Re: [HACKERS] [REVIEW] Generate column names for subquery expressions

2011-09-18 Thread Marti Raudsepp
On Wed, Sep 14, 2011 at 05:26, Kyotaro HORIGUCHI horiguchi.kyot...@oss.ntt.co.jp wrote: This is a review for the patch `Generate column names for subquery expressions' (https://commitfest.postgresql.org/action/patch_view?id=632) Thanks for the review. :) PS: When you send a review, you should

[HACKERS] [REVIEW] Generate column names for subquery expressions

2011-09-13 Thread Kyotaro HORIGUCHI
This is a review for the patch `Generate column names for subquery expressions' (https://commitfest.postgresql.org/action/patch_view?id=632) Summary Patch format is in context diff format. This patch applies cleanly on HEAD and make check suceeded. It seems have no problem