Re: [HACKERS] [bug] relcache leaks in get_object_address

2011-10-14 Thread Robert Haas
On Thu, Oct 13, 2011 at 12:27 PM, Kohei KaiGai wrote: > The attached patch fixes this problem. > Unfortunately, we have no code that invokes get_object_address() > with missing_ok = true now, so please apply a couple of patches > to rework DROP statement of mine. > > DROP TRIGGER no_such_trigger O

Re: [HACKERS] [bug] relcache leaks in get_object_address

2011-10-13 Thread Kohei KaiGai
The attached patch fixes this problem. Unfortunately, we have no code that invokes get_object_address() with missing_ok = true now, so please apply a couple of patches to rework DROP statement of mine. DROP TRIGGER no_such_trigger ON existing_table; shall cause a relcache reference leaks, without

[HACKERS] [bug] relcache leaks in get_object_address

2011-10-13 Thread Kohei KaiGai
I noticed a problem of get_object_address() with missing_ok = true. When we try to solve the name of nonexistent rule/trigger/constraint on a particular existing table, get_object_address_relobject() opens the relation, but address.objectId = InvalidOid shall be set. I think it should be closed i