Re: [HACKERS] [bug fix] Stats collector is not restarted on the standby

2016-10-27 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Robert Haas > The delay is intentional. Per pgstat_start(): It's kind of you to tell the reason. > Committed and back-patched all the way. Thanks again! Regards Takayuki Tsunakawa -- Sent

Re: [HACKERS] [bug fix] Stats collector is not restarted on the standby

2016-10-27 Thread Robert Haas
On Wed, Oct 26, 2016 at 8:41 AM, Kuntal Ghosh wrote: > On Wed, Oct 26, 2016 at 4:47 PM, Michael Paquier > wrote: >> >> If you test on a master node that would be the same: there is a delay >> until the stats process restart. I have not

Re: [HACKERS] [bug fix] Stats collector is not restarted on the standby

2016-10-26 Thread Kuntal Ghosh
On Wed, Oct 26, 2016 at 4:47 PM, Michael Paquier wrote: > > If you test on a master node that would be the same: there is a delay > until the stats process restart. I have not looked at the code closely > enough in this area (reaper()?) to determine if there are ways to

Re: [HACKERS] [bug fix] Stats collector is not restarted on the standby

2016-10-26 Thread Michael Paquier
On Wed, Oct 26, 2016 at 7:12 PM, Kuntal Ghosh wrote: > On Wed, Oct 26, 2016 at 12:10 PM, Michael Paquier > wrote: >> On Wed, Oct 26, 2016 at 2:46 PM, Tsunakawa, Takayuki >> wrote: >>> If the stats collector

Re: [HACKERS] [bug fix] Stats collector is not restarted on the standby

2016-10-26 Thread Kuntal Ghosh
On Wed, Oct 26, 2016 at 12:10 PM, Michael Paquier wrote: > On Wed, Oct 26, 2016 at 2:46 PM, Tsunakawa, Takayuki > wrote: >> If the stats collector is forcibly terminated on the standby in streaming >> replication configuration, it won't

Re: [HACKERS] [bug fix] Stats collector is not restarted on the standby

2016-10-26 Thread Tsunakawa, Takayuki
From: Michael Paquier [mailto:michael.paqu...@gmail.com] > It would be a good idea to add that to next CF if nobody pops into the thread > so as we don't forget about it. Thanks for the notice, done. Regards Takayuki Tsunakawa -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [bug fix] Stats collector is not restarted on the standby

2016-10-26 Thread Michael Paquier
On Wed, Oct 26, 2016 at 4:10 PM, Tsunakawa, Takayuki wrote: > From: pgsql-hackers-ow...@postgresql.org >> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier >> Oops. This could be a problem for some applications... As far as I can see >> and

Re: [HACKERS] [bug fix] Stats collector is not restarted on the standby

2016-10-26 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier > Oops. This could be a problem for some applications... As far as I can see > and after playing with it, your patch looks correct. Thank you for checking the patch. I'm relieved.

Re: [HACKERS] [bug fix] Stats collector is not restarted on the standby

2016-10-26 Thread Michael Paquier
On Wed, Oct 26, 2016 at 2:46 PM, Tsunakawa, Takayuki wrote: > If the stats collector is forcibly terminated on the standby in streaming > replication configuration, it won't be restarted until the standby is > promoted to the primary. The attached patch restarts

[HACKERS] [bug fix] Stats collector is not restarted on the standby

2016-10-25 Thread Tsunakawa, Takayuki
Hello, If the stats collector is forcibly terminated on the standby in streaming replication configuration, it won't be restarted until the standby is promoted to the primary. The attached patch restarts the stats collector on the standby. FYI, when the stats collector is down, SELECTs