Re: [HACKERS] 8.1beta, Subtle bug in COPY in Solaris systems

2005-09-01 Thread Sergey E. Koposov
On Thu, 1 Sep 2005, Tom Lane wrote: > "Sergey E. Koposov" <[EMAIL PROTECTED]> writes: > > 2660c2660 > > < if (isdigit(hex)) > > --- > > > if (isdigit((unsigned char)hex)) > > Sigh. We keep fixing these, and they keep creeping back in. I wish > there were a way to get some more-mainstr

Re: [HACKERS] 8.1beta, Subtle bug in COPY in Solaris systems

2005-09-01 Thread Tom Lane
"Sergey E. Koposov" <[EMAIL PROTECTED]> writes: > 2660c2660 > < if (isdigit(hex)) > --- > > if (isdigit((unsigned char)hex)) Sigh. We keep fixing these, and they keep creeping back in. I wish there were a way to get some more-mainstream compiler to warn about passing chars to the fu

[HACKERS] 8.1beta, Subtle bug in COPY in Solaris systems

2005-09-01 Thread Sergey E. Koposov
Hello, First, I'll show the warnings seen when compiling postgres on SunOS 5.6 with gcc 3.2.1 copy.c: In function `GetDecimalFromHex': copy.c:2660: warning: subscript has type `char' copy.c: In function `CopyReadAttributesText': copy.c:2805: warning: subscript has type `char' copy.c:2813: warni