Tom Lane wrote:
> Alvaro Herrera writes:
> > This creates a new sub-section at the bottom of "9.26 System
> > Administration Functions" named "Indexing Helper Functions", containing
> > a table with a single row which is for this function.
>
> Perhaps call it "Index Maintenance Functions"?
>
> >
Alvaro Herrera writes:
> This creates a new sub-section at the bottom of "9.26 System
> Administration Functions" named "Indexing Helper Functions", containing
> a table with a single row which is for this function.
Perhaps call it "Index Maintenance Functions"?
> We can bikeshed whether the new
Jeff Janes wrote:
> Another issue is: it seems to have no SGML documentation. Is that OK?
Here's a patch (which I had to write afresh, because I couldn't find
anything in my brin development tree. Maybe I was just remembering
something I planned to do and never got around to.)
This creates a
On Sun, Dec 27, 2015 at 1:27 AM, Tom Lane wrote:
> Michael Paquier writes:
>> On Sat, Dec 26, 2015 at 7:10 AM, Jeff Janes wrote:
>> What do you think about the attached?
>
> Don't like that as-is, because dropping and re-acquiring the index lock
> presents a race condition: the checks you made m
Jeff Janes wrote:
> On Sat, Dec 26, 2015 at 8:27 AM, Tom Lane wrote:
> > Michael Paquier writes:
> >> On Sat, Dec 26, 2015 at 7:10 AM, Jeff Janes wrote:
> >>> brin_summarize_new_values() does not check that it is called on the
> >>> correct type of index, nor does it check permissions.
> >
> >>
On Sat, Dec 26, 2015 at 8:27 AM, Tom Lane wrote:
> Michael Paquier writes:
>> On Sat, Dec 26, 2015 at 7:10 AM, Jeff Janes wrote:
>>> brin_summarize_new_values() does not check that it is called on the
>>> correct type of index, nor does it check permissions.
>
>> Yeah, it should have those sanit
Michael Paquier writes:
> On Sat, Dec 26, 2015 at 7:10 AM, Jeff Janes wrote:
>> brin_summarize_new_values() does not check that it is called on the
>> correct type of index, nor does it check permissions.
> Yeah, it should have those sanity checks...
Yeah, that is absolutely a must-fix.
> What
On Sat, Dec 26, 2015 at 7:10 AM, Jeff Janes wrote:
> brin_summarize_new_values() does not check that it is called on the
> correct type of index, nor does it check permissions.
Yeah, it should have those sanity checks... On top of that this is not
a really user-friendly message:
=# select brin_su
brin_summarize_new_values() does not check that it is called on the
correct type of index, nor does it check permissions.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
