On Sat, May 10, 2014 at 04:56:51PM +0200, Andres Freund wrote:
> On 2014-05-10 00:59:59 -0400, Noah Misch wrote:
> > Static functions having only one call site are especially vulnerable to
> > inlining, so avoid naming them in the suppressions file. I do see
> > ReorderBufferSerializeChange() inli
On 2014-05-10 00:59:59 -0400, Noah Misch wrote:
> On Fri, May 09, 2014 at 04:58:54PM +0200, Andres Freund wrote:
> > On 2014-05-09 10:49:09 -0400, Robert Haas wrote:
> > > > Patch 03: Add valgrind suppression for writing out padding bytes. That's
> > > > better than zeroing the data from the get go
On Fri, May 09, 2014 at 04:58:54PM +0200, Andres Freund wrote:
> On 2014-05-09 10:49:09 -0400, Robert Haas wrote:
> > > Patch 03: Add valgrind suppression for writing out padding bytes. That's
> > > better than zeroing the data from the get go because unitialized
> > > accesses are still detected.
Hi,
On 2014-05-09 10:49:09 -0400, Robert Haas wrote:
> Committed.
Thanks.
> > Patch 03: Add valgrind suppression for writing out padding bytes. That's
> > better than zeroing the data from the get go because unitialized
> > accesses are still detected.
>
> I have no understanding of valgrind su
On Thu, May 8, 2014 at 12:29 PM, Andres Freund wrote:
> Patch 01: Fix a couple of embarassing typos. Most of them harmless, but
> one isn't and can lead to crashing or decoding wrong data.
Committed.
> Patch 02: Don't crash with an Assert() failure if wal_level=logical but
> max_replication_slot
Hi,
Patch 01: Fix a couple of embarassing typos. Most of them harmless, but
one isn't and can lead to crashing or decoding wrong data.
Patch 02: Don't crash with an Assert() failure if wal_level=logical but
max_replication_slots=0.
Patch 03: Add valgrind suppression for writing out padding bytes
