Re: [HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-31 Thread Stephen Frost
* Fujii Masao (masao.fu...@gmail.com) wrote: > > We should add the tab-completion for ALTER TABLESPACE MOVE? > > Attached does that. > > Committed. Thanks! I had planned to get to it, but appreciate your handling of it. Stephen signature.asc Description: Digital signature

Re: [HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-31 Thread Fujii Masao
On Thu, Jan 30, 2014 at 8:47 PM, Fujii Masao wrote: > On Tue, Jan 21, 2014 at 1:33 AM, Simon Riggs wrote: >> On 20 January 2014 17:00, Stephen Frost wrote: >>> * Tom Lane (t...@sss.pgh.pa.us) wrote: What if you're a superuser and you want to move everybody's objects (perhaps in prepara

Re: [HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-30 Thread Fujii Masao
On Tue, Jan 21, 2014 at 1:33 AM, Simon Riggs wrote: > On 20 January 2014 17:00, Stephen Frost wrote: >> * Tom Lane (t...@sss.pgh.pa.us) wrote: >>> What if you're a superuser and you want to move everybody's objects >>> (perhaps in preparation for dropping the tablespace)? I think there's >>> val

Re: [HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-20 Thread Simon Riggs
On 20 January 2014 17:00, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> What if you're a superuser and you want to move everybody's objects >> (perhaps in preparation for dropping the tablespace)? I think there's >> value in both the ALL and OWNED forms. > > A superuser is cons

Re: [HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-20 Thread Stephen Frost
* Simon Riggs (si...@2ndquadrant.com) wrote: > > ALTER TABLESPACE name MOVE OWNED TO name opt_nowait > > The ALL seems to have value. "MOVE ALL OWNED TO" sounds better. I could go either way on this, really. > > ALTER TABLESPACE name MOVE TABLES OWNED TO name opt_nowait > > ALTER TABLESPACE name

Re: [HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-20 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > What if you're a superuser and you want to move everybody's objects > (perhaps in preparation for dropping the tablespace)? I think there's > value in both the ALL and OWNED forms. A superuser is considered to 'own' all objects and so 'ALL' and 'OWNED' abo

Re: [HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-20 Thread Simon Riggs
On 20 January 2014 15:46, Stephen Frost wrote: > So you're still looking for an 'OWNED' noise word to be added? To clarify what the command is actually doing. > Also, I > did add the ability to specify types of objects (it's often that we'll > have a "INDEXES" tablespace, so this made sense),

Re: [HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-20 Thread Tom Lane
Stephen Frost writes: > So you're still looking for an 'OWNED' noise word to be added? Also, I > did add the ability to specify types of objects (it's often that we'll > have a "INDEXES" tablespace, so this made sense), so how about: > ALTER TABLESPACE name MOVE OWNED TO name opt_nowait > ALTER

Re: [HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-20 Thread Stephen Frost
* Simon Riggs (si...@2ndquadrant.com) wrote: > Not a good argument since IN CURRENT DATABASE applies to all SQL > commands, so would clearly be unnecessary. I suppose it depends on how you're looking at it. ALTER TABLESPACE ... RENAME, for example, updates a shared catalog and therefore the chang

Re: [HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-20 Thread Simon Riggs
On 20 January 2014 14:24, Stephen Frost wrote: > * Simon Riggs (si...@2ndquadrant.com) wrote: >> The command uses the word ALL but then less than all objects, i.e. >> only moves objects that are owned by the user. > > My thinking was that it was "all" from that user's perspective. > >> I would lik

Re: [HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-20 Thread Stephen Frost
* Simon Riggs (si...@2ndquadrant.com) wrote: > The command uses the word ALL but then less than all objects, i.e. > only moves objects that are owned by the user. My thinking was that it was "all" from that user's perspective. > I would like to see two variants of this... > > ALL ... which attem

Re: [HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-20 Thread Simon Riggs
On 16 January 2014 22:37, Stephen Frost wrote: > allow users to more easily move their various objects from > one tablespace to another. Included are docs and a regression test; > I'm happy to improve on both should folks send me suggestions. Sounds good. The command uses the word ALL bu

Re: [HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-18 Thread Robert Haas
On Thu, Jan 16, 2014 at 4:37 PM, Stephen Frost wrote: > Greetings, > > It's a day late and I'm a dollar short, but attached is a (very) minor > patch to allow users to more easily move their various objects from > one tablespace to another. Included are docs and a regression test; > I'm h

[HACKERS] ALTER TABLESPACE ... MOVE ALL TO ...

2014-01-16 Thread Stephen Frost
Greetings, It's a day late and I'm a dollar short, but attached is a (very) minor patch to allow users to more easily move their various objects from one tablespace to another. Included are docs and a regression test; I'm happy to improve on both should folks send me suggestions. As we